Commit Graph

470 Commits

Author SHA1 Message Date
twinaphex 0ba8597041 Cleanups/silence warnings 2018-10-04 16:24:10 +02:00
Twinaphex f07b8b1965
Merge pull request #7090 from Dwedit/fix_missing_content
Fix console mode loading core without content
2018-08-18 16:06:41 +02:00
Dwedit 0e34c12d5c Fixed bug that let Retroarch proceed to retro_run without loading content
Removed unlocalized and redundant error message
2018-08-18 08:40:19 -05:00
Brad Parker c59cbfc4e8 fix memory leaks 2018-08-18 01:07:57 -04:00
Brad Parker 077ef86bab fix null pointer dereferences 2018-08-18 01:07:51 -04:00
radius aa35b9da46 subsystem: set the subsystem correctly 2018-06-14 16:38:27 -05:00
Dwedit 51f7746407 reformat like the old code 2018-05-28 10:58:04 -05:00
Dwedit 8cd8e7d3ae Fix a calloc(0) which led to uninitialized data being used later on. 2018-05-28 10:54:25 -05:00
twinaphex f050104740 Change return type of content_get_subsystem_rom_id 2018-04-17 03:19:35 +02:00
twinaphex 041670fe02 Get rid of multitude of casting warnings 2018-04-13 00:47:42 +02:00
twinaphex 1751f4a0af Make it possible to read bigger files by replacing ssize_t with int64_t
and size_t with uint64_t
2018-04-13 00:18:11 +02:00
twinaphex 3016edce0a Move retroarch.h dependencies out of core_info.c 2018-04-10 04:00:01 +02:00
retro-wertz 55450a5d73
Fix false [ERROR] when closing content
filestream_delete() returns 0 on success, and -1 on failure.
This PR removes this false error when closing content.

e.g.
[ERROR] Failed to remove temporary file: /EMULATORS/ConsoleRoms/Nintendo - Nintendo Entertainment System/Super Mario Bros. (World).nes.
2018-04-03 12:08:53 +08:00
twinaphex 02bf41a686 (task_content.c) Minor cleanup 2018-03-25 00:14:35 +01:00
twinaphex 3c6490d828 Update 2018-03-25 00:09:57 +01:00
Twinaphex ae6e410de1 Remove unused variables 2018-03-01 22:28:26 +01:00
radius fd767f65bd subsystem fix 2018-02-17 12:28:19 -05:00
radius a16cbe7cde de-hardcode rom count 2018-02-12 22:10:44 -05:00
radius 755578fc43 C89 build fixes 2018-02-12 21:19:51 -05:00
radius 1f2054d42f subsystem part 3: cleanups 2018-02-12 02:44:54 -05:00
radius d254c3eca4 subsystem part 3: fix saves 2018-02-12 02:39:26 -05:00
radius 9a23ee8017 subsystem part 3: remove more globals 2018-02-12 02:39:25 -05:00
radius 2a9046c06f subsystem part 3: cleanups 2018-02-12 02:39:25 -05:00
radius 9730fa5c51 subsystem part 2: load content! hacky 2018-02-12 02:39:25 -05:00
radius 752e729ec2 subsystem part 2: set paths 2018-02-12 02:39:24 -05:00
radius b212640732 subsystem part 2: add a wrapper to set the current subsystem 2018-02-12 02:39:24 -05:00
radius 597e0ce1ec subsystem part 1: get the required data to load content 2018-02-12 02:39:23 -05:00
twinaphex 969067b359 Revert "Cleanup code"
This reverts commit 8d835d9b51.
2018-02-05 16:42:02 +01:00
twinaphex 8d835d9b51 Cleanup code 2018-02-05 16:41:02 +01:00
twinaphex d2aa12149f task_load_content - simplify code 2018-02-05 15:37:43 +01:00
twinaphex 7cf4763bfb Add TODO/FIXME note 2018-01-31 23:05:42 +01:00
twinaphex 7b5547d368 Try to be safer with strlcpy calls 2017-12-28 05:56:45 +01:00
Brad Parker 8c0adf3594 move path_file_rename and path_file_remove into VFS 2017-12-14 13:32:26 -05:00
gblues 6904101c44 Clean up trailing whitespace
== DETAILS

Really simple code cleanup, because my editor flags trailing whitespaces
and it's pretty annoying.
2017-12-12 00:24:18 -08:00
David Walters 004c1d2f0a Fix for relative paths being normalised and generating a duplicate history entry. 2017-12-08 23:37:07 +00:00
radius 1003e681cc don't assume the core never has content 2017-11-26 11:33:02 -05:00
twinaphex 5e3eb437ac Change RARCH_ERR invocations 2017-11-26 00:57:02 +01:00
twinaphex 8cc2e9bade Cleanups 2017-11-25 23:06:25 +01:00
Brian Koropoff 711877b056 content: preserve info for history/favorites
If the content came from a playlist, use the original label.
Preserve the core path and name in the favorites list.
2017-11-17 16:55:32 -08:00
twinaphex e5d4e2ac0a Silence a lot of warnings 2017-11-06 19:13:54 +01:00
Roman Kalashnikov 400b27a227
Fixed twice assigned values 2017-10-31 00:26:41 +03:00
orbea 33eb1f9e28 Fix regressions from commit 538d51553c. 2017-10-23 05:39:54 -07:00
orbea 538d51553c When starting content from the cli open the quick menu.
Fix https://github.com/libretro/RetroArch/issues/5554
2017-10-22 08:07:37 -07:00
Brad Parker a7c8cc88e5 win32: support local multibyte encoding for file paths 2017-10-14 23:13:24 -04:00
twinaphex c68db61188 Silence more Clang warnings 2017-10-11 22:49:13 +02:00
twinaphex f34250e38e Buildfix 2017-09-27 23:55:54 +02:00
twinaphex e7d41f6ea7 Cleanup 2017-09-27 23:54:31 +02:00
twinaphex 91b1afad0a (dirs.c/task_content.c) reduce stack usage 2017-09-10 21:42:24 +02:00
twinaphex 750621e28c (tasks/task_content.c) Reduce stack usage 2017-09-09 23:17:28 +02:00
Brad Parker 07566c51a1 VC6 buildfixes, add Makefile.griffin target for it 2017-09-07 11:50:10 -04:00
twinaphex 6af5bd01bf Merge retro_stat and file_path 2017-06-16 15:00:11 +02:00
twinaphex 449483206f Revert "New attempt to fix memory leaks of struct retro_system_info"
This reverts commit a1d3dd69dd.
2017-05-30 01:44:49 +02:00
twinaphex a1d3dd69dd New attempt to fix memory leaks of struct retro_system_info
char variables
2017-05-29 22:24:10 +02:00
twinaphex dfae380f33 Backport patches -
- Attempt to skip cheevos when path is of media type
- Don't do CRC32 encoding for media types
2017-05-29 20:26:10 +02:00
twinaphex 9fa871ccf9 Buildfixes for consoles 2017-05-28 18:33:44 +02:00
twinaphex 3fbed8df27 (Menu) Menu driver no longer uses a duplicate system info
struct
2017-05-28 17:21:57 +02:00
twinaphex c74104f8c9 Get rid of RARCH_MENU_CTL_SYSTEM_INFO_* 2017-05-28 16:25:46 +02:00
twinaphex 9438545bca Add music tab for non-ffmpeg enabled builds now; add 'Run'
and 'Add to mixer' options when selecting Ogg/WAV files
2017-05-27 23:56:10 +02:00
twinaphex bf3188eac4 Combine runloop_ctl and rarch_ctl 2017-05-15 05:06:23 +02:00
twinaphex e2c7671e9f Create rarch_menu_running/rarch_menu_running_finished 2017-05-15 04:31:40 +02:00
twinaphex b9148c1d70 Cleanups 2017-05-15 02:50:14 +02:00
twinaphex c6dd51da35 Cleanups 2017-05-14 20:25:13 +02:00
twinaphex 9e26332c48 Cleanups 2017-05-14 20:23:10 +02:00
twinaphex f70da4c2e2 Cleanups 2017-05-14 05:06:01 +02:00
twinaphex 2df6b201da Cleanup 2017-05-14 05:02:17 +02:00
twinaphex fe56e4ffea Grab from global pointer 2017-05-14 05:00:24 +02:00
twinaphex e6bcb64ced Add name_ips/name_bps/name_ups 2017-05-14 04:52:34 +02:00
twinaphex 70457e06d8 Cleanups 2017-05-14 04:50:57 +02:00
twinaphex 88dbbb284d Add ips_pref/bps_pref/ups_pref to content_information_ctx 2017-05-14 01:12:47 +02:00
twinaphex b75f242a7f Cleanups 2017-05-13 22:35:10 +02:00
twinaphex 42ebe7a7ad Merge runloop.c and retroarch.c 2017-05-11 09:11:46 +02:00
twinaphex 5245590bae (audio_mixer.c) Prevent null pointer dereference 2017-05-08 05:55:20 +02:00
Andre Leiradella 844d1475e6 Reverted cheevos changes in preparation for conversion to task; fixed 4884 2017-05-07 19:06:03 +01:00
twinaphex de80671658 Simplify content_get_crc 2017-05-06 16:41:22 +02:00
twinaphex 46b1b113e0 Cheevos - buildfix 2017-05-06 06:48:32 +02:00
twinaphex 33f2fe8029 Move cheevos.c to tasks/task_cheevos.c and add TODO/FIXME note 2017-05-06 05:50:46 +02:00
twinaphex 44b9943738 Cleanups to task_content.c 2017-05-06 05:19:19 +02:00
twinaphex 2c28505e04 Refactor cheevos_load 2017-05-06 05:13:28 +02:00
twinaphex e6ab06a701 Move path variables 2017-04-29 00:39:29 +02:00
twinaphex ed53be7c81 Move all bool settings 2017-04-28 14:11:34 +02:00
twinaphex eb208b170f Fix codepath for HAVE_MENU not being defined 2017-04-23 17:48:45 +02:00
twinaphex 3ec5816259 Rewrite RUNLOOP_CTL_SYSTEM_INFO_GET 2017-04-23 16:41:26 +02:00
twinaphex b5b87d7735 Avoid 'unused scalar variable' warning 2017-02-23 21:49:51 +01:00
twinaphex 5e6a79c4ac Try to fix Coverity warnings 2017-02-22 01:57:16 +01:00
twinaphex 7c83071b01 Prevent 'explicit NULL dereferenced' 2017-02-21 20:30:52 +01:00
twinaphex f8576ca88c Fix C89_BUILD again 2017-02-21 19:56:43 +01:00
twinaphex 227b862cba Cleanups to task_load_content 2017-02-21 19:09:43 +01:00
twinaphex 85053cb210 Make it unneeded to have to grab settings pointer from
firmware_update_status
2017-02-21 19:06:08 +01:00
twinaphex c215fef8dd Updates 2017-02-21 18:58:03 +01:00
twinaphex f553f3f6bd Cut down on HAVE_MENU ifdefs 2017-02-21 18:55:11 +01:00
twinaphex d789013789 Cut down on some duplicate code 2017-02-21 18:51:47 +01:00
twinaphex 0789fff6df Rename load content tasks 2017-02-21 18:36:47 +01:00
twinaphex d3e8e66b9f Create task_push_load_content_with_current_core_from_companion_ui 2017-02-21 17:29:30 +01:00
twinaphex 03948eafd3 Create task_push_start_builtin_core 2017-02-21 17:22:04 +01:00
twinaphex 9087bc82a0 Add TODO/FIXME note 2017-02-21 17:02:37 +01:00
twinaphex 8206a751f0 Create task_push_load_content_from_cli 2017-02-21 16:59:48 +01:00
twinaphex 1ec7b79ad6 Rename another task 2017-02-21 16:53:02 +01:00
twinaphex d0e49a2d8f Rename some tasks 2017-02-21 16:50:39 +01:00
twinaphex d74f1a56f3 Create load_content_with_new_core_from_companion_ui 2017-02-21 16:30:47 +01:00
twinaphex 4bbf2ab535 Cleanups 2017-02-21 16:11:54 +01:00
twinaphex 36f5504375 Cleanup 2017-02-21 06:37:42 +01:00
twinaphex 81949ae2fe (task_content.c) Cleanups 2017-02-21 05:31:34 +01:00
twinaphex a7592c2db7 Create task_load_content_callback function 2017-02-21 05:17:07 +01:00
twinaphex 0e24e2a9ef Cleanup 2017-02-21 05:07:53 +01:00
twinaphex 14297ef0d9 Cleanups 2017-02-21 04:50:26 +01:00
twinaphex b6fcc0dfac Cleanups 2017-02-21 04:47:01 +01:00
twinaphex 0a3cc7da52 Cleanups 2017-02-21 04:43:08 +01:00
twinaphex 409a7769c6 Cleanup task_push_content_load_default 2017-02-21 04:40:57 +01:00
twinaphex 1582a47bb9 Create task_push_content_load_new_content_with_new_core_from_menu 2017-02-21 04:31:03 +01:00
twinaphex f80064e0a3 Cleanup task_push_content_load_default 2017-02-21 04:18:51 +01:00
twinaphex 90b9cf2d46 Cleanups 2017-02-21 04:11:46 +01:00
twinaphex 0b5118423d Create task_push_content_load_nothing_with_new_core_from_menu 2017-02-21 04:07:40 +01:00
twinaphex e075ade748 Cleanups 2017-02-21 03:55:42 +01:00
twinaphex cca72126f2 Create task_push_content_load_nothing_with_current_core_from_menu 2017-02-21 03:54:34 +01:00
twinaphex 96210188b0 Create task_push_content_load_content_from_playlist_from_menu 2017-02-21 03:44:36 +01:00
twinaphex ba16bee5d1 Create task_push_content_load_nothing_with_dummy_core 2017-02-21 03:32:52 +01:00
Andre Leiradella 0c8ee93e3e Moved cheevos files to their own folder in preparation for the changes to support leaderboards 2017-02-03 10:03:57 +00:00
twinaphex 1a5978d7a2 Move patch.c to tasks/task_patch.c 2017-01-31 05:33:13 +01:00
twinaphex ae4f5104a4 Include patch.c inside task_content.c 2017-01-31 04:53:16 +01:00
twinaphex e802c07d71 Silence warning 2017-01-31 03:57:29 +01:00
twinaphex 018cb7ebe6 Add another parameter to content_get_status 2017-01-25 15:51:57 +01:00
twinaphex 361bd471de Create content_get_status 2017-01-25 15:44:21 +01:00
twinaphex 721e9ec083 (task_content.c) Try to use strlcpy instead of snprintf for
certain messages
2017-01-25 02:05:42 +01:00
Alcaro 6ff36461b4 Fix #4493 in a less incompatible way 2017-01-25 00:34:58 +01:00
twinaphex d28c138d09 (task_content.c) Cleanups 2017-01-23 21:03:41 +01:00
twinaphex 1749941881 Refactor patch.c 2017-01-23 14:56:09 +01:00
twinaphex 96c8ca5a09 Header update #1 2017-01-22 13:40:32 +01:00
twinaphex 6e52a25b86 Attempt to fix 'write to pointer after free' issues 2017-01-14 13:51:20 +01:00
twinaphex 899601e7bb Do an early return inside menu_shader_manager_init if already initialized 2017-01-11 03:36:35 +01:00
twinaphex b3c477902c conditional is not necessary 2017-01-03 19:30:11 +01:00
twinaphex 1d6f88b0ec Try to prevent 'write to pointer after free' issues 2017-01-03 19:07:56 +01:00
twinaphex 1cfc6f571a (RARCH_CONSOLE) Another buildfix 2016-12-27 02:01:22 +01:00
Twinaphex 13536a864b (task_content.c) Prevent warnings 2016-12-27 01:32:58 +01:00
twinaphex 77e5cdbfde Revert "Rename runloop_msg_queue_push to video_driver_msg_queue_push"
This reverts commit ad7386913c.
2016-12-22 23:36:11 +01:00
twinaphex ad7386913c Rename runloop_msg_queue_push to video_driver_msg_queue_push
and move code to video_driver.c
2016-12-22 13:15:02 +01:00
twinaphex 02f1de920a If we load a ROM from the commandline, it will still get pushed
to the history list
2016-12-22 02:42:22 +01:00
twinaphex 711c4116e0 Be more careful with strdup 2016-12-22 00:43:46 +01:00
twinaphex a91e00026b (task_content.c) Only do strdup when variable is non-empty 2016-12-22 00:42:56 +01:00
twinaphex d39acc3f8e Prevent crash when loading a core like 2048 from the commandline 2016-12-22 00:41:36 +01:00
twinaphex 54a569a085 (task_content.c) Cleanup 2016-12-21 15:31:55 +01:00
twinaphex 9dab728067 Cleanup load_content_from_compressed_archive 2016-12-21 15:30:14 +01:00
twinaphex cb28584883 content_file_init_extract - cleanups 2016-12-21 15:27:08 +01:00
twinaphex a5c52dcc07 (task_content.c) Minor cleanups 2016-12-21 15:23:31 +01:00
twinaphex 52c2e1a501 (task_content.c) Cleanups 2016-12-21 15:21:11 +01:00
twinaphex 5f0efed08b (task_content.c) Attempt to fix some coverity bugs 2016-12-21 02:02:47 +01:00
twinaphex b114aa9616 (task_content.c) Put public functions last; reorganization 2016-12-21 00:32:01 +01:00
twinaphex 06e010b318 Remove forced message on content load; in preparation for task-ification 2016-12-21 00:30:23 +01:00
twinaphex a2c0073678 content_file_init_subsystem - cleanup 2016-12-21 00:19:22 +01:00
twinaphex 12255c9f5c Use error_string in order to print (log) messages 2016-12-21 00:16:25 +01:00
twinaphex c13639147e (task_load_content) Cleanups 2016-12-21 00:06:34 +01:00