Commit Graph

373 Commits

Author SHA1 Message Date
sonninnos ee8993c76a
Silence Linux snprintf warnings (#14131) 2022-07-02 14:08:27 +02:00
libretroadmin 60161982b2 (task_database) Simplify code - put logging behind DEBUG ifdef 2022-06-18 19:19:18 +02:00
Romeo 686628b8ad
(Database) Serial scanning for Wii now includes WBFS (#13816)
* Update task_database.c
2022-04-03 04:08:30 +02:00
pkos a192064403 (Database) Serial scanning for Gamecube/MegaCD/SegaCD/Saturn/PSX/PSP/Dreamcast/Wii 2021-12-31 21:35:16 -05:00
Nathan Strong fb86ca6e33 Fix the snprintf warnings for everyone this time
== DETAILS
So, basically this back-and-forth is because we used fixed-size
data types (i.e. `uint32_t`) which maps to different primitive data
types on different platforms. So `uint32_t` might be a `long` on some
platforms (e.g. Wii U), while it's just a plain integer on others (PC).
And the format specifier works off primitive data type, not data type
size.

So, to resolve this, we:

- keep `%lx` as the format specifier
- cast the parameter to printf to unsigned long

This is better than the alternatives that could cause problems trying to
cast a long down to an int.
2021-09-25 15:08:34 -07:00
Nathan Strong 9b2d4236ad WIIU: Clean up a bunch of compiler warnings
== DETAILS
These changes fall into a few broad categories:

1. Explicitly undefine things we want to re-define due to conflicts with
   the version of devkitpro we're using
2. Clean up hex format specifiers to use `%lx` or `%lX` when working with
   long integers
3. Move variables inside the ifdef they're used in to squelch "unused variable"
   messages
4. Add parenthesis to make Wii U shader declarations stop complaining

And then there's a weird "misleading indent" warning that I fixed by just
rewriting a block of code to use a switch statement instead of if-then-else.

These changes work fine on Wii U, but we'll need to keep an eye on CI/CD to see
if other platform builds break.
2021-09-25 13:25:39 -07:00
twinaphex 2f0f724813 Use more path_basename_nocompression where we don't have to deal with
archive files
2021-04-11 18:46:50 +02:00
twinaphex 55ba377153 (task_database.c) Don't call path_contains_compressed_file multiple
times
2021-03-22 20:14:58 +01:00
twinaphex f22b077887 (task_database.c) Optimizations:
- strlen was being called on path for each loop iteration, when
path is not subject to change - do it once outside
- String copying was being performed even when the string would
equal a string not subject to change
2021-03-22 19:24:14 +01:00
jdgleaver 54ce950591 Fix database scans 2020-11-09 14:31:53 +00:00
twinaphex e58cb34970 Remove ifdef and make this the default for now - and add TODO/FIXME note 2020-11-08 18:31:12 +01:00
unknown be6d1841d5 fix segmentation fault on PS3 when scan directory 2020-11-08 16:06:00 +01:00
twinaphex 216190b826 Clean up more string variables on heap - move to stack 2020-08-18 14:26:15 +02:00
twinaphex 1aceac6edb Struct reorders 2020-08-14 18:51:50 +02:00
francescotintori 9744fcb76a Adds base content directory support in playlists. If playlist base content directory does not match configuration parameter 'rgui_browser_directory', all entries paths are automatically fixed to match parameter 'rgui_browser_directory'.
Functionality is enabled if new parameter 'playlist_autofix_paths' is enabled.
2020-07-27 20:59:56 +02:00
jdgleaver 0fcfb3deda Refactor playlist struct configuration 2020-06-26 15:40:19 +01:00
twinaphex f5940ed188 Use malloc instead of calloc where possible 2020-06-24 19:27:02 +02:00
Jamiras 6e7eeb1d8f prevent NULL reference exception when scanning some directories 2020-06-21 22:35:35 -06:00
twinaphex 30bfca0d71 (task database) Optimize extension_to_file_type 2020-06-11 02:53:31 +02:00
twinaphex 8eee7b3bb9 (Task database) Cleanups 2020-06-10 16:24:52 +02:00
Autechre 30a4610b12
Merge pull request #10788 from jdgleaver/core-backup
Add option to backup/restore installed cores
2020-06-04 16:30:55 +02:00
twinaphex 9fda2bdebd Add TODO/FIXME comments 2020-06-04 14:09:45 +02:00
jdgleaver 0a33e562f4 Add option to backup/restore installed cores 2020-06-04 12:20:58 +01:00
jdgleaver fa9290cf1e Add optional playlist compression 2020-04-21 16:44:26 +01:00
twinaphex 8627d638e1 Cleanups 2020-02-04 06:05:00 +01:00
twinaphex 278dc75285 (tasks) Fix samples 2020-01-04 12:07:58 +01:00
twinaphex 9c6c10da22 (Playlist) Get rid of settings_t dependency 2020-01-04 12:04:00 +01:00
jdgleaver 170397456c Add manual content scanner 2019-11-29 17:14:46 +00:00
twinaphex ec4bfd7827 Silence some warnings - statement unreachable etc. 2019-09-20 06:17:40 +02:00
twinaphex ab515daa0c Try to get rid of file_path_str 2019-09-18 18:12:57 +02:00
Brad Parker f3faecdb27 scanner: skip archive files with no CRC instead of looping forever 2019-07-31 12:41:49 -04:00
jdgleaver 5220dc9084 Add independent 'favourites' playlist size setting 2019-07-30 17:13:04 +01:00
Brad Parker e35eff126a show taskbar progress for scanner 2019-05-22 01:31:55 -04:00
Brad Parker 21725e484c scanner: skip all databases with incompatible file extensions, whether file is inside an archive or not 2019-05-22 00:21:31 -04:00
twinaphex 1a1418ccfb (Samples) tasks/database - should work again 2019-05-21 22:38:50 +02:00
twinaphex 705851b147 Add 'Scan without Core Match' 2019-05-05 21:54:49 +02:00
natinusala 90fb11cb9a task_database: set task title upon completion 2019-05-01 15:26:21 +02:00
natinusala 486f438cc3 task_database: reimplement task progression 2019-05-01 15:13:41 +02:00
twinaphex 34be5862ee (task_database) Use task_init 2019-04-30 10:25:23 +02:00
twinaphex 2d99cdcbf3 Add function parameter to task_iterate_database_start 2019-04-30 10:18:25 +02:00
twinaphex 9e2c82c26e (Scanner) Shorten scanner string 2019-04-30 10:12:00 +02:00
Twinaphex a797324133
Revert "task_database: use regular progress report" 2019-04-30 10:01:07 +02:00
natinusala 8c7db837b4 task_database: use regular progress report 2019-04-29 20:04:41 +02:00
twinaphex 4c3e0d44b8 Revert "Start using string_is_equal_memcmp and"
This reverts commit 26d6aee1eb.
2019-04-29 04:04:33 +02:00
twinaphex 26d6aee1eb Start using string_is_equal_memcmp and
string_is_equal_memcmp_fast
2019-04-28 17:23:11 +02:00
twinaphex b3686aee4c Initialize playlist_entry manually 2019-04-24 02:10:45 +02:00
Brad Parker f7b0c0947c add subsystem_name (friendly name) to history playlist, make playlist_entry struct public to simplify function parameters 2019-04-12 12:50:27 -04:00
Brad Parker 230c64ba4b add subsystem support for playlists, only missing the content load portion 2019-04-11 00:09:13 -04:00
Brad Parker 4f0d61a2ac update copyright 2019-02-22 19:13:36 -05:00
rlnilsen e71b6d6d23 Fix content scanner creating false positive playlist entries that also have wrong label and crc32. 2019-02-21 04:24:07 +01:00
twinaphex 7022786f34 Revert parts of menu_widgets that were causing breakage, but leave
all the hooks in so we can add them back piece by piece again
2019-02-08 07:26:43 +01:00
natinusala c20ab3864d First version of menu widgets (gl only) 2019-02-06 20:48:24 +01:00
orbea 28ff4b391a Clean up white space. 2019-02-03 16:00:50 -08:00
twinaphex c98b2e2292 Buildfixes and more static code analysis warning fixes 2019-01-10 22:24:43 +01:00
orbea bfc366decc Squeeze extra blank lines with cat(1).
Example:

find . -type f -iname '*.c' | while read -r i; do
  cat -s "$i" > "$i.new"
  mv "$i.new" "$i"
done
2019-01-08 11:04:58 -08:00
Sven fc40e6ac85 fix gdi scanning - database only contains crcs for track 1 - so do not try to find largest track - just stop on track 1 2018-10-02 15:15:45 -04:00
twinaphex 6825cb2cc7 task_database.c - use string_is_equal 2018-09-20 12:48:00 +02:00
Brad Parker a1aefc901c Qt WIMP GUI 2018-04-30 14:33:05 -04:00
Rob Loach 00092eb5ea
feat: Add Wii Backup File WBFS scanning 2018-04-29 09:51:38 -04:00
twinaphex 041670fe02 Get rid of multitude of casting warnings 2018-04-13 00:47:42 +02:00
twinaphex 1751f4a0af Make it possible to read bigger files by replacing ssize_t with int64_t
and size_t with uint64_t
2018-04-13 00:18:11 +02:00
twinaphex c24179dc63 Scanning should now work in standalone program 2018-04-10 05:16:33 +02:00
twinaphex c9e48cd9de Cleanups / get rid of more dependencies 2018-04-10 04:31:19 +02:00
twinaphex 6f0fc2426d (database_info/task_database) Get rid of list_special dependencies 2018-04-10 04:13:45 +02:00
twinaphex 06bafe3cc3 Fix typo 2018-04-10 02:41:09 +02:00
twinaphex be0c118c87 (task_database.c) Don't use msg_hash_calcualte and msg_hash_to_file_type 2018-04-10 01:18:40 +02:00
twinaphex fdec9c50e0 (task_database.c) Add some RARCH_INTERNAL ifdefs 2018-04-09 19:26:49 +02:00
Twinaphex 08a54e45f2 Get rid of a lot of implicit conversions 2018-04-09 15:56:45 +02:00
twinaphex 0ee124582c Silence another Coverity warning 2018-02-02 21:53:58 +01:00
twinaphex 61ff51be2f Start using string_is_equal predominantly 2018-01-16 22:53:38 +01:00
gblues 0f7de204f7 Last batch of whitespace cleanup (post-rebase)
-- looks like a few files committed with DOS line endings
2017-12-12 00:24:46 -08:00
gblues 6904101c44 Clean up trailing whitespace
== DETAILS

Really simple code cleanup, because my editor flags trailing whitespaces
and it's pretty annoying.
2017-12-12 00:24:18 -08:00
twinaphex c4d8a8c800 Free after intfstream_close 2017-12-11 20:24:00 +01:00
twinaphex 61d3f90cae Add hint defines to libretro.h 2017-12-11 12:53:47 +01:00
twinaphex 38e6d2443f Change functions 2017-12-11 12:31:14 +01:00
twinaphex 8aa4d6d148 Move convenience functions to interface_stream.c 2017-12-11 12:23:40 +01:00
twinaphex 6897f9a987 Pass hints to intfstream_open_file 2017-12-11 12:20:06 +01:00
twinaphex 318f17c4cb Start using VFS API constant defines 2017-12-11 12:15:00 +01:00
twinaphex 2e979ec537 Replace function signatures of file_stream file functions 2017-12-10 22:25:38 +01:00
twinaphex d75c187c5b Don't show 'Scanning of Directory Finished' if we are scanning a
file instead
2017-11-27 07:04:52 +01:00
Brian Koropoff fb5e788c1e task_database: fix crash from Windows-incomptabile format string 2017-11-24 18:17:43 -08:00
Brian Koropoff bedf65e72e scanner: prioritize databases with recent matches
This should improve performance when scanning many files
in a row that all match against the same database, which is
the expectation.
2017-11-17 16:53:49 -08:00
Brian Koropoff b668193923 scanner: allow matching archives by member
This allows more flexible detection of content packaged as multiple
compressed files (e.g. MAME).
2017-11-17 16:53:49 -08:00
Jean-André Santoni bd17c11350 Fix gamecube scanning 2017-10-27 15:17:18 +07:00
Jean-André Santoni 2ddba6770d Start implementing gamecube scanning 2017-10-27 15:17:18 +07:00
Alcaro b97853a536 Rename STRING_REP_ULONG to STRING_REP_USIZE 2017-10-02 22:51:51 +02:00
twinaphex 3040d1da36 (task_database.c) Simplify conditionals 2017-09-30 06:21:38 +02:00
twinaphex bae31a318d Prevent memory leak 2017-09-29 21:32:05 +02:00
twinaphex 3490c3dbc5 Cleanups 2017-09-29 20:51:20 +02:00
twinaphex 3090f3ff3a (task_database.c) Rewrite char arrays 2017-09-29 20:47:54 +02:00
twinaphex 6cf6d46e4b Try silencing more warnings - do something with return value 2017-09-26 03:51:50 +02:00
twinaphex cc8e897222 C89_BUILD fixes 2017-09-22 05:12:26 +02:00
twinaphex 50d48139a3 Fix some more memory leaks 2017-09-21 23:38:29 +02:00
twinaphex 1a77c383b9 Fix plethora of memory leaks again 2017-09-21 21:33:13 +02:00
twinaphex 0f80e31382 task_database.c - cleanups 2017-09-21 19:57:10 +02:00
Twinaphex cff35f3611 Fix warning - wrong type used 2017-09-21 19:24:42 +02:00
twinaphex 0002912328 Change size of variables 2017-09-20 16:35:18 +02:00
twinaphex 808a723969 Fix memory leaks 2017-09-20 12:18:31 +02:00
twinaphex ac732ecdb0 Fix memory leak 2017-09-20 12:13:44 +02:00
twinaphex 37715114ae Cleanup 2017-09-20 09:55:53 +02:00