Commit Graph

1494 Commits

Author SHA1 Message Date
twinaphex 03dac742cb (task_content.c) Some more cleanups 2018-10-29 04:59:54 +01:00
twinaphex e6dfa35f9d (task_content.c) More cleanups 2018-10-29 04:48:22 +01:00
twinaphex 305a07a3f3 Create some variables for size 2018-10-29 04:43:05 +01:00
twinaphex e31c4f541a Simplify init_subsystem function 2018-10-29 04:04:25 +01:00
radius 32766f0017 [content] CRC calculation for needs_fullpath should be within else block 2018-10-28 19:40:18 -05:00
Nathan Strong edacf67e75 Capture CRC content for deferred-loading cores
== DETAILS

Fixes a bug where content CRC32 is not calculated when content loading
is done by the core instead of libretro. This impacts the ability to
do accurate content matching on netplay.

This notably affects MAME, but is by no means limited to MAME.

Change summary:
- adds a method to the crc32 implementation that calculates crc32 for
  a file (as opposed to an in-memory buffer)
- fix a minor bug that would print the "core will load its own content"
  right before attempting to load compressed content
- in the actual "core will load its own content" path, calculate the CRC32
  and log it before returning

== TESTING
Tested locally on OSX:
- loaded content
- started netplay
- confirmed CRC showing in netplay data
- verified CRC32 against external crc32 tool
2018-10-18 11:26:45 -07:00
twinaphex 421e6178e5 Buildfix 2018-10-17 18:20:01 +02:00
Nathan Strong 0abe42d9a4 Rewrite content search task
== DETAILS

In attempting to identify where netplay lobby errors were occuring,
I found that the code which does the content search was pretty messy,
so I've cleaned it up.

- Search is now more efficient. Playlists are only iterated over once,
  instead of twice.
- Error messages are more helpful
- Eliminated goto abuse
- code is easier to follow and has comments describing the logical
  flow.

== TESTING
Tested lightly locally, although hard to test thoroughly due to tight
netplay requirements.
2018-10-16 22:40:13 -07:00
twinaphex 0ba8597041 Cleanups/silence warnings 2018-10-04 16:24:10 +02:00
Sven fc40e6ac85 fix gdi scanning - database only contains crcs for track 1 - so do not try to find largest track - just stop on track 1 2018-10-02 15:15:45 -04:00
M4xw 03ad3b5c30 [LIBNX] Remove task_autodetect workaround 2018-09-29 19:36:12 +02:00
twinaphex 931397671f Increase size of string to silence warning 2018-09-28 21:40:17 +02:00
twinaphex 6825cb2cc7 task_database.c - use string_is_equal 2018-09-20 12:48:00 +02:00
twinaphex 09d27fc591 Silence some warnings 2018-09-15 07:19:51 +02:00
M4xw 3a6e410833 [LIBNX] Add pthreads wrapper 2018-09-15 02:28:52 +02:00
twinaphex 7c2da36af9 Prevent warning 2018-09-08 02:11:18 +02:00
Sven b4081d9347 implement libretro private def to allow cores to tell RA to save states in background 2018-09-07 19:09:56 -04:00
Tatsuya79 dd9db41403
fix task_save.c 2018-09-01 01:50:30 +02:00
Tatsuya79 64459bda3a
revert #7156
revert https://github.com/libretro/RetroArch/pull/7156
2018-09-01 01:41:21 +02:00
Twinaphex e2a650cb26 Remove unused variable 2018-08-31 19:02:47 +02:00
Sven 75abd1f36e Merge remote-tracking branch 'upstream/master' 2018-08-30 12:07:41 -04:00
Sven b8ab6c1e74 push save state into background for cores that need the emulator to be running to correctly save states 2018-08-30 11:21:31 -04:00
Brad Parker 23836bfba9 use_thread option for screenshot was backwards 2018-08-27 13:38:43 -04:00
Brad Parker b0146abd11 add fullpath and use_thread parameters to take_screenshot() 2018-08-18 23:08:55 -04:00
Twinaphex f07b8b1965
Merge pull request #7090 from Dwedit/fix_missing_content
Fix console mode loading core without content
2018-08-18 16:06:41 +02:00
Dwedit 0e34c12d5c Fixed bug that let Retroarch proceed to retro_run without loading content
Removed unlocalized and redundant error message
2018-08-18 08:40:19 -05:00
Brad Parker c59cbfc4e8 fix memory leaks 2018-08-18 01:07:57 -04:00
Brad Parker 077ef86bab fix null pointer dereferences 2018-08-18 01:07:51 -04:00
Brad Parker a1b831abdb allow 7z archives to have multiple files extracted at once 2018-08-06 20:44:59 -04:00
Sven 5f35249216 Implement robust cheat searching interface with rumble features 2018-07-25 19:19:14 -04:00
radius aa35b9da46 subsystem: set the subsystem correctly 2018-06-14 16:38:27 -05:00
retro-wertz ce27e986e9
Better no log at all than showing a false log
This false message has been like foreve. Nobody seems interested in updating "small and minor" things. so lets just remove this....
2018-06-11 17:08:59 +08:00
Dwedit 51f7746407 reformat like the old code 2018-05-28 10:58:04 -05:00
Dwedit 8cd8e7d3ae Fix a calloc(0) which led to uninitialized data being used later on. 2018-05-28 10:54:25 -05:00
twinaphex 5e32f7ab40 Add To Mixer and Add To Mixer And Play actions 2018-05-02 20:39:55 +02:00
twinaphex 9fbfd503af Add value descriptions for audio mixer streams 2018-05-02 20:13:13 +02:00
twinaphex eff75a3bcd Move nbio_buf_t to task_audio_mixer.c 2018-05-02 19:30:06 +02:00
Brad Parker a1aefc901c Qt WIMP GUI 2018-04-30 14:33:05 -04:00
twinaphex 5aeab54ab7 (Audio mixer) Ability to individually set volume per stream 2018-04-30 17:51:01 +02:00
twinaphex 965859ddcb Start adding mixer controls - ability to stop and remove loaded tracks 2018-04-30 14:34:25 +02:00
Rob Loach 00092eb5ea
feat: Add Wii Backup File WBFS scanning 2018-04-29 09:51:38 -04:00
twinaphex e7272ddefa (Audio mixer) Add MP3 support as well 2018-04-28 14:18:04 +02:00
twinaphex 3f7c318e3f (Audio mixer) Add FLAC support to audio mixer 2018-04-28 11:17:37 +02:00
twinaphex f050104740 Change return type of content_get_subsystem_rom_id 2018-04-17 03:19:35 +02:00
twinaphex 041670fe02 Get rid of multitude of casting warnings 2018-04-13 00:47:42 +02:00
twinaphex 1751f4a0af Make it possible to read bigger files by replacing ssize_t with int64_t
and size_t with uint64_t
2018-04-13 00:18:11 +02:00
twinaphex 6761ec471d Silence some Coverity warnings 2018-04-12 21:39:31 +02:00
i30817 7da45bc789
Serial magic should only match on full match
As was mentioned on the wii dual layer disc issue, this line is comparing binary sequences as strings, which fails very obviously because neither of the 'strings' tested are strings and it's very likely both start with \0.
2018-04-11 01:37:35 +01:00
twinaphex c24179dc63 Scanning should now work in standalone program 2018-04-10 05:16:33 +02:00
twinaphex c9e48cd9de Cleanups / get rid of more dependencies 2018-04-10 04:31:19 +02:00
twinaphex 6f0fc2426d (database_info/task_database) Get rid of list_special dependencies 2018-04-10 04:13:45 +02:00
twinaphex 3016edce0a Move retroarch.h dependencies out of core_info.c 2018-04-10 04:00:01 +02:00
twinaphex 06bafe3cc3 Fix typo 2018-04-10 02:41:09 +02:00
twinaphex be0c118c87 (task_database.c) Don't use msg_hash_calcualte and msg_hash_to_file_type 2018-04-10 01:18:40 +02:00
twinaphex 908de15e7b Start adding samples - not done yet 2018-04-09 22:12:59 +02:00
twinaphex 22e5d000c2 Cleanups 2018-04-09 19:30:36 +02:00
twinaphex fdec9c50e0 (task_database.c) Add some RARCH_INTERNAL ifdefs 2018-04-09 19:26:49 +02:00
Twinaphex 08a54e45f2 Get rid of a lot of implicit conversions 2018-04-09 15:56:45 +02:00
retro-wertz 55450a5d73
Fix false [ERROR] when closing content
filestream_delete() returns 0 on success, and -1 on failure.
This PR removes this false error when closing content.

e.g.
[ERROR] Failed to remove temporary file: /EMULATORS/ConsoleRoms/Nintendo - Nintendo Entertainment System/Super Mario Bros. (World).nes.
2018-04-03 12:08:53 +08:00
twinaphex 3fe6ecbce7 More static analyzer warning fixes 2018-03-29 14:19:24 +02:00
twinaphex 02bf41a686 (task_content.c) Minor cleanup 2018-03-25 00:14:35 +01:00
twinaphex 3c6490d828 Update 2018-03-25 00:09:57 +01:00
radius fd9d8c9512 fix potential crash on task_push_http_transfer 2018-03-18 12:52:04 -05:00
radius c52fdc469f remove task_push_http_transfer_raw, encode before sending data to the task 2018-03-16 22:38:21 -05:00
meleu eb5a69ded3 fixing cheevos (broken after #6389) 2018-03-16 01:03:57 -03:00
radius b01e63e2cd make sure to always encode urls, also change the PS3 default urls 2018-03-14 23:04:50 -05:00
Twinaphex ae6e410de1 Remove unused variables 2018-03-01 22:28:26 +01:00
twinaphex 0de23512e7 Should fix APK extraction (hopefully) 2018-03-01 14:59:37 +01:00
twinaphex 74309e6e1c shader code - Get rid of more hashes 2018-02-25 17:20:22 +01:00
twinaphex f00d194ae3 Get rid of more hashes 2018-02-25 16:32:54 +01:00
twinaphex fae9223641 Remove hashes from task_overlay 2018-02-25 13:03:54 +01:00
radius fd767f65bd subsystem fix 2018-02-17 12:28:19 -05:00
twinaphex ff831a7d99 Silence Coverity warning 2018-02-15 13:07:46 +01:00
radius a16cbe7cde de-hardcode rom count 2018-02-12 22:10:44 -05:00
radius 755578fc43 C89 build fixes 2018-02-12 21:19:51 -05:00
radius 1f2054d42f subsystem part 3: cleanups 2018-02-12 02:44:54 -05:00
radius d254c3eca4 subsystem part 3: fix saves 2018-02-12 02:39:26 -05:00
radius 9a23ee8017 subsystem part 3: remove more globals 2018-02-12 02:39:25 -05:00
radius 2a9046c06f subsystem part 3: cleanups 2018-02-12 02:39:25 -05:00
radius 9730fa5c51 subsystem part 2: load content! hacky 2018-02-12 02:39:25 -05:00
radius 752e729ec2 subsystem part 2: set paths 2018-02-12 02:39:24 -05:00
radius b212640732 subsystem part 2: add a wrapper to set the current subsystem 2018-02-12 02:39:24 -05:00
radius 597e0ce1ec subsystem part 1: get the required data to load content 2018-02-12 02:39:23 -05:00
twinaphex 457d543cb1 Get rid of callback function hashes 2018-02-05 19:14:55 +01:00
twinaphex 969067b359 Revert "Cleanup code"
This reverts commit 8d835d9b51.
2018-02-05 16:42:02 +01:00
twinaphex 8d835d9b51 Cleanup code 2018-02-05 16:41:02 +01:00
twinaphex d2aa12149f task_load_content - simplify code 2018-02-05 15:37:43 +01:00
twinaphex 69fedc6b40 task_screenshot.c - remove XBOX1 specific code 2018-02-05 00:29:05 +01:00
twinaphex 9dd33b9797 More CXX_BUILD linking error fixing 2018-02-04 20:57:30 +01:00
aliaspider 700fce3bd2 various fixes for CXX_BUILD. 2018-02-04 20:03:27 +01:00
twinaphex 0ee124582c Silence another Coverity warning 2018-02-02 21:53:58 +01:00
twinaphex 7cf4763bfb Add TODO/FIXME note 2018-01-31 23:05:42 +01:00
bparker06 3d2c579bc7
Change Bliss-Box feature report size per ulao 2018-01-28 20:26:47 -05:00
twinaphex 8e3b3762ad More compatibility fixes for CXX_BUILD 2018-01-25 16:33:28 +01:00
twinaphex ed38887910 (VS2017) Update solution 2018-01-23 08:38:40 +01:00
twinaphex 924007eda2 Prevent calling task_image_process if image is NULL 2018-01-23 04:57:12 +01:00
aliaspider 5db96f35fa (WIN32) various build fixes. 2018-01-20 20:05:32 +01:00
radius d1dba26565 fix display name for builtin autoconfs again 2018-01-16 22:18:28 -05:00
twinaphex 897c1654ab Reduce usage of string_is_not_equal_fast 2018-01-17 01:03:48 +01:00
twinaphex 61ff51be2f Start using string_is_equal predominantly 2018-01-16 22:53:38 +01:00