Commit Graph

269 Commits

Author SHA1 Message Date
LibretroAdmin b2634ea588 * Create fill_pathname_join_special - and specify fill_pathname_join
as deprecated.
* Use fill_pathname_join_special in the vast majority of cases where
we can ensure out_path is a new empty string
* Get rid of some extension concatenation with strlcat where encountered
* Some general cleanups with NULL termination of strings that get immediately
passed to strlcpy/strlcpy-adjacent functions
2022-08-04 14:19:38 +02:00
LibretroAdmin e7f3432e48 Replace some trivial strlcat usage - use return value of preceding
strlcpy then simply append the extension to it at this location
2022-08-04 03:45:09 +02:00
LibretroAdmin 819337d5d4 video_shader_get_type_from_ext - get rid of unnecessary strlen 2022-08-03 23:35:16 +02:00
LibretroAdmin 592f9384b0 Silence code analysis warnings by Xcode - unused variables - nothing
done with value set - etc
2022-07-29 08:29:43 +02:00
libretroadmin cedbcb10c6 Take out some more unnecessary NULL string termination 2022-07-25 14:12:54 +02:00
libretroadmin 4b5c7856e6 Remove some more explicit NULL-termination when we're calling a
string function that calls strlcpy under the hood
2022-07-19 20:43:12 +02:00
LibretroAdmin 29774f5b7a
Small opts (#14186)
* (joypad_connection) Small optimizations -
* Turn functions static where possible
* Hose strlen call out of loop

* (input_driver.c) General cleanups:
* Some small code/style nits

task_screenshot.c:
* Move widget callback function for screenshots to task_screenshot.c

(file_path.c):
* Turn get_pathname_num_slashes into static function
* path_linked_list_free - always returns true, so get rid of return value
* path_linked_list_new - fix function signature
* path_get_archive_delim - do not NULL-terminate string, already done by strlcpy later on

General:
* Slight optimizations - use int/size_t for loop counter variable instead of unsigned
* Take advantage of fact that strlcpy already NULL-terminates, so don't do this explicitly
outside if we're just going to end up calling strlcpy/fill_pathname_join on it anyway
2022-07-19 10:01:33 +02:00
libretroadmin 8f37c2e3c2 Don't call config_set_bool, call config_set_string directly 2022-07-18 01:59:32 +02:00
libretroadmin 4b1766cf61 Silence more -Wdocumentation warnings 2022-07-15 01:12:04 +02:00
libretroadmin 99ac1af9d2 (video_shader_parse)
* Return value of function was never used, so remove it
* Move variables to proper scope
* Miscellaneous cleanups
2022-07-11 14:00:35 +02:00
libretroadmin f4803b1023 Silence warning - video_shader_is_shader_chain_config 2022-07-01 14:16:13 +02:00
libretroadmin fae8d7e38f (Debug) Fix build failure 2022-06-21 03:33:36 +02:00
libretroadmin 4f1ad9b665 video_shader_load_preset_into_shader - remove unused variable 2022-06-18 19:08:30 +02:00
HyperspaceMadness 8d177ed865 Shader Load Extra Parameter Reference Files
When a shader preset is loaded now when there are more than one #reference line the parameter values will be loaded from the references after the first one
2022-06-04 20:12:21 -04:00
LibretroAdmin 6ba8fe225d
Revert "Shader Preset Loading of Multiple additional #references lines for settings" 2022-05-30 02:39:25 +02:00
Remi McGill 684889507b Shader Loading of Multiple References for settings
Multi reference settings working

Config fixes

Multi-Reference Loading Working, Checking for shader chain not working

Checking References is working

Improved path_linked_list_add_path

Simplify path list stuff

Fixed Static Definition

Fixes

Fixes

Fix to Trigger PR Update

Removed Legacy Orbis which got left in a merge

Memory Leak Fix
2022-05-24 14:07:55 -04:00
libretroadmin 87b76dc7a4 (video_shader_parse.c) Cleanups 2022-05-17 14:12:02 +02:00
twinaphex 4d112da58d Silence some MSVC code analysis warnings 2022-03-07 19:02:46 +01:00
jdgleaver f6dc1c6d93
Disable per-game and per-content-directory shader presets when running contentless cores (#13690) 2022-03-01 09:44:55 +01:00
Tony 6d5d2e722d
Logging cleanups (#13579) 2022-01-31 18:05:23 +01:00
Tony 09880e92d2
Logging cleanups (#13320) 2021-12-04 14:21:12 +01:00
twinaphex bf8cae10a3 Move retroarch_get_shader_preset to video_shader_parse.c 2021-10-29 16:35:50 +02:00
twinaphex ec7b7821fa Move code out of retroarch.c 2021-10-29 14:13:16 +02:00
twinaphex 9b4636ff62 Fixes --disable-menu 2021-10-15 14:32:07 +02:00
twinaphex b3d724b7a3 Move code out of retroarch.c 2021-09-18 22:05:03 +02:00
twinaphex 2490f6e215 Move code from retroarch.c to video_shader_parse.c 2021-09-11 18:15:35 +02:00
twinaphex 544a17926b Use path_basename_nocompression where we are sure we are not
dealing with a filename with a compressed archive hash
2021-04-11 17:44:41 +02:00
twinaphex 78f7deffba Get rid of early return in video_shader_write_root_preset 2021-03-24 18:44:55 +01:00
twinaphex d911dd6efc (video_shader_parse.c) Tons of functions here should have been
made static, tons of log spam put behind DEBUG ifdefs
2021-03-24 18:31:20 +01:00
Autechre 33110603e5
Shader log spam reduction (#11977)
* (Shaders) Change label

* Create RARCH_DBG - if you have Logging Verbosity set to 0, the
shader parsing log spam will show, otherwise it won't
2021-02-03 13:49:07 +01:00
twinaphex f4a20870c7 video_shader_write_referenced_preset - logic flaw -
loaded_shader_preset_path is a character array - conditional boolean
check would always evaluate to true - check if string is empty
instead
2021-01-18 20:30:21 +01:00
twinaphex 552f973833 Cleanups/remove unused variables 2021-01-16 17:17:16 +01:00
Autechre 9797ba9f27
Merge pull request #11743 from HyperspaceMadness/Shaders_Fix_Simple_Preset_Relative_Texture_Paths
Shaders Load Refactor and Fix Referenced Texture Loading
2020-12-31 16:13:20 +01:00
Remi McGill 8d1b949c9c Shaders Fix Config Memory Leak 2020-12-30 11:02:59 -05:00
twinaphex 357b7d68f6 (libretro-common) Rename rhash to lrc_hash
(rcheevos) Rename rhash to rc_hash
2020-12-28 19:55:54 +01:00
HyperspaceMadness f86dbfc5a2 Shaders Fix Referencing issue in QT 2020-12-27 20:32:43 -05:00
Remi McGill 0c504906cb Shaders - Fixed a Reference Pathing Issue on QT 2020-12-27 12:47:47 -05:00
HyperspaceMadness 0c526b6498 Shaders Load Refactor and Fix Referenced Texture Loading
Partial update to work with shaders directly

More Edits

More changes

more shader fixes

More Fixes Compiling, reference load still wrong

Added Feedback & things are working

Logging Fixes

Log Fix

More Fixes

Added Feedback Logging

Fixes for file pathing in Linux

Fix GLCore and Crash in QT Saving

Code Cleanup

Removed Unused Function filepath.c

Code Cleanup
2020-12-26 21:09:27 -05:00
HyperspaceMadness e98a8ce591 Shaders Fix Crash change num shader passes in UI 2020-11-30 19:30:15 -05:00
HyperspaceMadness 06e32982db Shaders_SaveAs_Fix_And_Better_Reference_Handling 2020-11-29 19:16:38 -05:00
HyperspaceMadness f0c4343cb9 Removed extra printf left behind 2020-11-22 19:39:34 -05:00
HyperspaceMadness abb2d06ce9 Shader_Multi-Level_Referenced_Presets 2020-11-22 19:10:08 -05:00
HyperspaceMadness deb8e2b88c Shader_Preset_Remove_parameters_line 2020-11-14 21:23:18 -05:00
HyperspaceMadness fd240f9a32 Shader Save Load Cleanup and UI Rename 2020-11-04 10:05:46 -05:00
HyperspaceMadness 1185df5f39 Shader Save & Load Fixes params not being loaded 2020-11-03 23:12:59 -05:00
HyperspaceMadness f6e35420bc Simple Shader Save Cleanup 2020-11-02 21:07:20 -05:00
HyperspaceMadness 70bf90c5d8 Shader_Preset_Simple_Save_Cleaned_2020_11_01 2020-11-01 09:18:40 -05:00
twinaphex 5fdf0c818d Cleanups 2020-09-04 04:15:46 +02:00
twinaphex 91d78c1e9f video_shader_read_reference_path - simplify 2020-09-04 04:12:51 +02:00
twinaphex 09f72c1465 Turn function static 2020-09-04 04:07:29 +02:00
twinaphex 88c0024a52 Cleanup video_shader_read_reference_path 2020-09-04 03:49:41 +02:00
twinaphex 63b77fb542 Use config_get_entry where possible instead of config_get_array
to prevent string allocation on heap
2020-08-27 16:20:49 +02:00
twinaphex 4388303077 video_shader_write_conf_preset - use less mallocs 2020-08-26 19:19:26 +02:00
twinaphex 1118ba09ec video_shader_resolve_current_parameters - don't use malloc 2020-08-26 19:10:43 +02:00
twinaphex 3ff29abbc8 video_shader_parse_pass - don't use malloc 2020-08-26 19:07:36 +02:00
twinaphex 603b2bf166 Simplify video_shader_read_conf_preset 2020-08-26 18:54:14 +02:00
twinaphex 86424a0cd8 (video_shader_parse) Use string_split_noalloc 2020-08-26 04:22:18 +02:00
twinaphex 0c5611d10e Clean up more string variables on heap; move to stack 2020-08-18 13:17:28 +02:00
twinaphex b9e471d22a Revert "Video context driver cleanups - less functions to go through with"
This reverts commit cd1d760a38.
2020-07-26 23:12:05 +02:00
twinaphex cd1d760a38 Video context driver cleanups - less functions to go through with
public scope
2020-07-26 08:00:49 +02:00
twinaphex 73e63d369c Fix more array subscript has type char warnings 2020-07-23 05:20:23 +02:00
twinaphex 021625fd4a Revert "Move static functions to top of files"
This reverts commit 02b542e2a5.
2020-06-26 18:40:26 +02:00
twinaphex 02b542e2a5 Move static functions to top of files 2020-06-26 18:15:38 +02:00
twinaphex 6fce0435a1 Update more logs 2020-06-08 18:04:29 +02:00
twinaphex 9059b4962e Cleanups 2020-06-07 00:05:41 +02:00
twinaphex a5ca6c24de Add more TODO/FIXMEs for globals 2020-05-29 06:17:39 +02:00
jdgleaver 9eb8472805 Only write config files to disk when parameters change 2020-04-27 17:06:35 +01:00
twinaphex cec672a71d Buildfix 2020-02-17 12:27:08 +01:00
twinaphex a0f3010159 Cleanup 2020-02-17 03:59:12 +01:00
twinaphex 1105d1019d Reduce some configuration dependencies 2020-02-12 16:13:28 +01:00
twinaphex 35b8c4cb05 Cleanup 2020-02-01 02:02:50 +01:00
twinaphex 6d0286efbd Turn video_shader_parse_type into macro 2020-01-22 14:30:55 +01:00
twinaphex 7175c3ec22 FIx another 'may be used uninitialized' warning 2019-10-05 18:43:25 +02:00
twinaphex 221df13250 Cleanups/warning fixes - compilation fix for OSX PPC 2019-10-05 18:38:17 +02:00
twinaphex b94b9e2adb Go back to plain strlcpy/strlcat - probably best to look at
opportunities to reduce these calls vs. replacing them with
unsafe macros
2019-09-23 00:19:01 +02:00
twinaphex 3b057d9605 Start using STRLCAT_CONST_INCR and STRLCPY_CONST 2019-09-20 23:33:17 +02:00
twinaphex db624a7c99 Start cleaning up the rather messy manual assignment 2019-09-20 02:03:26 +02:00
twinaphex ab515daa0c Try to get rid of file_path_str 2019-09-18 18:12:57 +02:00
twinaphex c186747edc (video_shader_parse) avoid some more snprintfs 2019-09-18 09:11:32 +02:00
Twinaphex 714e3ddc2a (SBT font driver) Check first if font files exist before
we try to open them
2019-08-24 03:30:32 +02:00
LazyBumHorse a882901e39 save unmodified auto-shaders as a reference instead of a copy, see:
- implement #reference directive for auto-shaders
 - replace usual preset saving and loading functions with video_shader_read_preset() and video_shader_write_preset()
 - apply saved presets automatically for console menus
 - move auto-shader saving logic from menus into menu_shader.c menu_shader_manager_save_auto_preset()
 - refactor menu_shader_manager_save_preset() into menu_shader_manager_save_preset_internal()
2019-08-22 16:57:28 +02:00
twinaphex d52c573e13 Merge slang_preprocess.cpp into slang_process.cpp 2019-08-18 18:55:22 +02:00
LazyBumHorse 719555bae1 Overhaul shader loading logic, add --set-shader CLI option 2019-08-17 15:20:51 +02:00
twinaphex b282125107 Revert "Refactor code for glslang shader presets - buffer entire file"
This reverts commit 0fee6a9ef4.
2019-08-08 16:36:34 +02:00
twinaphex 83c113cb59 Cleanups 2019-08-08 14:57:28 +02:00
twinaphex 0fee6a9ef4 Refactor code for glslang shader presets - buffer entire file
into memory before passing it on
2019-08-08 04:55:22 +02:00
jdgleaver bcfc5db7d8 (video_shader_parse) Optimise parsing of (non-slang) shader parameters 2019-08-07 17:19:18 +01:00
LazyBumHorse 6285c05948 add resolve_symlinks parameter to path_resolve_realpath() and cleanup playlist_resolve_path() 2019-07-22 13:44:35 +02:00
LazyBumHorse f8b92770d4 simplify video_shader_read_conf_preset() calls 2019-07-21 18:15:28 +02:00
LazyBumHorse 2245af23e9 much improved handling of relative shader paths
- save texture paths in relative format as well
 - always write portable relative paths on Windows using '/' instead of '\'
 - remove an ancient piece of code that could sometimes fail loading relative paths
 - fix absolute path handling between different drives for Windows
 - integrate video_shader_resolve_relative() into video_shader_parse_* functions
2019-07-20 18:29:46 +02:00
twinaphex b7a85d392f Silence warnings 2019-07-12 16:31:16 +02:00
twinaphex f0f5c32b51 Remove state tracker - legacy code - we can revisit this later
and integrate it in a way so that it scales across all drivers
2019-07-09 07:39:38 +02:00
LazyBumHorse 7b6444d911 temporary workaround for d3d10-12, gx2 not being able to poll flags during init 2019-06-19 19:10:40 +02:00
twinaphex 5d91af629e Set SHADERS_SLANG flag for D3D10/11/12 and query the video driver poke
interface's 'get flags' function before querying the video context
driver's 'get flags' function (D3D10/11/12/WiiU don't have a context
driver at all)
2019-06-19 03:18:28 +02:00
LazyBumHorse c20c67bd3a proper shader compatibility checks
- move shader flags from the video drivers to the context drivers
 - rework config_load_shader_preset() from configuration.c into retroarch_load_shader_preset() in retroarch.c with proper compatibility check
 - implicitly call retroarch_load_shader_preset() in retroarch_get_shader_preset() once per core/content life cycle
 - use video_shader_is_supported() instead of video_driver_test_all_flags() where appropriate
 - remove GFX_CTX_FLAGS_NONE because it is meaningless
2019-06-18 13:46:41 +02:00
LazyBumHorse 692dc9f6a9 refactor shader checks affected by last commit and more:
- gl.c: refactor backend fallback into more general gl2_get_fallback_shader_type
 - d3d9-12, gl_core, gx2_gfx, gl, vulkan: more consistent shader init and `set_shader` behavior
 - configuration.c: remove check_shader_compatibility
 - shader_glsl.c, shader_gl_cg.c: use `video_shader_get_type_from_ext`
 - shader_gl_cg.c: add shader type check with fallback to stock like in shader_glsl.c
 - menu_shader.c: use `enum rarch_shader_type` instead of `unsigned`
 - video_shader_parse.c: add `video_shader_to_str` for easier logging
 - remove `type` from `struct video_shader`, which was always set to CG and wrongly used in lang_process.cpp's `slang_process()` (has no further consequences because the code is unused)
2019-06-18 13:44:19 +02:00
LazyBumHorse 42e35c825f refactor some video_shader_parse functions
- video_shader_parse_type()'s fallback only worked for NULL paths and was wrongly used, now returns RARCH_SHADER_NONE like video_shader_get_type_from_ext().
 - video_shader_get_type_from_ext() should not be checking video driver flags, this is instead done by video_shader_is_supported()
 - video_driver_get_all_flags() did not actually 'get' flags, changed to video_driver_test_all_flags()

workaround for crash due to glcore not always using at least OpenGL 3.2
2019-06-18 13:12:56 +02:00
twinaphex ee3208ac39 Integrate video_driver.c into retroarch.c 2019-06-17 15:10:22 +02:00
LazyBumHorse 6514b80ff2 Revert "allow saving and properly loading 0 pass shader presets"
This reverts commit b54a360ab8.
2019-06-16 23:05:41 +02:00
twinaphex f60306b232 Rename read_conf_cgp/write_conf_cgp to
read_conf_preset/write_conf_preset
2019-06-15 09:00:35 +02:00