Commit Graph

9060 Commits

Author SHA1 Message Date
Twinaphex 1d3874a142
Merge pull request #7779 from jdgleaver/rgui-colours
(RGUI) Enable customisation of background and border colours
2018-12-20 20:51:12 +01:00
Twinaphex 3bd1c3fa6a
Merge pull request #7782 from orbea/format
Fix gcc -Wformat-truncation= warning.
2018-12-20 20:49:37 +01:00
orbea e6eedd05f5 Fix gcc -Wformat-truncation= warning.
menu/menu_displaylist.c: In function ‘menu_displaylist_ctl’:
menu/menu_displaylist.c:3441:28: warning: ‘ [’ directive output may be truncated writing 2 bytes into a region of size between 1 and 255 [-Wformat-truncation=]
                         "%s [%s %u]", descriptor, msg_hash_to_str(MENU_ENUM_LABEL_VALUE_USER), p + 1);
                            ^~
menu/menu_displaylist.c:3441:25: note: using the range [0, 4294967295] for directive argument
                         "%s [%s %u]", descriptor, msg_hash_to_str(MENU_ENUM_LABEL_VALUE_USER), p + 1);
                         ^~~~~~~~~~~~
menu/menu_displaylist.c:3440:16: note: ‘snprintf’ output 6 or more bytes (assuming 260) into a destination of size 255
                snprintf(desc_label, sizeof(desc_label),
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                         "%s [%s %u]", descriptor, msg_hash_to_str(MENU_ENUM_LABEL_VALUE_USER), p + 1);
                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2018-12-20 11:45:48 -08:00
orbea 5175c67381 menu: Fix directory settings.
The "Recording Output" and "Screenshot" directory settings accidentally
overwrote each other.

Fixes https://github.com/libretro/RetroArch/issues/7776
2018-12-20 11:13:28 -08:00
jdgleaver f603d4ec30 (RGUI) Enable customisation of background and border colours 2018-12-20 16:13:16 +00:00
Brad Parker 458bb9fbb5 add option to toggle menu by holding down start button 2018-12-19 14:53:17 -05:00
Twinaphex 26568a6bc2
Merge pull request #7770 from jdgleaver/rgui-user-index
(RGUI) Add user index label to control menu entries
2018-12-19 17:47:53 +01:00
jdgleaver f68d756af3 (RGUI) Add user index label to control menu entries 2018-12-19 12:19:29 +00:00
Stuart Carnie 11a7d34358
fix: animations deleted during update mutate tween list, causing crash
defer deletes resulting from callbacks until after update loop
2018-12-18 17:12:19 -07:00
Twinaphex 22fcd0be67
Merge pull request #7762 from orbea/rgui
Fix gcc -Wformat-truncation= warnings.
2018-12-18 10:12:50 +01:00
Brad Parker 4b323a45df paths can be const 2018-12-17 09:38:12 -05:00
Brad Parker 971591fb9c use filestream/VFS for core sideload 2018-12-17 09:25:52 -05:00
orbea 13e29308d5 Fix gcc -Wformat-truncation= warnings.
menu/drivers/rgui.c: In function ‘rgui_render’:
menu/drivers/rgui.c:670:53: warning: ‘%-*s’ directive output may be truncated writing up to 2147483648 bytes into a region of size between 0 and 252 [-Wformat-truncation=]
       snprintf(message, sizeof(message), "%c %-*.*s %-*s",
                                                     ^~~~
menu/drivers/rgui.c:676:13:
             type_str_buf);
             ~~~~~~~~~~~~
menu/drivers/rgui.c:670:42: note: assuming directive output of 254 bytes
       snprintf(message, sizeof(message), "%c %-*.*s %-*s",
                                          ^~~~~~~~~~~~~~~~
menu/drivers/rgui.c:670:7: note: ‘snprintf’ output between 4 and 4294967300 bytes into a destination of size 255
       snprintf(message, sizeof(message), "%c %-*.*s %-*s",
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             entry_selected ? '>' : ' ',
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~
             (int)(RGUI_TERM_WIDTH(fb_width) - (entry_spacing + 1 + 2) - entry_title_buf_utf8len + entry_title_buf_len),
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             (int)(RGUI_TERM_WIDTH(fb_width) - (entry_spacing + 1 + 2) - entry_title_buf_utf8len + entry_title_buf_len),
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             entry_title_buf,
             ~~~~~~~~~~~~~~~~
             entry_spacing,
             ~~~~~~~~~~~~~~
             type_str_buf);
             ~~~~~~~~~~~~~
menu/drivers/rgui.c:670:53: warning: ‘%-*s’ directive output may be truncated writing up to 2147483648 bytes into a region of size between 0 and 252 [-Wformat-truncation=]
       snprintf(message, sizeof(message), "%c %-*.*s %-*s",
                                                     ^~~~
menu/drivers/rgui.c:676:13:
             type_str_buf);
             ~~~~~~~~~~~~
menu/drivers/rgui.c:670:42: note: assuming directive output of 254 bytes
       snprintf(message, sizeof(message), "%c %-*.*s %-*s",
                                          ^~~~~~~~~~~~~~~~
menu/drivers/rgui.c:670:7: note: ‘snprintf’ output between 4 and 4294967300 bytes into a destination of size 255
       snprintf(message, sizeof(message), "%c %-*.*s %-*s",
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             entry_selected ? '>' : ' ',
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~
             (int)(RGUI_TERM_WIDTH(fb_width) - (entry_spacing + 1 + 2) - entry_title_buf_utf8len + entry_title_buf_len),
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             (int)(RGUI_TERM_WIDTH(fb_width) - (entry_spacing + 1 + 2) - entry_title_buf_utf8len + entry_title_buf_len),
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             entry_title_buf,
             ~~~~~~~~~~~~~~~~
             entry_spacing,
             ~~~~~~~~~~~~~~
             type_str_buf);
             ~~~~~~~~~~~~~
2018-12-16 20:22:53 -08:00
Twinaphex af0bf7a992
Merge pull request #7761 from orbea/c89
Fix gcc warnings with C89_BUILD.
2018-12-17 05:18:13 +01:00
Twinaphex 6dcdb843e8
Merge pull request #7758 from fr500/sideload
Sideload
2018-12-17 05:15:41 +01:00
orbea 169002ef7f Fix a gcc -Wformat= warning with C89_BUILD.
The posix spec claims "%r" is equivelent to "%I : %M : %S %p".

Source: http://pubs.opengroup.org/onlinepubs/9699919799/functions/strftime.html

menu/menu_driver.c:395:15: warning: ISO C90 does not support the ‘%r’ gnu_strftime format [-Wformat=]
             "%r", localtime(&time_));
               ^
2018-12-16 19:59:47 -08:00
twinaphex 862a4e099b Duplicate entry removed 2018-12-17 00:07:35 +01:00
radius 6c936274b7 make file copy operation a function
add sublabels

improve localization
2018-12-16 16:55:12 -05:00
Twinaphex 708c9c0774
Merge pull request #7754 from orbea/c89
Fix C89 build with clang.
2018-12-16 19:47:17 +01:00
Twinaphex fc6b3b7335
Merge pull request #7755 from fr500/fixes
subsystem: remember last used folder
2018-12-16 19:46:01 +01:00
radius 16d1cf28f7 only show with advanced options and on dynamic platforms 2018-12-16 12:42:10 -05:00
radius bfd23150b5 add core sideloading option 2018-12-16 12:42:09 -05:00
radius 319124c7a0 subsystem: remember last used folder 2018-12-16 12:33:27 -05:00
orbea 6e95a62fdf Fix c89 build with clang. 2018-12-16 07:02:14 -08:00
orbea f4a5c3bd55 Fix c89 build. 2018-12-15 21:03:28 -08:00
Stuart Carnie c00b6e0750
fix: Fix use of freed memory in menu animations
`menu_animation_update` enumerates `menu_animation.list` to process each
`tween`. It was observed that some tweens execute a callback that
pushes more animations via `menu_animation_push`. During the push, if
the tween `list` does not have enough space, a `realloc` occurs,
potentially invalidating the existing list. The remaining pointer access
in menu_animation_update is therefore invalid. Best case is the memory
is unused and thus does not affect the program. Worst case is memory
corruption.
2018-12-15 14:55:10 -07:00
Twinaphex 90abb7846a
Merge pull request #7740 from orbea/hide
menu: Add 'Show Start Recording' and 'Show Start Streaming'.
2018-12-15 18:09:10 +01:00
orbea 2ea6d5a060 Fix c89 build. 2018-12-14 15:41:52 -08:00
orbea 2646e49eb4 menu: Add 'Show Start Recording' and 'Show Start Streaming'.
Fixes https://github.com/libretro/RetroArch/issues/7739

These options are located at:

  Settings -> User Interface -> Views -> Quick Menu -> Show Start Recording

and

  Settings -> User Interface -> Views -> Quick Menu -> Show Start Streaming

The quick menu options 'Stop Recording' and 'Stop Streaming' are
intentionally not hidden to prevent users from silently recording or
streaming without realizing.
2018-12-13 18:40:32 -08:00
radius ced0f09f0e start at the current loaded content dir for subsystem and disk image append 2018-12-10 23:51:41 -05:00
radius 7a36190a0e cleanup filebrowser too 2018-12-10 23:20:27 -05:00
radius 45228d0307 massive subsystem cleanup & use the proper data in each instance 2018-12-10 23:01:21 -05:00
radius cad5ae287f fix https://github.com/libretro/fbalpha/issues/24#issuecomment-445803876 2018-12-10 22:09:42 -05:00
jdgleaver 11391d601c Hide 'scan content' entries from Collections menu when 'Show Import content Tab' is disabled (RGUI, GLUI) 2018-12-10 17:01:13 +00:00
orbea 23bbcdf8ce menu: Add "Show Reset Core Association".
This can be found at:

Settings -> User Interface -> Views -> Quick Menu -> Show Reset Core Association

This could be helpful for child friendly devices where someone may
accidentally reset the core and then not now which core they were using
before or how to set it again.

Also fixes an issue where "Show Add To Favorites" hides
"Reset Core Association" when that is not desired or expected.

Fixes https://github.com/libretro/RetroArch/issues/7714
2018-12-09 17:46:40 -08:00
alfrix cd2d2f8807 Add icons for apply on toggle and autoapply 2018-11-30 18:10:28 -03:00
Twinaphex 4578b82027
Merge pull request #7681 from alfrix/master
Menu drivers asset handling updates
2018-11-30 09:35:06 +01:00
alfrix 982b39a8bf Simplify and cleanup path handling, log the specific assets missing 2018-11-29 14:49:39 -03:00
alfrix ab34b21f8d XMB asset handling refactors also do not show black boxes 2018-11-29 14:49:39 -03:00
M4xw 8764d7be28 [LIBNX] Implement Over-/Downclocking and minor fixes 2018-11-29 18:42:44 +01:00
twinaphex a24a788e52 Fix subsystem for ozone 2018-11-29 12:12:00 +01:00
twinaphex 2777ee2fa4 Fix memory leak 2018-11-28 09:49:28 +01:00
dukemiller 8294bf86df Create option for dx video drivers to toggle displaying memory use 2018-11-28 00:01:09 -07:00
dukemiller be9d4c63ec Re-arrange menu options to put related settings closer together 2018-11-27 21:32:15 -07:00
dukemiller f3c682186c Add submenu label for framecount and change wording 2018-11-27 21:32:15 -07:00
Rob Loach e15dd10237
ozone: Fix subsystem_data being undefined
subsystem_data was not defined, seemed like a declaration of subsystem was in the wrong place.
2018-11-27 13:19:50 -05:00
Twinaphex 02e7b16461
Merge pull request #7643 from fr500/subsystem
WIP: try to load subsystems without loading content
2018-11-27 18:56:41 +01:00
natinusala ffaafbc77c ozone: fix scroll when rebinding inputs 2018-11-27 15:32:43 +01:00
twinaphex 803af8a890 Add brackets around this 2018-11-27 11:55:39 +01:00
natinusala 04797d9406 ozone: fix flickering sidebar cursor 2018-11-26 14:02:32 +01:00