2cddea21f8
* Cleanups
...
* Less pointer grabbing (dispwidget_get_ptr)
2022-10-09 22:53:39 +02:00
479e3b23d9
Turn content_get_status into content_get_flags
2022-10-09 20:32:39 +02:00
d5a6c4f150
(content) use flags for content_state
...
(xaudio2) Use flags
2022-10-09 10:20:43 +02:00
fcbd72dbf3
Use flags pt4 ( #14497 )
...
* * Use flags for rarch_state
* Get rid of ^M linebreaks in retroarch_types.h
* Buildfixes for consoles
* (audio driver) use flags instead of bools
* (video) Use flags instead of bools
* Rewrite input driver state bools into flags
2022-10-08 10:39:15 +02:00
f40d157571
Use flags pt3 ( #14491 )
...
* (Vulkan) Use flags for vulkan_emulated_mailbox
* Use flags for vk_texture
* dispgfx_widget - use flags instead of bools
* (Autoconfig) Use flags
2022-10-07 11:08:17 +02:00
91119d038f
(gfx_display/gfx_animation) Use flags instead of bools ( #14488 )
...
* (gfx_display/gfx_animation) Use flags instead of bools
* (task_save) Use flags instead of bools
2022-10-07 00:10:32 +02:00
4f071e47c7
screenshot_task_state - use flags instead of bools
2022-10-06 20:57:07 +02:00
951b98fe1b
Bools to flags ( #14486 )
...
* (D3D11) Use flags instead of bools
* (RPNG) Use flags
* Simplify rpng_is_valid
* (rpng_is_valid) Prevent potential NULL pointer dereference
(D3D11) Some whitespacing changes/code nits
* (task_pl_thumbnail_download.c) Simplify some code
2022-10-06 19:26:38 +02:00
30eb0edcf8
Use flags for some structs instead of tons of bools - less state/variables to bookkeep,
...
less memory used
2022-10-06 06:53:13 +02:00
4fe477ee39
Avoid 'video_gpu_screenshot' with savestates ( #14464 )
2022-10-03 15:13:01 +02:00
4806105a2c
Logging cleanups ( #14393 )
2022-09-06 18:48:58 +02:00
82cac0f9ba
Fix Redump bin/cue scan for some DC games + add RVZ/WIA scan support for GC/Wii ( #14380 )
2022-09-06 01:52:01 +02:00
c4c55077a1
Allow On-Demand Thumbnails in Explore menu ( #14385 )
2022-09-05 00:01:38 +02:00
654203be0a
(Autosave) Change/improve exit behavior of autosave thread -
...
if condition variable is signaled, the loop is ran another
last time so we can do a final check/save before stopping the thread.
Old commit courtesy of tobiasjakobi
2022-09-03 00:21:58 +02:00
2463a63c78
(task_save.c) Miscellaneous cleanups:
...
* Remove unused return type of one function
* Remove some TODO/FIXME notes
* Small style nits
2022-09-02 23:35:48 +02:00
003cea5d42
Fix some 'implicit conversion loses precision' warnings
2022-09-01 15:15:48 +02:00
60030e373e
Reduce snprintfs + assorted cleanups ( #14369 )
...
* Reduce snprintf and/or use them only for concatenating the
string formatting of numbers/values
* Reduce snprintfs
* Use snprintf for concatenation at parts
* * We don't need to NULL-terminate strings that get passed to strlcpy/strlcat
and friends
* Use snprintf for concatenation in certain instances
* Do away with some string intermediary copies where we can avoid it
* Fix warning unused variable
* * Reduce snprintf calls
* Rewrite snprintf calls into strlcpy where possible
* Use snprintf for concatenation when necessary
* Do away with some string intermediary copies in task_translation.c
* run_translation_service - make switch slightly smaller
2022-09-01 04:17:07 +02:00
08154e2656
(task_autodetect.c) Use snprintfs for concatenating strings (and only
...
use them for formatting numbers/values)
2022-08-29 14:05:16 +02:00
19c72a413f
(gfx_thumbnail_path.c) Cache localized string
...
(menu_displaylist.c) Some optimizations:
* Make sure val_d is never bigger than 16, it should just
contain a number. 16 is more than plenty (and probably too big even)
* Hose val_d out of loops if its value never changes inside the loop
* Attempt to avoid calling msg_hash_to_str inside loops unnecessarily
2022-08-27 13:20:29 +02:00
87de6bda46
(input_autoconfigure_disconnect_handler) Simplify some code
2022-08-27 09:22:20 +02:00
61e24132bf
(task_save.c) Simplification in control flow
...
(snprintf) Try to reduce or simplify snprintf calls, only tend to
use it for processing integers/numbers and avoid it for regular
string concatenation (NOTE: we try to be a bit safer about it to
address earlier cited criticism, although we don't consider concatenating
3 or 4 characters at the end to be insecure)
(msg_hash_to_str) Try to avoid duplicate calls to the same localized
string when we can just cache the results once instead locally
2022-08-27 07:55:02 +02:00
7507e20703
Revert "(RJSON) Combine multiple consecutive rjsonwriter_raw calls into one"
...
This reverts commit 82efa5a3d6
2022-08-26 14:44:29 +02:00
82efa5a3d6
(RJSON) Combine multiple consecutive rjsonwriter_raw calls into one
...
- significantly reduces the amount of function calls
2022-08-26 13:55:52 +02:00
575e331fd1
If we already know the length of the string, use strldup instead.
...
Avoids the internal strlen call inside strdup, and strdup is a deprecated
function starting from MSVC2005 anyways.
NOTE: Do NOT pass STRLEN_CONST as n parameter to strldup, it needs to
be at least +1 character higher than the strlen return value of the same
string
2022-08-25 16:31:54 +02:00
5bb3fbab93
Fix mistake in prior commit - should be concatenated to string
2022-08-25 15:17:31 +02:00
6caa139700
(cheevos.c) Fix some function prototypes for C
...
Rewrite some snprintfs as strlcpy/strlcat/manual assignment - only
use snprintf if we actually need the formatting
2022-08-25 15:08:02 +02:00
f5ac33c0b6
Simplify task_database_cue.c code -
...
* Was copying pre_game_id into several memory buffers for no real reason,
gets rid of some unnecessary strncpy calls this way too
2022-08-25 07:15:27 +02:00
88187e7ef2
* Start getting rid of strncpy
...
* steam.c - cleanups:
* Use string_to_lower from libretro-common/stdstring.c instead of
its own version
* Some stylistic changes
* Rewrite strncpy calls into strlcpy/strlcat/manual assignment
* Make it C89 compliant
* Some unused variables
2022-08-25 06:51:39 +02:00
8017410098
task_database_cue_get_token - correct to 'if (rv < 0)' instead
2022-08-25 05:52:42 +02:00
c841e191f7
(task_database_cue.c) Put this conditional back
2022-08-25 05:36:48 +02:00
da13fb0f48
Don't include errno.h in files that don't justify its use
2022-08-25 05:19:30 +02:00
39241699a0
Drop errno dependency in database_cue_get_token - was some legacy
...
code that is probably not needed
2022-08-25 04:51:00 +02:00
808fc7f389
Refactor task_database_cue.c ( #14349 )
2022-08-25 04:42:23 +02:00
56a6c50728
(task_database_cue.c) Get rid of some strcmps
2022-08-24 16:32:55 +02:00
c79904f8b3
(task_database_cue.c) More simplifications
2022-08-24 16:21:45 +02:00
f2d8b67f23
(task_database_cue.c) Simplifications:
...
- unsafe strcpy/strcat/sprintf were used, so pass 'len' parameters
to detect_{system} functions so that we can use the safer strlcpy/strlcat
calls instead
- thanks to strlcat/strlcpy return values, we can do less string concatenations
and get the same results
- some other miscellanous cleanups
2022-08-24 16:08:06 +02:00
fdc563e6f7
Remove errno dep (task_database_cue.c) ( #14341 )
...
* (task_database_cue.c) Turn some functions static - some general cleanups
* Start removing errno dependency on task_database_cue.c
2022-08-24 15:15:21 +02:00
6126a86259
Try to avoid sprintf/strcat/strcpy calls as much as possible in
...
RetroArch codebase
2022-08-24 13:49:05 +02:00
fc861c167c
- Get rid of some strerror usage
...
- Get rid of errno.h include in task_audio_mixer.c
- Rename get_token so it has less chance to conflict with other symbols
2022-08-23 19:58:20 +02:00
c04201927b
Don't make libretrodb dependent on errno anymore ( #14340 )
...
* Don't make libretrodb dependent on errno anymore
2022-08-23 19:36:52 +02:00
85c44f9245
more thread-awareness in task callbacks ( #14337 )
...
* more thread-awareness in task callbacks
2022-08-23 15:11:11 +02:00
10a351228b
* Rewrite some snprintfs
...
* task_steam.c - add license header
2022-08-20 19:17:28 +02:00
4c4bec11f7
NULL termination already happens in strlcpy
2022-08-10 02:45:27 +02:00
a6e210e9db
Get rid of some strlcats
2022-08-08 22:41:32 +02:00
0594df8cce
Remove some unused variables
2022-08-04 22:41:17 +02:00
b2634ea588
* Create fill_pathname_join_special - and specify fill_pathname_join
...
as deprecated.
* Use fill_pathname_join_special in the vast majority of cases where
we can ensure out_path is a new empty string
* Get rid of some extension concatenation with strlcat where encountered
* Some general cleanups with NULL termination of strings that get immediately
passed to strlcpy/strlcpy-adjacent functions
2022-08-04 14:19:38 +02:00
3aa1811ca9
(Network) Add getnameinfo_retro ( #14278 )
2022-08-04 13:22:49 +02:00
e7f3432e48
Replace some trivial strlcat usage - use return value of preceding
...
strlcpy then simply append the extension to it at this location
2022-08-04 03:45:09 +02:00
e4bff7c12c
Move rjsonwriter helper inline functions over to separate file rjson_helpers.h
2022-08-01 17:41:34 +02:00
f79875536a
(libretro-common) Move file_crc32 out of encoding_crc32.c - we don't want file I/O
...
code in encodings/encoding_crc32.c
2022-08-01 14:04:01 +02:00
20c4407928
Add HAVE_IFINFO macro ( #14265 )
2022-08-01 07:51:02 +02:00
f711940339
(task_database_cue.c) Use STRLEN_CONST macro for last param to
...
string_is_equal_fast instead of hardcoded magic numbers - sizeof
is compile-time so should be at no detriment to performance
2022-07-30 18:31:05 +02:00
44f5cb2935
Improved success rate of Serial scanning on PS1 by adding support for the xx.xxx format ( #14256 )
...
Co-authored-by: papa <papa>
2022-07-30 18:22:04 +02:00
19e4b8c0ca
Fix DEBUG codepath
2022-07-30 12:50:59 +02:00
592f9384b0
Silence code analysis warnings by Xcode - unused variables - nothing
...
done with value set - etc
2022-07-29 08:29:43 +02:00
4afe0c55d5
(autoconfig) Go back to prior behavior
2022-07-28 18:21:06 +02:00
29f0ba2e71
(Network/Vita) Add net_ifinfo support ( #14225 )
2022-07-26 16:10:23 +01:00
8d4a64ab96
(Netplay) Disallow netplay start when content is not loaded for static core platforms ( #14220 )
2022-07-26 07:21:57 +02:00
8ac1a36259
Don't do NULL termination on strings when passing to strlcpy and/or
...
a file_path function that calls strlcpy under the hood
2022-07-26 07:01:10 +02:00
45d78f2a60
[PS1 Serial Scanning] ( #14219 )
...
Changed return value of detect_ps1_game function to actuially return a
failure when the Serial couldn't be extracted.
Scanner will then fallback on crc check, and usually ends up finding the
games in the database.
Co-authored-by: papa <papa>
2022-07-25 22:41:32 +02:00
69a2d124c0
Don't do NULL termination on string if we pass it off to strlcpy
...
and/or a file_path function that uses strlcpy under the hood
2022-07-24 05:39:51 +02:00
cc7c310aa1
(Netplay) Refactor fork arguments ( #14208 )
2022-07-24 04:26:50 +02:00
eb36c35ebf
(Netplay) Fix content reload deadlocks on static core platforms #2 ( #14202 )
2022-07-23 03:08:26 +02:00
09d9366bc0
(Netplay) Fix content reload deadlocks on static core platforms ( #14196 )
2022-07-22 02:36:24 +02:00
3cf7e881ec
Get rid of unnecessary log spam about non-required/non-essential files/directories
2022-07-21 03:48:11 +02:00
2cf6f6ce8f
* Don't do NULL termination on string if we pass it to strlcpy
...
* Cleanups in connmanctl.c - abuse of strlcat, strlcpy should
precede it first and/or other more optimal ways of setting the path
2022-07-21 01:47:34 +02:00
4b5c7856e6
Remove some more explicit NULL-termination when we're calling a
...
string function that calls strlcpy under the hood
2022-07-19 20:43:12 +02:00
29774f5b7a
Small opts ( #14186 )
...
* (joypad_connection) Small optimizations -
* Turn functions static where possible
* Hose strlen call out of loop
* (input_driver.c) General cleanups:
* Some small code/style nits
task_screenshot.c:
* Move widget callback function for screenshots to task_screenshot.c
(file_path.c):
* Turn get_pathname_num_slashes into static function
* path_linked_list_free - always returns true, so get rid of return value
* path_linked_list_new - fix function signature
* path_get_archive_delim - do not NULL-terminate string, already done by strlcpy later on
General:
* Slight optimizations - use int/size_t for loop counter variable instead of unsigned
* Take advantage of fact that strlcpy already NULL-terminates, so don't do this explicitly
outside if we're just going to end up calling strlcpy/fill_pathname_join on it anyway
2022-07-19 10:01:33 +02:00
c4fb055fdb
Cleanups:
...
* Combine early return and assignment lines
* use path_basename_nocompression when possible
* Move variables to proper scope
2022-07-12 20:44:00 +02:00
f7194e167f
use path_basename_nocompression where it is safe to do so
2022-07-12 19:14:12 +02:00
b7926605f4
Remove fill_short_pathname_representation
2022-07-11 21:40:09 +02:00
adf9994828
Deprecate fill_pathname_base_noext
2022-07-11 20:13:44 +02:00
d706c9c5bf
Start deprecating trivial functions in file_path.c
2022-07-11 19:56:46 +02:00
05fb6fd9a3
task_push_load_content_playlist_from_menu - cleanup error_string
2022-07-09 18:43:44 +02:00
3b2b4ea49d
(task_content.c) Cleanups - remove error_string where not used
2022-07-09 18:41:18 +02:00
cda235d124
(task_autodetect.c) Cleanups - don't check for variables that
...
we already know are non-NULL, cleanup variable scope, etc.
2022-07-09 18:08:25 +02:00
ad87f88b72
(task_pl_thumbnail_download.c) Minor cleanups/style nits - reducing
...
return paths
2022-07-09 17:13:26 +02:00
f78f64f6be
(task_core_updater) small cleanups -
...
* Get rid of early returns where not necessary
* Reduce return paths to one where possible
2022-07-09 16:52:43 +02:00
177691e6fa
(Core Info) Ensure current core info is initialized at runloop_event_init_core when netplay is enabled ( #14162 )
2022-07-09 16:25:27 +02:00
a9b074fa0a
Rewrite content_file_list_init - check return value first before assigning it
2022-07-09 13:32:38 +02:00
274ce86d89
content_file_list_init - size < 1 will never happen, checked outside
...
before calling the function
2022-07-09 13:24:01 +02:00
4d3587a2e8
Cleanups in task_content.c -
...
split up some code between HAVE_MENU and whatnot
2022-07-09 02:07:34 +02:00
460ca09c87
(task_http) Cleanups
2022-07-09 01:24:59 +02:00
fa9e56d824
input_autoconfigure_connect - have boolean return value
...
- task_autodetect.c - cleanups, try to do less with generic
error labels and gotos, etc.
2022-07-09 00:53:08 +02:00
ef022ffe90
(Netplay) Force a core update when starting netplay ( #14157 )
2022-07-08 18:20:01 +02:00
fbd37f8926
Consistency in variable naming conventions - rename temp_path to tmp_path
...
for uniformity with rest of code
2022-07-05 19:06:38 +02:00
69605b7c9c
(task_screenshot.c) Simplify code
2022-07-05 18:15:12 +02:00
cd36af1d24
Use NAME_MAX_LENGTH for some char array variables that have a fixed
...
width of 256
2022-07-03 13:59:23 +02:00
ee8993c76a
Silence Linux snprintf warnings ( #14131 )
2022-07-02 14:08:27 +02:00
e7b9ff1ff6
(Netplay) Minor tweaks to the find content task ( #14125 )
2022-07-02 00:24:16 +02:00
ab208fca91
(Netplay) Ensure current content is reloaded before joining a host ( #14117 )
2022-07-01 01:02:04 +02:00
f2b3948b39
(UPnP) Attempt support for remaining platforms ( #14107 )
2022-06-26 21:38:52 +02:00
6aa16442db
(Network/Wii) Enable net_ifinfo for some features ( #14106 )
2022-06-26 16:37:05 +02:00
c1e8925f87
(Netplay) Find content task refactor ( #14089 )
2022-06-23 14:48:57 +02:00
dabd9cb996
(Netplay/LAN Discovery) Task refactor ( #14070 )
2022-06-19 03:41:04 +02:00
60161982b2
(task_database) Simplify code - put logging behind DEBUG ifdef
2022-06-18 19:19:18 +02:00
8bad1559f9
(task_database_cue.c) strlen returns value of size_t type, change variables
...
(task_database_cue.c) Comment out log and put it behind DEBUG ifdef
2022-06-18 19:12:03 +02:00
9c34a83aa7
task_push_load_contentless_from_menu - prevent warning when
...
compiling without HAVE_DYNAMIC defined
2022-06-10 14:40:06 +02:00
e4f8b531d5
(Netplay) Some refactoring and cleaning
2022-05-27 17:21:34 -03:00
61610bd7d3
(Netplay/UPnP) Stability Issue
2022-05-25 12:30:17 -03:00
LibretroAdmin