Commit Graph

1486 Commits

Author SHA1 Message Date
retro-wertz 55450a5d73
Fix false [ERROR] when closing content
filestream_delete() returns 0 on success, and -1 on failure.
This PR removes this false error when closing content.

e.g.
[ERROR] Failed to remove temporary file: /EMULATORS/ConsoleRoms/Nintendo - Nintendo Entertainment System/Super Mario Bros. (World).nes.
2018-04-03 12:08:53 +08:00
twinaphex 3fe6ecbce7 More static analyzer warning fixes 2018-03-29 14:19:24 +02:00
twinaphex 02bf41a686 (task_content.c) Minor cleanup 2018-03-25 00:14:35 +01:00
twinaphex 3c6490d828 Update 2018-03-25 00:09:57 +01:00
radius fd9d8c9512 fix potential crash on task_push_http_transfer 2018-03-18 12:52:04 -05:00
radius c52fdc469f remove task_push_http_transfer_raw, encode before sending data to the task 2018-03-16 22:38:21 -05:00
meleu eb5a69ded3 fixing cheevos (broken after #6389) 2018-03-16 01:03:57 -03:00
radius b01e63e2cd make sure to always encode urls, also change the PS3 default urls 2018-03-14 23:04:50 -05:00
Twinaphex ae6e410de1 Remove unused variables 2018-03-01 22:28:26 +01:00
twinaphex 0de23512e7 Should fix APK extraction (hopefully) 2018-03-01 14:59:37 +01:00
twinaphex 74309e6e1c shader code - Get rid of more hashes 2018-02-25 17:20:22 +01:00
twinaphex f00d194ae3 Get rid of more hashes 2018-02-25 16:32:54 +01:00
twinaphex fae9223641 Remove hashes from task_overlay 2018-02-25 13:03:54 +01:00
radius fd767f65bd subsystem fix 2018-02-17 12:28:19 -05:00
twinaphex ff831a7d99 Silence Coverity warning 2018-02-15 13:07:46 +01:00
radius a16cbe7cde de-hardcode rom count 2018-02-12 22:10:44 -05:00
radius 755578fc43 C89 build fixes 2018-02-12 21:19:51 -05:00
radius 1f2054d42f subsystem part 3: cleanups 2018-02-12 02:44:54 -05:00
radius d254c3eca4 subsystem part 3: fix saves 2018-02-12 02:39:26 -05:00
radius 9a23ee8017 subsystem part 3: remove more globals 2018-02-12 02:39:25 -05:00
radius 2a9046c06f subsystem part 3: cleanups 2018-02-12 02:39:25 -05:00
radius 9730fa5c51 subsystem part 2: load content! hacky 2018-02-12 02:39:25 -05:00
radius 752e729ec2 subsystem part 2: set paths 2018-02-12 02:39:24 -05:00
radius b212640732 subsystem part 2: add a wrapper to set the current subsystem 2018-02-12 02:39:24 -05:00
radius 597e0ce1ec subsystem part 1: get the required data to load content 2018-02-12 02:39:23 -05:00
twinaphex 457d543cb1 Get rid of callback function hashes 2018-02-05 19:14:55 +01:00
twinaphex 969067b359 Revert "Cleanup code"
This reverts commit 8d835d9b51.
2018-02-05 16:42:02 +01:00
twinaphex 8d835d9b51 Cleanup code 2018-02-05 16:41:02 +01:00
twinaphex d2aa12149f task_load_content - simplify code 2018-02-05 15:37:43 +01:00
twinaphex 69fedc6b40 task_screenshot.c - remove XBOX1 specific code 2018-02-05 00:29:05 +01:00
twinaphex 9dd33b9797 More CXX_BUILD linking error fixing 2018-02-04 20:57:30 +01:00
aliaspider 700fce3bd2 various fixes for CXX_BUILD. 2018-02-04 20:03:27 +01:00
twinaphex 0ee124582c Silence another Coverity warning 2018-02-02 21:53:58 +01:00
twinaphex 7cf4763bfb Add TODO/FIXME note 2018-01-31 23:05:42 +01:00
bparker06 3d2c579bc7
Change Bliss-Box feature report size per ulao 2018-01-28 20:26:47 -05:00
twinaphex 8e3b3762ad More compatibility fixes for CXX_BUILD 2018-01-25 16:33:28 +01:00
twinaphex ed38887910 (VS2017) Update solution 2018-01-23 08:38:40 +01:00
twinaphex 924007eda2 Prevent calling task_image_process if image is NULL 2018-01-23 04:57:12 +01:00
aliaspider 5db96f35fa (WIN32) various build fixes. 2018-01-20 20:05:32 +01:00
radius d1dba26565 fix display name for builtin autoconfs again 2018-01-16 22:18:28 -05:00
twinaphex 897c1654ab Reduce usage of string_is_not_equal_fast 2018-01-17 01:03:48 +01:00
twinaphex 61ff51be2f Start using string_is_equal predominantly 2018-01-16 22:53:38 +01:00
radius 2e210b6bb4 fix my last PR for builtin autoconfs 2018-01-12 10:29:35 -05:00
radius 3b334b60d6 add display name and config name to autoconf 2018-01-11 17:06:14 -05:00
twinaphex 0e337bb110 Use d3d_device_get_backbuffer 2018-01-03 16:25:45 +01:00
twinaphex e17baf411c Use d3d_surface_free 2018-01-03 14:10:14 +01:00
twinaphex 3528923507 Fix crash with Linux HTTP tasks - null pointer dereference 2018-01-02 13:41:59 +01:00
Brad Parker e62e0c83da win32: Show progress meter on taskbar for downloads (Windows 7 and up) 2018-01-01 02:08:09 -05:00
twinaphex d09e0f7da2 (task_autodetect.c) Too much verbose spam 2017-12-31 04:24:42 +01:00
gblues 704cc61fd8 Fix bug in autodetect macro, gamepad now works properly
== DETAILS
The gamepad didn't work because I had tried to rename the pad from
'WIIU Gamepad' to 'WiiU Gamepad'.

I added some debug logging and (to cut out a lot of trial-and-error)
discovered that the reason it didn't work was because a bug in a macro
was  using the define literally instead of substituting it (so e.g.
the autodetect handler was trying to match 'WiiU Gamepad' against the
literal string 'PAD_NAME_WIIU_GAMEPAD').

- Fixed the macro bug
- Left a minimal amount of the debug logging in place; may come in
  handy for someone else.
- Updated wpad/kpad/hidpad to use the define constants

== TESTING
Did a test build and confirmed the gamepad responded.
2017-12-30 04:43:33 +01:00
twinaphex 7b5547d368 Try to be safer with strlcpy calls 2017-12-28 05:56:45 +01:00
David Walters adffa5fc4c Fixes for overlay buttons 2017-12-17 12:36:18 +00:00
twinaphex c7c4b723d6 Move path_file_exists to filestream and do away with filestream
dependencies in file/file_path
2017-12-14 20:05:46 +01:00
Brad Parker 8c0adf3594 move path_file_rename and path_file_remove into VFS 2017-12-14 13:32:26 -05:00
gblues 0f7de204f7 Last batch of whitespace cleanup (post-rebase)
-- looks like a few files committed with DOS line endings
2017-12-12 00:24:46 -08:00
gblues 6904101c44 Clean up trailing whitespace
== DETAILS

Really simple code cleanup, because my editor flags trailing whitespaces
and it's pretty annoying.
2017-12-12 00:24:18 -08:00
twinaphex c4d8a8c800 Free after intfstream_close 2017-12-11 20:24:00 +01:00
twinaphex 32511090ca (task_save.c) Move to intfstream 2017-12-11 14:56:58 +01:00
twinaphex e62e9233d7 Add intfstream_get_size 2017-12-11 13:21:44 +01:00
twinaphex 61d3f90cae Add hint defines to libretro.h 2017-12-11 12:53:47 +01:00
twinaphex 38e6d2443f Change functions 2017-12-11 12:31:14 +01:00
twinaphex 8aa4d6d148 Move convenience functions to interface_stream.c 2017-12-11 12:23:40 +01:00
twinaphex 6897f9a987 Pass hints to intfstream_open_file 2017-12-11 12:20:06 +01:00
twinaphex 318f17c4cb Start using VFS API constant defines 2017-12-11 12:15:00 +01:00
twinaphex 2e979ec537 Replace function signatures of file_stream file functions 2017-12-10 22:25:38 +01:00
David Walters 004c1d2f0a Fix for relative paths being normalised and generating a duplicate history entry. 2017-12-08 23:37:07 +00:00
Brad Parker b0445e1e21 Bliss-Box: Work around Windows sharing violation bug by trying to open device as read/write if read-only fails. Show OSD message if it still fails. 2017-12-07 17:47:20 -05:00
David Walters 609bcb4dc2 fix device indexing 2017-12-05 22:03:56 +00:00
Brad Parker 4efc8453c2 buildfix for certain mingw environments 2017-12-02 15:59:42 -05:00
twinaphex 2608fd1550 (task_autodetect.c) Cleanups 2017-12-02 11:36:22 +01:00
Brad Parker 067f5bcd16 blissbox: add 4-Play to overridden hid name 2017-12-01 22:40:17 -05:00
Brad Parker 0eb8c47166 try to fix lack of GUID type on buildbot that I cannot reproduce 2017-12-01 14:38:13 -05:00
Brad Parker b9394846dc blissbox: use win32 HID API to get pad type on windows, libusb seems broken there 2017-12-01 14:07:40 -05:00
Brad Parker 5a2dff0ff1 only use libusb code if we have support for it 2017-11-28 22:32:41 -05:00
Brad Parker def24ef8eb blissbox: print message if detecting update mode or old firmware versions, override vid/pid check for autoconfig profiles, misc comments 2017-11-28 21:25:54 -05:00
Brad Parker 2dd64d9c11 Initial blissbox support, requires firmware 2.0. Currently limited to platforms with libusb support. 2017-11-28 18:25:12 -05:00
twinaphex d75c187c5b Don't show 'Scanning of Directory Finished' if we are scanning a
file instead
2017-11-27 07:04:52 +01:00
twinaphex e35394d4bd Fix MSVC 2003 build 2017-11-26 22:41:34 +01:00
radius 1003e681cc don't assume the core never has content 2017-11-26 11:33:02 -05:00
twinaphex 5e3eb437ac Change RARCH_ERR invocations 2017-11-26 00:57:02 +01:00
twinaphex b4ac3e7b2f Cleanups 2017-11-25 23:06:56 +01:00
twinaphex 8cc2e9bade Cleanups 2017-11-25 23:06:25 +01:00
twinaphex ca616f3e32 Cleanup 2017-11-25 22:33:43 +01:00
Brian Koropoff fb5e788c1e task_database: fix crash from Windows-incomptabile format string 2017-11-24 18:17:43 -08:00
Brian Koropoff 711877b056 content: preserve info for history/favorites
If the content came from a playlist, use the original label.
Preserve the core path and name in the favorites list.
2017-11-17 16:55:32 -08:00
Brian Koropoff bedf65e72e scanner: prioritize databases with recent matches
This should improve performance when scanning many files
in a row that all match against the same database, which is
the expectation.
2017-11-17 16:53:49 -08:00
Brian Koropoff b668193923 scanner: allow matching archives by member
This allows more flexible detection of content packaged as multiple
compressed files (e.g. MAME).
2017-11-17 16:53:49 -08:00
twinaphex e5d4e2ac0a Silence a lot of warnings 2017-11-06 19:13:54 +01:00
Twinaphex 7ba2797032
Merge pull request #5629 from lunixoid/master
Fixed twice assigned values
2017-10-31 06:23:55 +01:00
Roman Kalashnikov 400b27a227
Fixed twice assigned values 2017-10-31 00:26:41 +03:00
Brad Parker 68a8198e4a convert more file IO functions to use filestream, fixes encoding issues on Windows 2017-10-29 12:08:24 -04:00
Jean-André Santoni bd17c11350 Fix gamecube scanning 2017-10-27 15:17:18 +07:00
Jean-André Santoni 2ddba6770d Start implementing gamecube scanning 2017-10-27 15:17:18 +07:00
Jean-André Santoni 93ee38af05 Add gamecube magic number 2017-10-27 15:17:18 +07:00
orbea 33eb1f9e28 Fix regressions from commit 538d51553c. 2017-10-23 05:39:54 -07:00
orbea 538d51553c When starting content from the cli open the quick menu.
Fix https://github.com/libretro/RetroArch/issues/5554
2017-10-22 08:07:37 -07:00
Brad Parker a7c8cc88e5 win32: support local multibyte encoding for file paths 2017-10-14 23:13:24 -04:00
Brian Koropoff 20aa59249c task_save: fix double-free 2017-10-11 21:26:26 -07:00
twinaphex c68db61188 Silence more Clang warnings 2017-10-11 22:49:13 +02:00
Higor Eurípedes 41024fbb0a Fix conditional jump on uninitialized data
This fixes a bug introduced in 862cf48108
2017-10-03 19:54:32 -03:00
Alcaro dc4c2cd6d9 Wipe out a buncha warnings and pointless ifdefs (some warnings will remain until #5497 is fixed) 2017-10-03 00:26:29 +02:00
Alcaro b97853a536 Rename STRING_REP_ULONG to STRING_REP_USIZE 2017-10-02 22:51:51 +02:00
Brad Parker 7a6d2cb5e6 set list to NULL after free in case autoconfig directory is empty 2017-09-30 19:03:39 -04:00
twinaphex 45ce8bf773 Cleanups 2017-09-30 20:45:06 +02:00
twinaphex de6b1bcbf0 Fix another Coverity error 2017-09-30 17:11:51 +02:00
twinaphex 73d1539bb0 Fix another Coverity error 2017-09-30 17:08:42 +02:00
twinaphex 2a8b74eeb9 Fix some Coverity errors 2017-09-30 16:52:41 +02:00
twinaphex f61b9e1747 Cleanup 2017-09-30 08:24:01 +02:00
twinaphex 063343e538 Simplify this 2017-09-30 07:29:19 +02:00
Brad Parker c856a36a58 more null checks 2017-09-30 01:18:40 -04:00
twinaphex 00ea9be8fc Be safer 2017-09-30 06:38:53 +02:00
twinaphex ff926439ac Fix this up 2017-09-30 06:29:07 +02:00
twinaphex 5fd05c6b56 There were some unused variables 2017-09-30 06:25:41 +02:00
twinaphex eae2217c6d Cleanup 2017-09-30 06:23:23 +02:00
twinaphex 3040d1da36 (task_database.c) Simplify conditionals 2017-09-30 06:21:38 +02:00
twinaphex f323168251 Simplify conditionals 2017-09-30 06:08:09 +02:00
twinaphex dc2664a4ef Reorder variables 2017-09-29 22:58:32 +02:00
twinaphex 57ded65189 (task_save.c) Use malloc 2017-09-29 22:40:31 +02:00
twinaphex 862cf48108 (task_image.c) Don't use calloc 2017-09-29 22:36:48 +02:00
twinaphex 127d98fb68 Rewrite path from nbio struct 2017-09-29 22:16:17 +02:00
twinaphex bae31a318d Prevent memory leak 2017-09-29 21:32:05 +02:00
twinaphex 3490c3dbc5 Cleanups 2017-09-29 20:51:20 +02:00
twinaphex 3090f3ff3a (task_database.c) Rewrite char arrays 2017-09-29 20:47:54 +02:00
twinaphex 819e3fb02a Initialize struct 2017-09-29 17:06:38 +02:00
Twinaphex f713a30705 Update task_autodetect.c 2017-09-29 15:08:09 +02:00
twinaphex 5951bed07d Make stdin an option 2017-09-29 06:16:35 +02:00
twinaphex f34250e38e Buildfix 2017-09-27 23:55:54 +02:00
twinaphex e7d41f6ea7 Cleanup 2017-09-27 23:54:31 +02:00
twinaphex fcf6228dce Turn into char pointer array 2017-09-27 20:11:44 +02:00
twinaphex b79f95668b Turn it into char pointer array 2017-09-27 20:08:37 +02:00
twinaphex 6cf6d46e4b Try silencing more warnings - do something with return value 2017-09-26 03:51:50 +02:00
twinaphex cc8e897222 C89_BUILD fixes 2017-09-22 05:12:26 +02:00
twinaphex e74da12d26 Fix another memory leak 2017-09-22 00:03:40 +02:00
twinaphex 50d48139a3 Fix some more memory leaks 2017-09-21 23:38:29 +02:00
twinaphex 1a77c383b9 Fix plethora of memory leaks again 2017-09-21 21:33:13 +02:00
twinaphex 0f80e31382 task_database.c - cleanups 2017-09-21 19:57:10 +02:00
Twinaphex cff35f3611 Fix warning - wrong type used 2017-09-21 19:24:42 +02:00
Brian Koropoff 2cfedab339 task_database_cue: only return error when errno would be set
On a short read, errno will be 0, and returning 0 without
setting system_name will cause a crash later.  Just continue
to the next magic number instead.
2017-09-20 21:24:59 -07:00
twinaphex 0002912328 Change size of variables 2017-09-20 16:35:18 +02:00
twinaphex 808a723969 Fix memory leaks 2017-09-20 12:18:31 +02:00
twinaphex ac732ecdb0 Fix memory leak 2017-09-20 12:13:44 +02:00
twinaphex 37715114ae Cleanup 2017-09-20 09:55:53 +02:00
Aaron Oneal 4a929bd8e2 Optimize scanning using directory name hint
As discussed in issue #5440, directory scans are slow when compressed files must be checked against multiple databases. This commit adds support to hint to the scanner that a particular database should be used so that only a single scan is required. If the directory name being scanned matches the database name then that single database is selected.
2017-09-19 16:58:28 -07:00
Aaron Oneal 6ac4486f4d Fix typo from 9a76a93ea that broke the build 2017-09-19 16:49:45 -07:00
Twinaphex 9a76a93ea8 OSX buildfixes/cleanups 2017-09-19 21:37:51 +02:00
twinaphex e8f39f004e MSVC buildfixes 2017-09-19 21:29:28 +02:00
Twinaphex ee06a8f175 Merge pull request #5447 from bkoropoff/scanning2
More scanning rework
2017-09-19 15:46:04 +02:00
Aaron Oneal fb8fe84684 Fix archive scanning
Archive scans were broken for cores like Atari 5200 and Commodore 64 because archive contents were skipped if a core reported it supported compressed files. The problem is, it's a false assumption that just because a core supports compressed files that the content database contains CRCs for compressed files.

Instead of adding the contents of every compressed file to the scan list ahead of time, the patched logic now checks for the CRC of the archive itself as it always has but then adds the archive contents to the scan list if the archive itself is no match. This maintains the logic of adding only the archive if the core supports compressed files and the archive CRC matches but also allows for deeper content scans when there is no match.

The patch also removes `core_info_unsupported_content_path` as it was redundant with existing `core_info_database_supports_content_path` logic.
2017-09-18 23:15:28 -07:00
Brian Koropoff d4beeeda33 task_database: skip serials for the right file type! 2017-09-18 09:03:43 -07:00
Brian Koropoff 84edc8ffb0 task_database: prune files referenced from cue/gdi files
Since we use cue/gdi files to find the right track file to
scan, don't bother scanning them separately.
2017-09-18 09:03:43 -07:00