86b64c34aa
Make xmb->thumbnail_file_path a char pointer
2018-01-23 05:38:02 +01:00
0c9b4a60a2
Start reducing amount of times xmb->thumbnail_file_path is
...
written to
2018-01-23 05:30:41 +01:00
a6ff88a094
Catch another edge case - this function is a mess and a minefield -
...
we need additional helpers to file_path.c and we need to properly
clean this up
2018-01-23 04:49:36 +01:00
4a7bfa463f
Create tmp_new2 - avoid scenario where fill_pathname_join
...
tries to join itself - create path first with tmp_new2,
then copy this back to xmb->thumbnail_file_path
2018-01-23 04:40:40 +01:00
7902fdafd8
Merge pull request #6155 from fr500/master
...
attempt to fix #6154
2018-01-23 04:31:06 +01:00
b957e5aff4
Cleanup
2018-01-23 04:30:47 +01:00
f36dfda328
Fix Coverity resource leak warning
2018-01-23 04:29:45 +01:00
fb4bf99a31
attempt to fix #6154
2018-01-22 21:48:17 -05:00
6a47669d21
Prevent some heap corruptions/exceptions
2018-01-23 03:41:25 +01:00
27f34bf420
Some stability fixes
2018-01-23 03:23:49 +01:00
897c1654ab
Reduce usage of string_is_not_equal_fast
2018-01-17 01:03:48 +01:00
daf0b55f80
fix heap buffer overflow
...
==16726== ERROR: AddressSanitizer: heap-buffer-overflow on address 0x600400139d99 at pc 0x5cb4d8 bp 0x7ffc88a3a050 sp 0x7ffc88a3a048
READ of size 1 at 0x600400139d99 thread T0
#0 0x5cb4d7 in xmb_update_savestate_thumbnail_path /home/bp/RetroArch/menu/drivers/xmb.c:1071
2018-01-16 10:32:45 -05:00
298e8b6326
Remove C++ comments
2018-01-02 07:13:09 +01:00
88311acad3
Merge pull request #6027 from meepingsnesroms/master
...
Add all xmb menu options to rgui and glui, 3ds warning fix, move start directory to top of load content
2018-01-02 06:19:48 +01:00
7ac985e9be
Add all xmb menu options to rgui and glui, 3ds warning fix, move start directory to top of load content
2018-01-01 10:38:16 -08:00
6c02686f84
Revert "xmb: Add a few icons to the menu"
2017-12-31 00:20:40 -05:00
0a65875956
xmb: Add a few icons to the menu
2017-12-29 02:18:40 -05:00
a1467346f5
theme: Add Monochrome Inverted icon theme
2017-12-28 09:10:58 -05:00
321285811f
Merge pull request #5973 from RobLoach/light
...
XMB: Add Light theme
2017-12-28 05:40:59 +01:00
60702e3871
xmb: Remove gradient on Light theme
2017-12-27 19:41:46 -05:00
d71a2db781
XMB: Add Light theme
2017-12-27 17:33:39 -05:00
b4d2ed3421
Merge branch 'xmb-font-color' of github.com:RobLoach/RetroArch into xmb-font-color
2017-12-27 17:03:52 -05:00
85f9eb402e
font-color: Remove XMB from the Font Color naming scheme
2017-12-27 17:03:39 -05:00
9efc0d2a78
font-color: Remove reference to config.def.h
2017-12-27 16:51:05 -05:00
f96b285715
font-color: Use the settings for the color
2017-12-27 16:38:36 -05:00
29c9afa609
font-color: Update the font color to reflect in the menu
2017-12-27 16:21:56 -05:00
c7c4b723d6
Move path_file_exists to filestream and do away with filestream
...
dependencies in file/file_path
2017-12-14 20:05:46 +01:00
cd2ae18ec1
Replace double quotes in thumbnail names
2017-12-12 13:08:24 -05:00
6904101c44
Clean up trailing whitespace
...
== DETAILS
Really simple code cleanup, because my editor flags trailing whitespaces
and it's pretty annoying.
2017-12-12 00:24:18 -08:00
542235ffd7
(XMB) Get rid of hashes
2017-12-06 21:55:21 +01:00
bada13a215
let it snow
2017-12-02 22:47:44 -05:00
09c39a91d7
Cleanups
2017-11-27 04:49:21 +01:00
7e7c17596d
Add Add To Favorites Playlist icon id
2017-11-25 12:51:12 -05:00
cfe59bcf2a
Cheevos badges
2017-11-23 08:04:54 -05:00
8b9ad28ecb
channges to populate and apply badges.
2017-11-23 07:56:47 -05:00
84e80e47df
Initial test for badge icon
2017-11-23 07:53:24 -05:00
1bd65c8f3e
Add Retrosystem theme
2017-11-17 19:42:55 -03:00
5879e551a5
Pass video_info to font driver functions
2017-11-13 10:42:40 +01:00
0d7f9c7cf0
(xmb) De-hardcode the size of 'tabs' array
...
As per @bparker06's recommendation.
First element of the enum is forced to be zero, so we can add a tail to the enum that we can use to query its max length.
2017-11-06 20:20:14 +00:00
5136ec2df0
Updates
2017-11-06 05:37:32 +01:00
82de482b9f
(xmb) Fixed array index out of bounds
...
Caught by asan:
menu/drivers/xmb.c:3491:16: runtime error: index 8 out of bounds for type 'uint8_t [8]'
menu/drivers/xmb.c:1149:23: runtime error: index 8 out of bounds for type 'uint8_t [8]'
2017-11-06 01:06:13 +00:00
bb051f185b
MSVC/C89 buildfixes
2017-10-22 05:13:22 +02:00
338723bc31
fix some null pointer accesses with empty strings
2017-10-15 00:39:55 -04:00
01f8e4e74f
Merge pull request #5539 from Brunnis/master
...
XMB: Fix playlist entry graphic update issue when all system tabs except Main Menu are disabled
2017-10-12 14:08:38 +02:00
a87cf6d2e7
Fix issue in XMB where playlist entry graphic wouldn't update when scrolling through the first playlist tab, if all system tabs except the Main Menu tab were disabled.
2017-10-12 09:49:59 +02:00
39619d1245
Implemented new Kiosk Mode setting which hides all configuration related settings/tabs in XMB.
2017-10-11 11:30:53 +02:00
83991d6c36
Implemented setting for showing/hiding the "Reboot" option in XMB. The setting is only shown on Lakka.
2017-10-06 09:40:41 +02:00
9db0e9dbc6
Implemented setting for showing/hiding the "Quit RetroArch" option in XMB. The setting is only shown on Lakka.
2017-10-06 09:27:42 +02:00
f073d5167a
Implemented setting for showing/hiding the "Help" option in XMB.
2017-10-06 08:28:45 +02:00
7ee1797fa1
Implemented setting for showing/hiding the "Configurations" option in XMB.
2017-10-06 08:18:39 +02:00
19b313c221
Implemented setting for showing/hiding the "Information" option in XMB.
2017-10-05 14:30:15 +02:00
0eb5566dea
Implemented setting for showing/hiding the "Load Content" option in XMB.
2017-10-05 09:26:25 +02:00
cc3b64f951
Implemented setting for showing/hiding the "Load Core" option in XMB.
2017-10-05 09:14:05 +02:00
032109512a
Fix more Coverity errors
2017-10-04 08:37:21 +02:00
fca48021aa
(xmb) Fix whitespace
2017-10-03 21:16:11 -03:00
6ed9f28656
(xmb) Set selection_ptr_old to zero when animations are off
2017-10-03 21:15:35 -03:00
9c89b3e546
Merge pull request #5496 from Brunnis/master
...
Add setting for showing/hiding the ability to rename playlist items
2017-10-02 22:37:50 +02:00
af7df0cba3
Add setting for showing/hiding the ability to rename playlist items.
2017-10-02 22:17:44 +02:00
721afe22d8
(MSVC 2010) Compile griffin.c as C
2017-10-02 22:06:32 +02:00
1d960e0c42
Try to silence Coverity error
2017-10-01 18:23:40 +02:00
e66ef15580
Remove another useless wrapper function
2017-10-01 17:17:53 +02:00
a87bef6ed0
Remove useless wrapper function
2017-10-01 17:11:09 +02:00
a11d04f252
xmb: check that node exists before dereferencing it
2017-10-01 02:08:41 -04:00
455b202142
Fix another Coverity error
2017-09-30 17:09:52 +02:00
b46f2ba35f
Fix Coverity error
2017-09-30 17:05:26 +02:00
4dd6c7fac7
Fix crash
2017-09-30 16:55:50 +02:00
2a8b74eeb9
Fix some Coverity errors
2017-09-30 16:52:41 +02:00
b0de197da4
Memset this variable
2017-09-30 07:43:37 +02:00
e376bd75c0
Fix crash with savestate thumbnails
2017-09-30 07:10:58 +02:00
638a441530
(XMB) Be safer
2017-09-30 06:40:54 +02:00
94fdf314f2
Cleanup conditionals
2017-09-30 06:11:18 +02:00
d6b385d0b8
Try to be more safe
2017-09-30 05:08:11 +02:00
66de49c987
Fix memory leaks and crashes
2017-09-29 21:19:07 +02:00
f398f44253
Rewrite xmb_draw_item
2017-09-29 21:00:56 +02:00
238de4aa57
Prevent memory leak
2017-09-29 20:56:54 +02:00
7f80ecbe93
(XMB) xmb_free - prevent memory leaks
2017-09-29 19:57:23 +02:00
8e01424450
Refactor and rewrite big char arrays
2017-09-29 19:55:06 +02:00
efde859e17
Rewrite menu_entry_get_rich_label
2017-09-29 18:46:53 +02:00
9c90f97792
No longer use menu_entry_alloc
2017-09-29 18:37:04 +02:00
05d5def6c2
Simplify xmb_draw_item
2017-09-29 18:12:17 +02:00
51d98ef0c0
(XMB) Reduce stack usage
2017-09-29 16:54:57 +02:00
8bf741257c
(XMB) Reduce stack usage
2017-09-29 16:47:30 +02:00
dc11a02e61
Cleanup
2017-09-29 16:34:20 +02:00
b2932d5270
Split up function into two - create xmb_draw_item
2017-09-29 16:32:30 +02:00
5379b12e7c
FIx some new Coverity errors
2017-09-29 05:39:06 +02:00
270f35753a
reorder XMB variables
2017-09-28 08:42:12 +02:00
dfe6035ade
Put menu_entry_t on heap inside xmb_draw_items
2017-09-28 07:26:43 +02:00
f914a91944
Use menu_entry_get_type_new
2017-09-28 07:15:29 +02:00
c5255b1bff
Simplify menu_entry_get_rich_label
2017-09-28 06:19:34 +02:00
2f10fd14d6
Create menu_entry_init/menu_entry_free
2017-09-28 06:02:14 +02:00
bb6e4a6633
xmb_draw_items - small cleanups
2017-09-28 05:37:19 +02:00
a616fa16f3
Small cleanups
2017-09-28 05:00:22 +02:00
7633141bd6
Try to prevent potential memory leak
2017-09-28 03:53:48 +02:00
8b5f8d8c64
menu_displaylist_info - rewrite path
2017-09-28 03:06:54 +02:00
08ecfc74ec
Rewrite info.label
2017-09-28 02:45:03 +02:00
72f42b602f
menu_displaylist_info - reduce stack usage - exts no longer
...
a fixed size path
2017-09-28 01:38:05 +02:00
a1e9027fe2
Added XMB menu option to show the Settings tab if it has previously been hidden.
2017-09-26 14:41:07 +02:00
a532ef3cea
(XMB) Prevent memory leak
2017-09-12 04:47:37 +02:00
a25f9d291e
(XMB) Reduce stack usage
2017-09-12 04:37:58 +02:00
632225ee73
Reduce stack usage
2017-09-11 04:40:35 +02:00
ea5538d955
(XMB) Reduce stack size cleanups
2017-09-11 02:37:53 +02:00
f722e26167
Cleanups
2017-09-10 23:22:09 +02:00
155d6a23b9
Start using menu_displaylist_info_free
2017-09-10 22:57:26 +02:00
6ec9d643f6
(XMB) Reduce size of sysname
2017-09-09 07:59:53 +02:00
6d65c5157a
remove unused variables
2017-09-09 07:22:25 +02:00
8e53ce6184
(XMB) Get rid of for loops for iterating over shadow coordinates
2017-09-09 06:52:49 +02:00
03009d618e
Get rid of loop inside xmb_frame
2017-09-09 06:48:31 +02:00
ca32013665
Reduce size of some variables
2017-09-08 23:09:16 +02:00
582b688121
Silence some warnings for PS3
2017-09-06 00:21:20 +02:00
8d525f711a
msvc2003 buildfixes
2017-09-03 23:39:25 -04:00
80dc96a8fb
CXX_BUILD buildfix
2017-09-04 03:49:23 +02:00
455349880e
(xmb) Fix crash when browsing to small lists
2017-09-03 18:06:38 -03:00
eac68b9d41
(xmb) Limit selection_buf_old to visible items
2017-09-03 16:30:45 -03:00
6c7a354822
(xmb) Remove xmb->menu_stack_old
2017-09-03 14:51:14 -03:00
67710daf4b
Fix initialization from incompatible pointer type
2017-09-03 15:45:18 +02:00
718eeb4a39
(xmb) Fix memleak
...
Due to file_list_free()'s behavior of free()ing userdata as if it was a
simple, contiguous structure xmb_node_t's fullpath member wasn't being
free()'d.
2017-09-03 10:25:15 -03:00
a7e6b02107
(xmb) Refactor xmb_copy_node()
...
xmb_node_t is nowhere as big as it used to be, so copying is fine now.
2017-09-03 10:19:03 -03:00
65ec1e973a
(xmb) Add xmb_free_list_nodes()
...
Fixes some node->fullpath memleaks.
2017-09-03 09:48:31 -03:00
1a1e5047e8
(xmb) Fix crash while scanning
2017-09-02 20:21:02 -03:00
4bfc8f8243
(xmb) Fix crash when toggling the menu
2017-08-31 14:52:54 -03:00
f521a32c00
(xmb) Don't animate more than needed when switching lists
2017-08-30 22:23:29 -03:00
bd96c75bfe
(xmb) Make xmb_node_t smaller
...
Each xmb_node_t instance used over 4KiB of memory even when it didn't
need to. In big list like MAME (30+ thousand entries) RetroArch would
consume over 100MiB (4096 bytes * 30000) just to hold all xmb_node_t
instances.
2017-08-29 22:19:19 -03:00
70b6f951d3
(xmb) Uncomment xmb_calculate_visible_range() call
...
I tested the other drivers quickly and the previous commit did not
affect them, so I'm enabling this again.
2017-08-22 22:00:14 -03:00
e5adb1056c
(XMB) Regression Fix thumbnail ahead OSK overlay
2017-08-20 06:38:23 +02:00
6bc5cd302a
(xmb) Comment out visible item calculation in xmb_draw_items()
...
Fixes a regression where fading animations didn't render if you were far
into the previous list. This happened because "current" has an incorrect
value thanks to a menu_navigation_set_selection(0) call in
menu_cbs_left.c:162
2017-08-19 11:01:27 -03:00
aaecf82608
(xmb) Skip drawing the fading list when it is already transparent
2017-08-18 22:33:38 -03:00
6940019102
(XMB) Icon for the rename action
2017-08-18 18:30:31 +07:00
0d59994c42
(xmb) Only iterate over visible items in xmb_render()
2017-08-17 21:36:48 -03:00
ea9991f749
(xmb) Detect non-visible items before drawing
2017-08-17 21:36:48 -03:00
db48561289
(xmb) Fix crash
2017-08-15 21:34:49 -03:00
0d86027cd5
(RGUI) Add Load Content -> Favorites
2017-08-16 01:10:27 +02:00
ef79711837
(MaterialUI) Hook up framebuffer opacity
2017-08-15 22:43:09 +02:00
db24e4da42
Try to avoid countless string_is_equal function calls
...
being called multiple times per frame render - prebake
these decisions instead inside list_insert
2017-08-15 04:33:36 +02:00
7c54cebfb3
Merge branch 'master' of github.com:libretro/RetroArch into favorites
2017-08-13 21:20:22 -04:00
e324b4a074
Reorder the View settings
2017-08-13 19:10:09 -04:00
8e0e99ba66
Add Show Favorites sublabel
2017-08-13 18:44:50 -04:00
c9ad8cd1f9
(XMB) Display the small add-favorite icon
2017-08-14 00:12:55 +02:00
950b77c0ca
(xmb) Speed up xmb_list_insert() and xmb_deep_copy() a bit
...
This replaces calloc() and memcpy() calls with custom functions to
handle xmb_node_t allocation and copy optimized for the common case.
2017-08-12 22:30:22 -03:00
9f760af6c6
Menu improvements ( #5288 )
...
* (menu_animation) Stop KILL_BY_SUBJECT asap
* (xmb) Don't query mouse/pointer state so many times per frame
2017-08-12 22:53:56 +02:00
f1ccd29e77
(XMB) Display the favorite icon for content
2017-08-12 17:27:31 +02:00
61cc899867
(XMB) Display the favorites tab, part 1
2017-08-12 16:37:20 +02:00
dad0fcbbe8
Get rid of the conditionals
2017-08-11 01:20:57 +02:00
22139dc4a0
Turn menu_animation_ctx_tag into typedef
2017-08-11 01:16:21 +02:00
4e66ec28cb
Some more truncation fixes
2017-08-10 23:19:54 +02:00
16f59aba96
Some C89_BUILD fixes
2017-08-10 21:38:57 +02:00
05558697ca
(Lakka) Fix Online Updater
2017-08-09 15:16:27 +02:00
8d358899df
(xmb) Fix segfault when entering certain lists
2017-08-08 22:34:54 -03:00
c0cb042998
(xmb) Improve responsiveness while browsing horizontally
2017-08-08 21:05:00 -03:00
56733c6f18
(xmb) deep list copy - Use malloc instead of calloc
2017-08-07 00:14:37 +02:00
7c1d3991f8
Some C89 buildfixes
2017-08-06 17:12:57 +02:00
twinaphex