a147cb09d9
Get rid of duplicate code - move function to menu_driver.c and have
...
both XMB and Ozone use it
2022-08-24 13:14:55 +02:00
5f7d14966c
(Ozone+XMB) Fullscreen thumbnail browsing ( #14342 )
2022-08-24 12:35:54 +02:00
e769436876
(word wrap functions in stdstring.c) Avoid implicit strlens, caller
...
should pass the 'length' to the function instead
2022-08-23 17:06:01 +02:00
6f738d4fbd
Gradually get rid of strcpy_literal
...
Reasons:
1 - Just a macro for strcpy
1.2 - doesn't have a return type unlike strlcpy, can't be used
for string concatenation
1.3 - unsafe compared to strlcpy
Do either manual string assignment per character or strlcpy, no
inbetween by resorting to strcpy
2022-08-23 15:04:47 +02:00
1a1db6177d
(Netplay) Fix lobby sublabel CRC display on some platforms ( #14338 )
2022-08-22 23:05:13 +02:00
c818024bc6
(RGUI) Savestate thumbnails ( #14326 )
2022-08-18 02:12:50 +02:00
46bafd6e46
(3DS) Add bottom menu options ( #14323 )
2022-08-17 08:23:07 +02:00
c180560165
(Netplay) Improve check frames menu entry ( #14320 )
2022-08-13 22:28:43 +02:00
908667d97a
(Netplay) Removal of older unused code ( #14312 )
2022-08-11 23:17:33 +02:00
a6e210e9db
Get rid of some strlcats
2022-08-08 22:41:32 +02:00
c030e1c5dc
(Netplay) Support for customizing chat colors ( #14305 )
2022-08-08 20:09:06 +02:00
a9157f975e
String cleanups ( #14304 )
...
(retroarch.c) retroarch_get_capabilities - get rid of strlcat
party in RARCH_CAPABILITIES_CPU, do simple manual assignment for
concatenation instead and NULL terminate at the end
(menu_displaylist.c) Do something about some of the unnecessarily huge
local strings of PATH_MAX_LENGTH size (can be as large as 8192)
(menu_displaylist.c) Replace some trivial strlcats / snprintfs
(D3D10/D3D11/D3D12) Strings don't need to be initialized -
strlcpy already null-terminates - get rid of some constants
2022-08-08 19:11:15 +02:00
0edbe945b4
(MaterialUI/XMB) Optimize refreshing of playlists
2022-08-06 20:32:19 +02:00
1b43e60c7c
(Ozone) Use less path_remove_extension and work more with return values
...
from file_path.c functions
(menu_cbs_title) Small optimization to string concatenation
2022-08-06 19:51:00 +02:00
c7786a45e1
Create path_get_extension_mutable and use it in menu_explore function
...
for trivial extension replacement in string
2022-08-06 19:06:31 +02:00
94ed25be56
Cleanups ( #14296 )
...
- (database_info.c) Optimizations for database_info_build_query_enum() -
it would call strlcat at the very least 3 times, normally more than that.
Every strlcat call is at least one or more strlens. Reduce it all down
to manual string concatenation and one strlcat
- (database_info_build_query_enum) - always NULL terminates string so no need for NULL termination done by callee
* (menu_displaylist) use smaller strings for basename paths, remove one unnecessary string
in menu_displaylist.c function
- (disk_index_file.c) Avoid another trivial string concatenation by doing
it manually after fill_pathname_join_special
- (fill_pathname_join_delim) since fill_pathname_join_delim() now has a return value, use it for
string concatenation
- (platform_unix) - Use BUFSIZ as size for a buffer in system_property_get
- some other trivial strlcat usage replacements
2022-08-06 18:04:40 +02:00
5739c537a2
Some CXX_BUILD fixes
2022-08-05 17:40:06 +02:00
9d939a35d6
Add Daite XMB Icon Theme ( #14263 )
2022-08-05 04:27:34 +02:00
67c23aec0e
(Wayland) Stub out unused variables for now
...
(menu_contentless_cores) Fix mistake - needed to set len to return
value of fill_pathname_join_special
(configuration.c) Fix some unused variable warnings on Linux
2022-08-04 16:19:50 +02:00
6ad88b080e
Turn these two fill_pathname_join_delim() calls into plain strlcat()
2022-08-04 15:15:27 +02:00
b2634ea588
* Create fill_pathname_join_special - and specify fill_pathname_join
...
as deprecated.
* Use fill_pathname_join_special in the vast majority of cases where
we can ensure out_path is a new empty string
* Get rid of some extension concatenation with strlcat where encountered
* Some general cleanups with NULL termination of strings that get immediately
passed to strlcpy/strlcpy-adjacent functions
2022-08-04 14:19:38 +02:00
88bc26da4e
Replace some more trivial strlcat calls
2022-08-04 04:05:27 +02:00
e7f3432e48
Replace some trivial strlcat usage - use return value of preceding
...
strlcpy then simply append the extension to it at this location
2022-08-04 03:45:09 +02:00
02df727cb2
Avoid strtof() since it's C99/POSIX. Go for strtod followed by float
...
cast since it should be almost identical
2022-08-03 14:07:32 +02:00
6dd52d9bb1
Get rid of more boilerplate code in file_path_special.c
2022-08-02 18:05:51 +02:00
556e6702ef
Start downscaling on file_path_special.c
2022-08-02 17:54:38 +02:00
70ca20fbf9
(MaterialUI) Fix earlier mistakes made ( cd04f770b9) -
...
we need two separate icon paths cached - one for MaterialUI and one for Ozone (the system
icons)x
2022-08-02 17:25:52 +02:00
8105688a99
(Netplay) Show client slowdown information ( #14272 )
2022-08-02 13:31:55 +02:00
20c4407928
Add HAVE_IFINFO macro ( #14265 )
2022-08-01 07:51:02 +02:00
f472e4d0de
(gfx_widgets) Call fill_pathname_application_special outside of hot functions
...
(gfx widgets) Pre-assemble and store paths that are not subject to change
2022-08-01 02:07:36 +02:00
cd04f770b9
(MaterialUI) Don't keep assembling MaterialUI icons path - store it once
...
in materialui_init
2022-08-01 01:17:39 +02:00
e9a6252fc7
(Ozone) Some simplifications - less string concatenation
2022-08-01 01:06:38 +02:00
83a2ec1da8
(Ozone/XMB) Move some fill_pathname_join operations out of the loops since
...
the output string is not subject to change during iterations
2022-08-01 00:49:33 +02:00
3d69321c70
(msg_hash_us.h) Small touch up ( #14246 )
...
* Update msg_hash_us.h
* Update menu_displaylist.c
* Update msg_hash_us.h
* Update menu_displaylist.c
2022-07-29 17:41:26 +02:00
349ef1add2
(XMB) Dynamic wallpaper fixes: ( #14247 )
...
- 'Load Content' playlists
- Period in the playlist name
2022-07-29 17:40:11 +02:00
0c4bf5f2e3
(Ozone) Fix playlist thumbnail mouse hover after returning from QM ( #14244 )
2022-07-29 15:01:44 +02:00
22bef5dc6b
(Ozone) Remove unused arrays
2022-07-29 13:07:16 +02:00
592f9384b0
Silence code analysis warnings by Xcode - unused variables - nothing
...
done with value set - etc
2022-07-29 08:29:43 +02:00
052cdce29b
(Ozone+XMB) Add playlist icons under 'Load Content' ( #14243 )
2022-07-29 07:12:01 +02:00
6c38efb0ee
Prevent playlist thumbnail cycle from showing duplicate images ( #14238 )
2022-07-28 23:55:47 +02:00
6c1de85add
(Ozone+XMB) Thumbnail fixes ( #14210 )
2022-07-28 19:21:59 +02:00
ba752b6364
Fix regression #14229 - NULL termination for strings still necessary
...
when passed to string_list_join_concat
2022-07-27 15:15:33 +02:00
29f0ba2e71
(Network/Vita) Add net_ifinfo support ( #14225 )
2022-07-26 16:10:23 +01:00
eb4440fafa
Fix previous mistake in menu_action_sublabel_contentless_core
2022-07-26 13:45:41 +02:00
88c2ae9ddf
No null termination for strings passed to strlcpy/srlcat
2022-07-26 13:23:28 +02:00
8d4a64ab96
(Netplay) Disallow netplay start when content is not loaded for static core platforms ( #14220 )
2022-07-26 07:21:57 +02:00
a6a4b845a4
Some string simplifications - don't NULL terminate if we pass
...
string to strlcpy and/or a file_path function using strlcpy under
the hood - don't do strlcpy for trivial setting of 2/3 char strings
2022-07-25 04:39:08 +02:00
54d0d84696
Fixed Purple Rain Theme ( #14214 )
...
* Add Purple Rain Theme
2022-07-25 00:44:31 +02:00
522d1ed16d
Add Purple Rain Theme ( #14212 )
...
* Add Purple Rain Theme
* Revert "Add Purple Rain Theme"
This reverts commit ceb896785b
2022-07-24 21:26:16 +02:00
5c98caa7fd
Don't NULL-terminate string if we pass it to strlcpy and/or a
...
file_path function that calls strlcpy under the hood
2022-07-24 06:22:35 +02:00
34a18f64e8
Don't do NULL termination on string when we pass the string to
...
strlcpy and/or a file_path function that does strlcpy under the hood
2022-07-23 10:46:05 +02:00
d2aeba0a92
Cleanup - remove NULL-termination since we pass fullname now to
...
strlcpy always at first
2022-07-22 02:25:49 +02:00
6cfcd749e4
(menu_driver.c)
...
* Fix issue 14190
* Simplify code by removing unneeded code
2022-07-22 02:13:18 +02:00
1f244aac01
(Ozone+XMB) Thumbnail improvements ( #14188 )
2022-07-21 15:25:12 +02:00
4b5c7856e6
Remove some more explicit NULL-termination when we're calling a
...
string function that calls strlcpy under the hood
2022-07-19 20:43:12 +02:00
29774f5b7a
Small opts ( #14186 )
...
* (joypad_connection) Small optimizations -
* Turn functions static where possible
* Hose strlen call out of loop
* (input_driver.c) General cleanups:
* Some small code/style nits
task_screenshot.c:
* Move widget callback function for screenshots to task_screenshot.c
(file_path.c):
* Turn get_pathname_num_slashes into static function
* path_linked_list_free - always returns true, so get rid of return value
* path_linked_list_new - fix function signature
* path_get_archive_delim - do not NULL-terminate string, already done by strlcpy later on
General:
* Slight optimizations - use int/size_t for loop counter variable instead of unsigned
* Take advantage of fact that strlcpy already NULL-terminates, so don't do this explicitly
outside if we're just going to end up calling strlcpy/fill_pathname_join on it anyway
2022-07-19 10:01:33 +02:00
87240556ea
Should fix Android strtol regression (when converting from sscanf) ( #14183 )
2022-07-18 04:38:52 +02:00
fbd765f167
Change menu_setting.c back
2022-07-18 03:11:38 +02:00
de6c077e4d
(menu_cbs_get_value.c) Small nits
2022-07-17 19:23:46 +02:00
66ea402de8
We already check if descriptor is empty beforehand
2022-07-17 19:15:37 +02:00
a39532f19d
(menu_cbs_get_value) Try to prevent assignments to string buffer if not needed
2022-07-17 18:59:21 +02:00
08cccc811c
Some slight optimizations of menu callback functions - better variable
...
scoping
2022-07-17 18:09:28 +02:00
c3483654c9
Revert back to sscanf for versions of MSVC prior to MSVC2013 - prior
...
to MSVC2013, MSVC did not yet support strtof
2022-07-17 17:37:22 +02:00
3ebfcbc7c7
setting_set_with_string_representation - avoid sscanf for trivial
...
operations when we can use strtol/strtoul/strtof
2022-07-17 09:46:27 +02:00
e4b33fd0e6
(formats/json/rjson.c) Get rid of some implicit strlens and pass
...
size parameter to the functions instead
2022-07-17 06:58:22 +02:00
b56b447f08
Fix these two memory errors that popped up with ASAN -
...
* Argument base for qsort cannot be NULL
* When system_count is 0 or less, early return out of explore_load_icons
2022-07-15 19:16:21 +02:00
4b1766cf61
Silence more -Wdocumentation warnings
2022-07-15 01:12:04 +02:00
f5d46681c2
(UWP) Enable core downloader/updater ( #14173 )
2022-07-14 15:21:49 +02:00
c4fb055fdb
Cleanups:
...
* Combine early return and assignment lines
* use path_basename_nocompression when possible
* Move variables to proper scope
2022-07-12 20:44:00 +02:00
f7194e167f
use path_basename_nocompression where it is safe to do so
2022-07-12 19:14:12 +02:00
69ddf03c91
Remove unused return variables
2022-07-12 18:00:33 +02:00
83655420f6
file_list_prepend just a thin wrapper around file_list_insert - get
...
rid of it and just pass 0 as the last argument instead
2022-07-12 16:56:44 +02:00
06e1b6a68f
Revert "Move strftime_am_pm to libretro-common rtime.c, remove duplicate"
...
This reverts commit 99186b1056
2022-07-12 03:31:42 +02:00
99186b1056
Move strftime_am_pm to libretro-common rtime.c, remove duplicate
...
functions
2022-07-12 03:29:16 +02:00
293722ac38
Get rid of fill_pathname_join_concat_ext
2022-07-11 22:01:20 +02:00
b7926605f4
Remove fill_short_pathname_representation
2022-07-11 21:40:09 +02:00
adf9994828
Deprecate fill_pathname_base_noext
2022-07-11 20:13:44 +02:00
d706c9c5bf
Start deprecating trivial functions in file_path.c
2022-07-11 19:56:46 +02:00
4bcc479041
Further refinement of function
2022-07-11 19:14:48 +02:00
6475d0ca54
Make code identical for last_played_strftime and strftime_am_pm -
...
see opportunity here to cutdown on duplication and make this a public
function
2022-07-11 19:12:14 +02:00
e91cf0e40d
No longer use fill_pathname_noext - just basic strlcpy/strlcat string
...
concatenation
2022-07-11 18:48:02 +02:00
c54499c5fb
(Ozone) Simplify code
2022-07-09 14:29:49 +02:00
281a498474
Backport 05a98b7efe
...
- fix off by one error for input_block_timeout setting
also default to 0 for this setting (pretty massive performance gain)
2022-07-07 18:03:45 +02:00
9af17b633e
(Netplay) Host Ban Submenu ( #14151 )
2022-07-07 16:08:46 +02:00
bf5409881c
gfx_display_rotate_z optimizations - if radians is 0, we know cosine
...
and sine already. Avoid the computation with sinf/cosf and pass it as value to the
function when possible
2022-07-06 11:03:15 +02:00
6607ff3aaa
rotate_draw - get rid of scale_x/y/enable - scaling is only done now
...
in XMB at two spots - refactor gfx_display_rotate_z so that it only
manipulates the input matrix' Z axis
2022-07-05 20:50:01 +02:00
95db09d8c5
Move bundle_assets_{src/dst} to settings->paths
2022-07-05 19:15:29 +02:00
336ca1a68c
Don't call gfx_display_rotate_z unless the display driver implementation's
...
'handles_transform' is set to false
2022-07-05 17:20:01 +02:00
1798651041
(gfx_widgets) scale_enable can b set to false for widgets, scale_factor was always 1.0f
...
(XMB) set scale_enable to false when scale_factor is 1.0f
2022-07-05 14:18:20 +02:00
681e1dea94
gfx_display_rotate_z - if scale_x/y/z are all 1.0f, then set
...
scale_enable to false
2022-07-05 14:02:38 +02:00
494c93df3e
Thumbnail aspect ratio fix ( #14145 )
2022-07-05 12:01:21 +02:00
7043873fba
Reformat rdb_entry_int ( #14140 )
2022-07-03 17:46:03 +02:00
91c8541e20
(Ozone+XMB) Savestate thumbnail aspect ratio ( #14139 )
2022-07-03 16:14:51 +02:00
b55fa28896
(Netplay/Menu) Localize relay servers ( #14136 )
2022-07-03 13:45:13 +02:00
42f75e7f72
(Netplay/Menu) Add client devices info to the kick sub-menu ( #14138 )
2022-07-03 13:44:46 +02:00
ee8993c76a
Silence Linux snprintf warnings ( #14131 )
2022-07-02 14:08:27 +02:00
78bc42de68
(Netplay/Lobby) Add setting for filtering out rooms with non-installed cores ( #14124 )
2022-07-02 00:24:33 +02:00
0232fc8e10
(Ozone+XMB) Savestate thumbnail fullscreen + dropdown ( #14116 )
...
* (Ozone+XMB) Savestate thumbnail fullscreen toggle
* (Ozone+XMB) Savestate thumbnail dropdown
2022-07-01 23:41:46 +02:00
ab208fca91
(Netplay) Ensure current content is reloaded before joining a host ( #14117 )
2022-07-01 01:02:04 +02:00
58fc77850c
(Netplay/Lobby) Hide older (incompatible) rooms ( #14118 )
2022-07-01 01:01:24 +02:00
LibretroAdmin