* Allow repositioning of achievement notifications
* PS4/ORBIS build fix
Would have thought cheevos-related notification code was wrapped in HAVE_CHEEVOS, but guess not.
Display translation completeness categories in the language selection options.
Generate the progress report for RetroArch menu file instead of all files.
- New descriptors: 'dpad_area' and 'abxy_area'
- Each has a diagonal sensitivity setting, 100% being 8-way symmetry
- Buttons can be redefined in the cfg file
E.g. This would create a d-pad area, then redefine it to use analog directions:
overlay0_desc0 = "dpad_area,0.85,0.57,rect,0.166228,0.295516"
overlay0_desc0_up = "r_y_minus"
overlay0_desc0_down = "r_y_plus"
overlay0_desc0_left = "r_x_minus"
overlay0_desc0_right = "r_x_plus"
* New Menu Items Disable Info & Search
Add menu options for disabling Info and Search buttons
* Update msg_hash_us.h
Update Sublabels
* Update menu_setting.c
Set Advanced flag for new settings
(menu_displaylist.c) Some optimizations:
* Make sure val_d is never bigger than 16, it should just
contain a number. 16 is more than plenty (and probably too big even)
* Hose val_d out of loops if its value never changes inside the loop
* Attempt to avoid calling msg_hash_to_str inside loops unnecessarily
Reasons:
1 - Just a macro for strcpy
1.2 - doesn't have a return type unlike strlcpy, can't be used
for string concatenation
1.3 - unsafe compared to strlcpy
Do either manual string assignment per character or strlcpy, no
inbetween by resorting to strcpy
Closes https://github.com/libretro/RetroArch/issues/3414
I have investigated the issue. The crux of the problem is that on Android there
is no way distinguishing 2 scenarios:
1) 2 identical bluetooth controllers A and B and first there are button presses
only on controller A and then on controller B
2) the same controller disconnects and reconnects.
Android doesn't give bluetooth mac address of where the touch came from, only
opaque ID and this opaque ID changes after reconnect. Hence without changes to
android this is infeasible without giving up the ability for 2 users to play on
identical controllers.
I guess that this sacrifice makes sense for affected users
Consistently with input_config_get_device_name use in
get_string_representation_split_joycon.
Fixes a bug where saved autoconfig would not match the current device, but
an unpredictable other device in the system.
* Add option for showing the overlay behind the menu
This commit lays the groundwork for this option. Support for this option
in the video drivers themselves is going to be added in later commits.
* gl1: Add overlay behind menu support
* gl2: Add overlay behind menu support
* gl3: Add overlay behind menu support
* vulkan: Add overlay behind menu support
* ctr: Add overlay behind menu support
* d3d9: Add overlay behind menu support
* d3d10: Add overlay behind menu support
* d3d11: Add overlay behind menu support
* d3d12: Add overlay behind menu support
* CHANGES.md: overlay behind menu
Co-authored-by: MrHuu <MrHuu@users.noreply.github.com>
Co-authored-by: Tony <45124675+sonninnos@users.noreply.github.com>
* Netplay Stuff
## PROTOCOL FALLBACK
In order to support older clients a protocol fallback system was introduced.
The host will no longer send its header automatically after a TCP connection is established, instead, it awaits for the client to send his before determining which protocol this connection is going to operate on.
Netplay has now two protocols, a low protocol and a high protocol; the low protocol is the minimum protocol it supports, while the high protocol is the highest protocol it can operate on.
To fully support older clients, a hack was necessary: sending the high protocol in the unused client's header salt field, while keeping the protocol field to the low protocol. Without this hack we would only be able to support older clients if a newer client was the host.
Any future system can make use of this system by checking connection->netplay_protocol, which is available for both the client and host.
## NETPLAY CHAT
Starting with protocol 6, netplay chat is available through the new NETPLAY_CMD_PLAYER_CHAT command.
Limitations of the command code, which causes a disconnection on unknown commands, makes this system not possible on protocol 5.
Protocol 5 connections can neither send nor receive chat, but other netplay operations are unaffected.
Clients send chat as a string to the server, and it's the server's sole responsability to relay chat messages.
As of now, sending chat uses RetroArch's input menu, while the display of on-screen chat uses a widget overlay and RetroArch's notifications as a fallback.
If a new overlay and/or input system is desired, no backwards compatibility changes need to be made.
Only clients in playing mode (as opposed to spectating mode) can send and receive chat.
## SETTINGS SHARING
Some settings are better used when both host and clients share the same configuration.
As of protocol 6, the following settings will be shared from host to clients (without altering a client's configuration file): input latency frames and allow pausing.
## NETPLAY TUNNEL/MITM
With the current MITM system being defunct (at least as of 1.9.X), a new system was in order to solve most if not all of the problems with the current system.
This new system uses a tunneling approach, which is similar to most VPN and tunneling services around.
Tunnel commands:
RATS[unique id] (RetroArch Tunnel Session) - 16 bytes -> When this command is sent with a zeroed unique id, the tunnel server interprets this as a netplay host wanting to create a new session, in this case, the same command is returned to the host, but now with its unique session id. When a client needs to connect to a host, this command is sent with the unique session id of the host, causing the tunnel server to send a RATL command to the host.
RATL[unique id] (RetroArch Tunnel Link) - 16 bytes -> The tunnel server sends this command to the host when a client wants to connect to the host. Once the host receives this command, it establishes a new connection to the tunnel server, sending this command together with the client's unique id through this new connection, causing the tunnel server to link this connection to the connection of the client.
RATP (RetroArch Tunnel Ping) - 4 bytes -> The tunnel server sends this command to verify that the host, whom the session belongs to, is still around. The host replies with the same command. A session is closed if the tunnel server can not verify that the host is alive.
Operations:
Host -> Instead of listening and accepting connections, it connects to the tunnel server, requests a new session and then monitor this connection for new linking requests. Once a request is received, it establishes a new connection to the tunnel server for linking with a client. The tunnel server's address and port are obtained by querying the lobby server. The host will publish its session id together with the rest of its info to the lobby server.
Client -> It connects to the tunnel server and then sends the session id of the host it wants to connect to. A host's session id is obtained from the json data sent by the lobby server.
Improvements (from current MITM system):
No longer a risk of TCP port exhaustion; we only use one port now at the tunnel server.
Very little cpu usage. About 95% net I/O bound now.
Future backwards compatible with any and all changes to netplay as it no longer runs any netplay logic at MITM servers.
No longer operates the host in client mode, which was a source of many of the current problems.
Cleaner and more maintainable system and code.
Notable functions:
netplay_mitm_query -> Grabs the tunnel's address and port from the lobby server.
init_tcp_socket -> Handles the creation and operation mode of the TCP socket based on whether it's host, host+MITM or client.
handle_mitm_connection -> Creates and completes linking connections and replies to ping commands (only 1 of each per call to not affect performance).
## MISC
Ping Limiter: If a client's estimated latency to the server is higher than this value, connection will be dropped just before finishing the netplay handshake.
Ping Counter: A ping counter (similar to the FPS one) can be shown in the bottom right corner of the screen, if you are connected to a host.
LAN Discovery: Refactored and moved to its own "Refresh Netplay LAN List" button.
## FIXES
Many minor fixes to the current netplay implementation are also included.
* Remove NETPLAY_TEST_BUILD
This can fix a lot of performance issues, like audio crackling and frame
time spikes. This requires the GameMode package to be installed. See:
https://github.com/FeralInteractive/gamemode
This commit adds a "Game Mode" bool option to the "Power
Management" and "Latency" settings sections, and it can be toggled
on/off without restarting RA.
The actual toggling of game mode happens in a new frontend platform
interface function. Perhaps this will become useful for other platforms
that provide some equivalent of Linux GameMode.
Since the GameMode ABI is fixed, and the API comes as a single,
header-only file with no actual deps, we simply bundle the header
(deps/feralgamemode/gamemode_client.h.) That way, all Linux builds will
have support for GameMode regardless of whether the GameMode development
package is installed or not.
* Added setting to allow/disallow players other than the host from pausing the game.
* Added a sublabel for netplay max connections.
* Fixed port override macro from not being set immediately after the port setting.
* Fixed memory leaks.
* Move ui_companion_driver code out of retroarch.c
* Buildfix
* Fix error - was reading the array out of (preinitialized) bounds
* Remove unused variable
Adds new entry (where the entry for dumping CD is) to eject the disc -
in case the CD drive has no physical button to eject the disc / the
button does not work. Useless for most, but quality of life improvement
for some.
Upstream of patch used by Lakka at build time
1943ad296e/packages/libretro/retroarch/patches/retroarch-99-eject_disc.patch
* Any pad can control the menu
== DETAILS
I am not sure I've quite got it so that any pad can *open* the
menu, but I do have it so any pad can control it.
- split out the input processing into a separate method
- track down and squish some hairy bugs that boiled down to
bad pointer math
- it looks like `menu_driver.c` has a mix of line endings, so I
ran it through `dos2unix` so it has consistent line endings
again.
- verified that this change did not impact actual cores
* optimize out cumulative_bits
* Incorporate PR feedback
Many thanks to @jdgleaver for providing these optimizations.
* apply one more optimization
* feat: adding solarized dark theme to ozone
* fix: variable not defined in header
* fix: added string for selecting theme in menu
* fix: added message hash for string
* feat: copied solarized dark translations into msg hashes
* fix: forgot to change name of enum label after copying
* first pass of new colors
* added selection border and fixed sublabel color
* sublabel color from blue to muted gray
* trying cyan for sublabel
* adjusted selected text color to match philosophy from solarized website
* testing what the entries_ colors do
* chose colors for entries_, adjusted other border and bgs
* match selection border to sublabel color
* trying gray for sublabel
* accidentally put the color in the wrong place, reverting and updating
* trying to change selected option color to orange
* not feeling orange, lets try teal
* try for orange border
* try for magenta border
* try for violet border
* trying blue border again
* trying omar blue bc why not
* reverting to regular blue for icons and green for border
* try magenta for footer border
* trying font color for footer border
* trying to get message background to show
* can't get it to render, but changed message background to violet
* testing sidebar changes
* sidebar colors
* lighter sidebar color
* trying gray sidebar
* try a gradient
* screwed up one of the coordinates
* reversing gradient
* attempting gradient with colors i made up
* accidentally wrote gradient to dracula instead of solarized dark
* adding gradient to the top, reversing bottom gradient
* randomly trying shuffling bottom gradient coords
* moving top right coordinate somewhere else
* swapped top two bottom coords to see
* swapped them back, i got lucky and things were right
* think i figured out the order, BL, BR, TL, TR
* making background gradient lil darker
* fixed coords
* lessening gradient effect
* lessening gradient effect, but by making darker instead of lighter
* of course, messed up two coords
* removed top and bottom gradients
* dark and flat sidebar
* forgot to change running background
* made running background a bit less transparent since this is a low contrast theme
* added underscore to theme name
* adjusting message background color
* fixing message background color
* fixed cursor color border
* adjusting text to be one notch brighter, base0 -> base1, base01 -> base0
* adjusting sublabel text to use base00 instead, its in between base01 and base0
* added message hashes for light theme name
* added defines and enums for the light theme
* added solarized light structs into ozone.c, theyre all clones of dark for now
* fixing solarized dark ozone theme
fixing name of theme in ozone.c so assets load properly, fixing cursor and message colors to be green instead of purple
* added message hashes for light theme name
* added defines and enums for the light theme
* added solarized light structs into ozone.c, theyre all clones of dark for now
* i had based this branch on the wrong branch, fixed
* first pass, only changing background and regular text
* trying orange and magenta highlights
* Revert "trying orange and magenta highlights"
This reverts commit 1f1e107888cee0e97c6354a8d114863b39af8d00.
* applying the new colors to the right theme this time :)
* trying red instead of pink
* trying magenta icons in a desperate attempt to justify the use of the color
* trying magenta icons, orange labels and selector
* back to orange and red, sigh
* trying sidebar colors
* fixing sidebar gradient
* light theme red animated border colors
* trying magenta for second border color
* that was bad, trying a less light red
* going even darker
* made cursor border get darker instead of lighter
* that was a little too dark
* changed light theme running background to be..light
* feat: adding solarized dark theme to ozone
* fix: variable not defined in header
* fix: added string for selecting theme in menu
* fix: added message hash for string
* feat: copied solarized dark translations into msg hashes
* fix: forgot to change name of enum label after copying
* first pass of new colors
* added selection border and fixed sublabel color
* sublabel color from blue to muted gray
* trying cyan for sublabel
* adjusted selected text color to match philosophy from solarized website
* testing what the entries_ colors do
* chose colors for entries_, adjusted other border and bgs
* match selection border to sublabel color
* trying gray for sublabel
* accidentally put the color in the wrong place, reverting and updating
* trying to change selected option color to orange
* not feeling orange, lets try teal
* try for orange border
* try for magenta border
* try for violet border
* trying blue border again
* trying omar blue bc why not
* reverting to regular blue for icons and green for border
* try magenta for footer border
* trying font color for footer border
* trying to get message background to show
* can't get it to render, but changed message background to violet
* testing sidebar changes
* sidebar colors
* lighter sidebar color
* trying gray sidebar
* try a gradient
* screwed up one of the coordinates
* reversing gradient
* attempting gradient with colors i made up
* accidentally wrote gradient to dracula instead of solarized dark
* adding gradient to the top, reversing bottom gradient
* randomly trying shuffling bottom gradient coords
* moving top right coordinate somewhere else
* swapped top two bottom coords to see
* swapped them back, i got lucky and things were right
* think i figured out the order, BL, BR, TL, TR
* making background gradient lil darker
* fixed coords
* lessening gradient effect
* lessening gradient effect, but by making darker instead of lighter
* of course, messed up two coords
* removed top and bottom gradients
* dark and flat sidebar
* forgot to change running background
* made running background a bit less transparent since this is a low contrast theme
* added underscore to theme name
* adjusting message background color
* fixing message background color
* fixed cursor color border
* adjusting text to be one notch brighter, base0 -> base1, base01 -> base0
* adjusting sublabel text to use base00 instead, its in between base01 and base0
* added message hashes for light theme name
* added defines and enums for the light theme
* added solarized light structs into ozone.c, theyre all clones of dark for now
* fixing solarized dark ozone theme
fixing name of theme in ozone.c so assets load properly, fixing cursor and message colors to be green instead of purple
* added message hashes for light theme name
* added defines and enums for the light theme
* added solarized light structs into ozone.c, theyre all clones of dark for now
* i had based this branch on the wrong branch, fixed
* first pass, only changing background and regular text
* trying orange and magenta highlights
* Revert "trying orange and magenta highlights"
This reverts commit 1f1e107888cee0e97c6354a8d114863b39af8d00.
* applying the new colors to the right theme this time :)
* trying red instead of pink
* trying magenta icons in a desperate attempt to justify the use of the color
* trying magenta icons, orange labels and selector
* back to orange and red, sigh
* trying sidebar colors
* fixing sidebar gradient
* light theme red animated border colors
* trying magenta for second border color
* that was bad, trying a less light red
* going even darker
* made cursor border get darker instead of lighter
* that was a little too dark
* changed light theme running background to be..light
* feat: adding solarized dark theme to ozone
* fix: variable not defined in header
* fix: added string for selecting theme in menu
* fix: added message hash for string
* feat: copied solarized dark translations into msg hashes
* fix: forgot to change name of enum label after copying
* first pass of new colors
* added selection border and fixed sublabel color
* sublabel color from blue to muted gray
* trying cyan for sublabel
* adjusted selected text color to match philosophy from solarized website
* testing what the entries_ colors do
* chose colors for entries_, adjusted other border and bgs
* match selection border to sublabel color
* trying gray for sublabel
* accidentally put the color in the wrong place, reverting and updating
* trying to change selected option color to orange
* not feeling orange, lets try teal
* try for orange border
* try for magenta border
* try for violet border
* trying blue border again
* trying omar blue bc why not
* reverting to regular blue for icons and green for border
* try magenta for footer border
* trying font color for footer border
* trying to get message background to show
* can't get it to render, but changed message background to violet
* testing sidebar changes
* sidebar colors
* lighter sidebar color
* trying gray sidebar
* try a gradient
* screwed up one of the coordinates
* reversing gradient
* attempting gradient with colors i made up
* accidentally wrote gradient to dracula instead of solarized dark
* adding gradient to the top, reversing bottom gradient
* randomly trying shuffling bottom gradient coords
* moving top right coordinate somewhere else
* swapped top two bottom coords to see
* swapped them back, i got lucky and things were right
* think i figured out the order, BL, BR, TL, TR
* making background gradient lil darker
* fixed coords
* lessening gradient effect
* lessening gradient effect, but by making darker instead of lighter
* of course, messed up two coords
* removed top and bottom gradients
* dark and flat sidebar
* forgot to change running background
* made running background a bit less transparent since this is a low contrast theme
zoltanvb