From 59c71b8db416b80295d0c091ceaeeecde3257c45 Mon Sep 17 00:00:00 2001
From: pstef <3462925+pstef@users.noreply.github.com>
Date: Mon, 7 Apr 2025 20:18:36 +0000
Subject: [PATCH] Rewrite part of cheat_manager_load_cb_second_pass()

This is to silence a stringop warning that I believe to be a false
positive.  Nevertheless, this change reduces verbosity of the code
and introduces a couple of checks that weren't there previously.

Note that the base parameter of this strtoul call is changed from 0
to 10, because previously the while loop rejected characters other
than 0-9 so strtoul didn't have to. Now that the loop is gone, the
call has to reject characters that are not decimal digits to keep
the logic as it was.
---
 cheat_manager.c | 24 ++++++------------------
 1 file changed, 6 insertions(+), 18 deletions(-)

diff --git a/cheat_manager.c b/cheat_manager.c
index 95d3a5c125..d2baf97e5d 100644
--- a/cheat_manager.c
+++ b/cheat_manager.c
@@ -394,33 +394,21 @@ static void cheat_manager_load_cb_first_pass(char *key, char *value)
 
 static void cheat_manager_load_cb_second_pass(char *s, char *value)
 {
-   size_t _len;
-   char cheat_num_str[20];
    unsigned cheat_num, cheat_idx;
-   unsigned idx                = 5;
+   char *numend                = NULL;
    cheat_manager_t *cheat_st   = &cheat_manager_state;
 
-   errno                       = 0;
-
-   if (strncmp(s, "cheat", 5) != 0)
+   if (strncmp(s, "cheat", 5) != 0 || s[5] == '\0')
       return;
 
-   _len = strlen((const char*)s);
-
-   while (idx < _len && s[idx] >= '0' && s[idx] <= '9' && idx < 24)
-   {
-      cheat_num_str[idx - 5] = s[idx];
-      idx++;
-   }
-
-   cheat_num_str[idx - 5] = '\0';
-
-   cheat_num = (unsigned)strtoul(cheat_num_str, NULL, 0);
+   cheat_num = (unsigned)strtoul(&s[5], &numend, 10);
+   if (numend == &s[5] || *numend == '\0')
+      return;
 
    if (cheat_num + cheat_st->loading_cheat_offset >= cheat_st->size)
       return;
 
-   s = s + idx + 1;
+   s = numend + 1;
 
    cheat_idx = cheat_num + cheat_st->loading_cheat_offset;