ShuriZma
/
RetroArch
mirror of https://github.com/libretro/RetroArch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix small strdup memory leak in case of need_fullpath and extraction

This commit is contained in:
Timo Strunk 2014-09-23 10:32:43 +02:00
parent cb5c951a70
commit d6347353d4
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
file.c
View File

@ -339,6 +339,8 @@ static bool load_content(const struct retro_subsystem_info *special,
unsigned i; unsigned i;
bool ret = true; bool ret = true;
struct string_list* additional_path_allocs = string_list_new();
struct retro_game_info *info = (struct retro_game_info*) struct retro_game_info *info = (struct retro_game_info*)
calloc(content->size, sizeof(*info)); calloc(content->size, sizeof(*info));
@ -399,10 +401,15 @@ static bool load_content(const struct retro_subsystem_info *special,
} }
char new_path[PATH_MAX]; char new_path[PATH_MAX];
union string_list_elem_attr attr;
attr.i = 0;
fill_pathname_join(new_path,g_settings.extraction_directory, fill_pathname_join(new_path,g_settings.extraction_directory,
path_basename(path),sizeof(new_path)); path_basename(path),sizeof(new_path));
read_compressed_file(path,NULL,new_path); read_compressed_file(path,NULL,new_path);
info[i].path = strdup(new_path); string_list_append(additional_path_allocs,new_path,attr);
info[i].path =
additional_path_allocs->elems
[additional_path_allocs->size -1 ].data;
} }
} }
} }
@ -418,6 +425,8 @@ static bool load_content(const struct retro_subsystem_info *special,
end: end:
for (i = 0; i < content->size; i++) for (i = 0; i < content->size; i++)
free((void*)info[i].data); free((void*)info[i].data);
string_list_free(additional_path_allocs);
free(info); free(info);
return ret; return ret;
} }