From d2f5a2903098934957eddfaec98c017254b239ca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Higor=20Eur=C3=ADpedes?= Date: Tue, 24 Mar 2015 20:21:59 -0300 Subject: [PATCH] (Menu) Fix memleak in get_title --- menu/drivers/shared.h | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/menu/drivers/shared.h b/menu/drivers/shared.h index ab2f300786..a7e173bbd9 100644 --- a/menu/drivers/shared.h +++ b/menu/drivers/shared.h @@ -28,19 +28,25 @@ static INLINE void get_title(const char *label, const char *dir, struct string_list *list_label = string_split(label, "|"); struct string_list *list_path = string_split(dir, "|"); - if (list_label && list_label->size > 0) + if (list_label) { - strlcpy(elem0, list_label->elems[0].data, sizeof(elem0)); - if (list_label->size > 1) - strlcpy(elem1, list_label->elems[1].data, sizeof(elem1)); + if (list_label->size > 0) + { + strlcpy(elem0, list_label->elems[0].data, sizeof(elem0)); + if (list_label->size > 1) + strlcpy(elem1, list_label->elems[1].data, sizeof(elem1)); + } string_list_free(list_label); } - if (list_path && list_path->size > 0) + if (list_path) { - strlcpy(elem0_path, list_path->elems[0].data, sizeof(elem0_path)); - if (list_path->size > 1) - strlcpy(elem1_path, list_path->elems[1].data, sizeof(elem1_path)); + if (list_path->size > 0) + { + strlcpy(elem0_path, list_path->elems[0].data, sizeof(elem0_path)); + if (list_path->size > 1) + strlcpy(elem1_path, list_path->elems[1].data, sizeof(elem1_path)); + } string_list_free(list_path); }