ShuriZma
/
RetroArch
mirror of https://github.com/libretro/RetroArch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix system menu sound memory leaks in mod mixing

This commit is contained in:
Brad Parker 2019-01-19 00:46:54 -05:00
parent ae397f2ae5
commit cb4a87d6b1
1 changed files with 18 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
libretro-common/audio/audio_mixer.c
View File

@ -177,11 +177,12 @@ struct audio_mixer_voice
#ifdef HAVE_IBXM #ifdef HAVE_IBXM
struct struct
{ {
unsigned position; unsigned position;
unsigned samples; unsigned samples;
unsigned buf_samples; unsigned buf_samples;
int* buffer; int* buffer;
struct replay* stream; struct replay* stream;
struct module* module;
} mod; } mod;
#endif #endif
} types; } types;
@ -604,7 +605,12 @@ static bool audio_mixer_play_mod(
goto error; goto error;
} }
replay = new_replay( module, s_rate, 1); if (voice->types.mod.module)
dispose_module(voice->types.mod.module);
voice->types.mod.module = module;
replay = new_replay(module, s_rate, 1);
if (!replay) if (!replay)
{ {
@ -629,11 +635,16 @@ static bool audio_mixer_play_mod(
goto error; goto error;
} }
if (voice->types.mod.buffer)
memalign_free(voice->types.mod.buffer);
if (voice->types.mod.stream)
dispose_replay(voice->types.mod.stream);
voice->types.mod.buffer = (int*)mod_buffer; voice->types.mod.buffer = (int*)mod_buffer;
voice->types.mod.buf_samples = buf_samples; voice->types.mod.buf_samples = buf_samples;
voice->types.mod.stream = replay; voice->types.mod.stream = replay;
voice->types.mod.position = 0; voice->types.mod.position = 0;
voice->types.mod.samples = 0; /* samples; */ voice->types.mod.samples = 0; /* samples; */
return true; return true;