ShuriZma
/
RetroArch
mirror of https://github.com/libretro/RetroArch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

rarch_task_push_decompress - deal with possible memory leaks

This commit is contained in:
twinaphex 2016-01-21 03:14:22 +01:00
parent f9e389ac56
commit c9fc8cd7d3
1 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
tasks/task_decompress.c
View File

@ -205,7 +205,7 @@ bool rarch_task_push_decompress(const char *source_file, const char *target_dir,
/* ZIP or APK only */ /* ZIP or APK only */
is_compressed = string_is_equal(path_get_extension(source_file), "zip"); is_compressed = string_is_equal(path_get_extension(source_file), "zip");
is_compressed = !is_compressed ? string_is_equal(path_get_extension(source_file), "apk") : is_compressed; is_compressed = is_compressed || string_is_equal(path_get_extension(source_file), "apk");
if (!path_file_exists(source_file) || !is_compressed) if (!path_file_exists(source_file) || !is_compressed)
{ {
@ -227,6 +227,9 @@ bool rarch_task_push_decompress(const char *source_file, const char *target_dir,
s = (decompress_state_t*)calloc(1, sizeof(*s)); s = (decompress_state_t*)calloc(1, sizeof(*s));
if (!s)
goto error;
s->source_file = strdup(source_file); s->source_file = strdup(source_file);
s->target_dir = strdup(target_dir); s->target_dir = strdup(target_dir);
@ -234,6 +237,10 @@ bool rarch_task_push_decompress(const char *source_file, const char *target_dir,
s->zlib.type = ZLIB_TRANSFER_INIT; s->zlib.type = ZLIB_TRANSFER_INIT;
t = (rarch_task_t*)calloc(1, sizeof(*t)); t = (rarch_task_t*)calloc(1, sizeof(*t));
if (!t)
goto error;
t->state = s; t->state = s;
t->handler = rarch_task_decompress_handler; t->handler = rarch_task_decompress_handler;
@ -252,4 +259,11 @@ bool rarch_task_push_decompress(const char *source_file, const char *target_dir,
rarch_task_push(t); rarch_task_push(t);
return true; return true;
error:
if (s)
free(s);
if (t)
free(t);
return false;
} }