diff --git a/frontend/drivers/platform_android.c b/frontend/drivers/platform_android.c index d0119cb899..4e25599227 100644 --- a/frontend/drivers/platform_android.c +++ b/frontend/drivers/platform_android.c @@ -517,7 +517,7 @@ static void frontend_android_get_environment_settings(int *argc, if (android_app->getStringExtra && jstr) { const char *argv = (*env)->GetStringUTFChars(env, jstr, 0); - bool used = (strcmp(argv, "false") == 0) ? false : true; + bool used = (!strcmp(argv, "false")) ? false : true; (*env)->ReleaseStringUTFChars(env, jstr, argv); diff --git a/frontend/drivers/platform_ps3.c b/frontend/drivers/platform_ps3.c index cce291fc47..6ac4817d9b 100644 --- a/frontend/drivers/platform_ps3.c +++ b/frontend/drivers/platform_ps3.c @@ -102,7 +102,7 @@ static void frontend_ps3_get_environment_settings(int *argc, char *argv[], /* not launched from external launcher, set default path */ // second param is multiMAN SELF file if(path_file_exists(argv[2]) && *argc > 1 - && (strcmp(argv[2], EMULATOR_CONTENT_DIR) == 0)) + && (!strcmp(argv[2], EMULATOR_CONTENT_DIR))) { multiman_detected = true; RARCH_LOG("Started from multiMAN, auto-game start enabled.\n"); diff --git a/frontend/frontend_driver.c b/frontend/frontend_driver.c index 3946baa38d..6467555f1e 100644 --- a/frontend/frontend_driver.c +++ b/frontend/frontend_driver.c @@ -71,7 +71,7 @@ const frontend_ctx_driver_t *frontend_ctx_find_driver(const char *ident) for (i = 0; frontend_ctx_drivers[i]; i++) { - if (strcmp(frontend_ctx_drivers[i]->ident, ident) == 0) + if (!strcmp(frontend_ctx_drivers[i]->ident, ident)) return frontend_ctx_drivers[i]; } diff --git a/gfx/drivers_shader/shader_glsl.c b/gfx/drivers_shader/shader_glsl.c index bf2eef085a..1c8943117e 100644 --- a/gfx/drivers_shader/shader_glsl.c +++ b/gfx/drivers_shader/shader_glsl.c @@ -757,7 +757,9 @@ static bool gl_glsl_init(void *data, const char *path) if (path) { bool ret; - if (strcmp(path_get_extension(path), "glsl") == 0) + const char *path_ext = path_get_extension(path); + + if (!strcmp(path_ext, "glsl")) { strlcpy(glsl->glsl_shader->pass[0].source.path, path, sizeof(glsl->glsl_shader->pass[0].source.path)); @@ -765,7 +767,7 @@ static bool gl_glsl_init(void *data, const char *path) glsl->glsl_shader->modern = true; ret = true; } - else if (strcmp(path_get_extension(path), "glslp") == 0) + else if (!strcmp(path_ext, "glslp")) { conf = config_file_new(path); if (conf) diff --git a/input/input_joypad_driver.c b/input/input_joypad_driver.c index 0636852500..b9e779a4f1 100644 --- a/input/input_joypad_driver.c +++ b/input/input_joypad_driver.c @@ -160,7 +160,7 @@ const input_device_driver_t *input_joypad_init_driver(const char *ident, void *d for (i = 0; joypad_drivers[i]; i++) { - if (strcmp(ident, joypad_drivers[i]->ident) == 0 + if (!strcmp(ident, joypad_drivers[i]->ident) && joypad_drivers[i]->init(data)) { RARCH_LOG("Found joypad driver: \"%s\".\n", diff --git a/ui/ui_companion_driver.c b/ui/ui_companion_driver.c index 2f1ded0c64..382308f101 100644 --- a/ui/ui_companion_driver.c +++ b/ui/ui_companion_driver.c @@ -49,7 +49,7 @@ const ui_companion_driver_t *ui_companion_find_driver(const char *ident) for (i = 0; ui_companion_drivers[i]; i++) { - if (strcmp(ui_companion_drivers[i]->ident, ident) == 0) + if (!strcmp(ui_companion_drivers[i]->ident, ident)) return ui_companion_drivers[i]; }