From bae3bf8393d2cef718bdd718b0d7d2f0cc50b038 Mon Sep 17 00:00:00 2001 From: twinaphex Date: Wed, 20 Nov 2013 17:57:51 +0100 Subject: [PATCH] (Android) Camera - update FIXMEs --- camera/android.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/camera/android.c b/camera/android.c index af9e116b83..f8426b1145 100644 --- a/camera/android.c +++ b/camera/android.c @@ -19,12 +19,6 @@ #include "../driver.h" #include "../android/native/jni/jni_macros.h" -/* FIXME - we need to seriously profile JNI overhead here - whether we can cache certain - * objects/variables */ -/* FIXME - check whether or not it is safe to attach the thread once at android_init and - * only detach it when calling android_free - might have to be done per-function but would - * introduce significant overhead */ - typedef struct android_camera { jclass class; @@ -163,6 +157,7 @@ static bool android_camera_poll(void *data, retro_camera_frame_raw_framebuffer_t 0.0f, 0.0f, 1.0f }; + // FIXME: Still only gets a black picture back if (frame_gl_cb) frame_gl_cb(androidcamera->tex, GL_TEXTURE_EXTERNAL_OES,