From eb27dd40432c802ace3fb1e0c930f360a464894d Mon Sep 17 00:00:00 2001 From: Lioncash Date: Thu, 4 Sep 2014 01:51:51 -0400 Subject: [PATCH] shader_parse: Fix potential sscanf buffer overflow Indexes are zero-based, so although the buffers are 64 elements in size, we only have addressing from 0-63. --- gfx/shader_parse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gfx/shader_parse.c b/gfx/shader_parse.c index 95eccd5966..0b2dcda107 100644 --- a/gfx/shader_parse.c +++ b/gfx/shader_parse.c @@ -304,7 +304,7 @@ bool gfx_shader_resolve_parameters(config_file_t *conf, struct gfx_shader *shade while (shader->num_parameters < ARRAY_SIZE(shader->parameters) && fgets(line, sizeof(line), file)) { - int ret = sscanf(line, "#pragma parameter %64s \"%64[^\"]\" %f %f %f %f", + int ret = sscanf(line, "#pragma parameter %63s \"%63[^\"]\" %f %f %f %f", param->id, param->desc, ¶m->initial, ¶m->minimum, ¶m->maximum, ¶m->step); if (ret >= 5)