From a39bff6e039e987b31d9cc39656d990149d6c963 Mon Sep 17 00:00:00 2001 From: Gregor Richards Date: Sat, 3 Mar 2018 23:03:35 -0500 Subject: [PATCH] Remove an incorrect double-check Netplay sync incorrectly checked whether the replay pointer was behind the unread pointer twice, when in the second check it should only have been checking if it was behind the current execution pointer. Because of how resimulation works with device sharing, I THINK this could affect sync. Even if it can't, it's wrong. --- network/netplay/netplay_sync.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/network/netplay/netplay_sync.c b/network/netplay/netplay_sync.c index aff2359cf8..69386916c5 100644 --- a/network/netplay/netplay_sync.c +++ b/network/netplay/netplay_sync.c @@ -768,8 +768,7 @@ void netplay_sync_post_frame(netplay_t *netplay, bool stalled) /* Now replay the real input if we've gotten ahead of it */ if (netplay->force_rewind || - (netplay->replay_frame_count < netplay->unread_frame_count && - netplay->replay_frame_count < netplay->run_frame_count)) + netplay->replay_frame_count < netplay->run_frame_count) { retro_ctx_serialize_info_t serial_info;