ShuriZma
/
RetroArch
mirror of https://github.com/libretro/RetroArch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Optimize menu_displaylist_parse_core_options_dropdown_list: 

* Hose val_d snprintf outside of loop
* Make it smaller
This commit is contained in:
LibretroAdmin 2022-08-26 00:02:04 +02:00
parent d67cb22c7f
commit 9535c5c0ad
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
menu/menu_displaylist.c
View File

@ -1127,6 +1127,7 @@ error:
static unsigned menu_displaylist_parse_core_option_dropdown_list( static unsigned menu_displaylist_parse_core_option_dropdown_list(
menu_displaylist_info_t *info) menu_displaylist_info_t *info)
{ {
char val_d[8];
unsigned count = 0; unsigned count = 0;
struct string_list tmp_str_list = {0}; struct string_list tmp_str_list = {0};
unsigned option_index = 0; unsigned option_index = 0;
@ -1156,6 +1157,8 @@ static unsigned menu_displaylist_parse_core_option_dropdown_list(
option_index = string_to_unsigned( option_index = string_to_unsigned(
tmp_str_list.elems[tmp_str_list.size - 1].data); tmp_str_list.elems[tmp_str_list.size - 1].data);
val_d[0] = '\0';
snprintf(val_d, sizeof(val_d), "%d", option_index);
/* Get option itself + current value */ /* Get option itself + current value */
option = (struct core_option*)&coreopts->opts[option_index]; option = (struct core_option*)&coreopts->opts[option_index];
@ -1173,11 +1176,6 @@ static unsigned menu_displaylist_parse_core_option_dropdown_list(
if (!string_is_empty(val_label_str)) if (!string_is_empty(val_label_str))
{ {
char val_d[256]; /* TODO/FIXME - way too big for just storing an integer */
val_d[0] = '\0';
snprintf(val_d, sizeof(val_d), "%d", option_index);
if (string_is_equal(val_label_str, msg_hash_to_str(MENU_ENUM_LABEL_ENABLED))) if (string_is_equal(val_label_str, msg_hash_to_str(MENU_ENUM_LABEL_ENABLED)))
val_label_str = msg_hash_to_str(MENU_ENUM_LABEL_VALUE_ON); val_label_str = msg_hash_to_str(MENU_ENUM_LABEL_VALUE_ON);
else if (string_is_equal(val_label_str, msg_hash_to_str(MENU_ENUM_LABEL_DISABLED))) else if (string_is_equal(val_label_str, msg_hash_to_str(MENU_ENUM_LABEL_DISABLED)))