From 8f3e02e49c1898ccf32cc2f4bfe84ad00f4f11ac Mon Sep 17 00:00:00 2001 From: repojohnray Date: Sat, 10 Apr 2021 17:30:56 +0200 Subject: [PATCH] Fix issue detected by valgrind ==27741== Conditional jump or move depends on uninitialised value(s) ==27741== at 0x6080F5: strlcpy_retro__ (compat_strl.c:38) ==27741== by 0x60818A: strlcat_retro__ (compat_strl.c:60) ==27741== by 0x49EDD7: fill_pathname_join_special_ext (file_path.c:843) ==27741== by 0x4C78C8: config_load_remap (configuration.c:3765) ==27741== by 0x4386FF: command_event_init_core (retroarch.c:12601) ==27741== by 0x43B15E: command_event (retroarch.c:14000) ==27741== by 0x468863: retroarch_main_init (retroarch.c:35231) ==27741== by 0x487AED: content_load (task_content.c:607) ==27741== by 0x48A3D3: task_load_content_internal (task_content.c:2068) ==27741== by 0x48A6AD: task_push_load_content_from_cli (task_content.c:2162) ==27741== by 0x43D66E: rarch_main (retroarch.c:15300) ==27741== by 0x43D6ED: main (retroarch.c:15398) ==27741== Uninitialised value was created by a stack allocation ==27741== at 0x4C7730: config_load_remap (configuration.c:3721) --- configuration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configuration.c b/configuration.c index 2336bb1217..7eb979bc75 100644 --- a/configuration.c +++ b/configuration.c @@ -3719,7 +3719,7 @@ bool config_unload_override(void) bool config_load_remap(const char *directory_input_remapping, void *data) { - char content_dir_name[PATH_MAX_LENGTH]; + char content_dir_name[PATH_MAX_LENGTH] = { 0 }; /* path to the directory containing retroarch.cfg (prefix) */ char remap_directory[PATH_MAX_LENGTH]; /* final path for core-specific configuration (prefix+suffix) */