ShuriZma
/
RetroArch
mirror of https://github.com/libretro/RetroArch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add some some FIXMEs for broken code.

This commit is contained in:
Themaister 2012-06-23 16:10:56 +02:00
parent 14f7f641f3
commit 83c60aa94e
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
console/libretro_mgmt.c
View File

@ -79,6 +79,7 @@ const char *rarch_manage_libretro_set_first_file(const char *libretro_path, cons
//We need to set libretro to the first entry in the cores //We need to set libretro to the first entry in the cores
//directory so that it will be saved to the config file //directory so that it will be saved to the config file
// FIXME: Use struct string_list*
char ** dir_list = dir_list_new(libretro_path, exe_ext, false); char ** dir_list = dir_list_new(libretro_path, exe_ext, false);
const char * retstr = NULL; const char * retstr = NULL;
@ -112,14 +113,18 @@ const char *rarch_manage_libretro_set_first_file(const char *libretro_path, cons
} }
} }
// FIXME: Broken, returns a pointer to data on the stack.
retstr = fname_tmp; retstr = fname_tmp;
#else #else
// FIXME: Broken, returns a pointer to dynamically allocated data
// which is freed before returning.
retstr = first_exe; retstr = first_exe;
#endif #endif
RARCH_LOG("Set first entry in libretro core dir to libretro path: [%s].\n", retstr); RARCH_LOG("Set first entry in libretro core dir to libretro path: [%s].\n", retstr);
goto end; goto end;
} }
// TODO: Should not use two layers of goto labels.
error: error:
RARCH_ERR("Failed to set first entry to libretro path.\n"); RARCH_ERR("Failed to set first entry to libretro path.\n");
end: end: