From 7173efe10fd672ba3cb2370dd8dff1d2fa15de0a Mon Sep 17 00:00:00 2001 From: twinaphex Date: Fri, 20 Sep 2019 04:14:32 +0200 Subject: [PATCH] (Network/Relay Server Location) RetroArch crashed when pressing left while Relay Server Location entry was selected - index offset would set itself to -1 and cause a buffer overflow --- menu/menu_setting.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/menu/menu_setting.c b/menu/menu_setting.c index fbf5d0736a..d203449754 100644 --- a/menu/menu_setting.c +++ b/menu/menu_setting.c @@ -4615,8 +4615,9 @@ static int setting_string_action_left_netplay_mitm_server( if (!found) offset = list_len - 1; - strlcpy(setting->value.target.string, - netplay_mitm_server_list[offset].name, setting->size); + if (offset >= 0) + strlcpy(setting->value.target.string, + netplay_mitm_server_list[offset].name, setting->size); return 0; }