ShuriZma
/
RetroArch
mirror of https://github.com/libretro/RetroArch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

(menu_setting.c) Refactor away some strcmp usage

This commit is contained in:
twinaphex 2015-06-14 16:11:46 +02:00
parent 126fe2b702
commit 6f657ccdeb
2 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
menu/menu_hash.h
View File

@ -189,6 +189,7 @@ extern "C" {
#define MENU_VALUE_FILE 0x6a496536U #define MENU_VALUE_FILE 0x6a496536U
#define MENU_VALUE_RDB 0x0b00f54eU #define MENU_VALUE_RDB 0x0b00f54eU
#define MENU_VALUE_DIR 0x0af95f55U #define MENU_VALUE_DIR 0x0af95f55U
#define MENU_VALUE_NO_CORE 0x7d5472cbU
#define MENU_LABEL_CONTENT_ACTIONS 0xa0d76970U #define MENU_LABEL_CONTENT_ACTIONS 0xa0d76970U
#define MENU_LABEL_DETECT_CORE_LIST 0xaa07c341U #define MENU_LABEL_DETECT_CORE_LIST 0xaa07c341U

19
menu/menu_setting.c
View File

@ -500,6 +500,7 @@ static void setting_reset_setting(rarch_setting_t* setting)
int setting_set_with_string_representation(rarch_setting_t* setting, int setting_set_with_string_representation(rarch_setting_t* setting,
const char* value) const char* value)
{ {
uint32_t value_hash;
if (!setting || !value) if (!setting || !value)
return -1; return -1;
@ -542,10 +543,17 @@ int setting_set_with_string_representation(rarch_setting_t* setting,
strlcpy(setting->value.string, value, setting->size); strlcpy(setting->value.string, value, setting->size);
break; break;
case ST_BOOL: case ST_BOOL:
if (!strcmp(value, "true")) value_hash = djb2_calculate(value);
*setting->value.boolean = true;
else if (!strcmp(value, "false")) switch (value_hash)
*setting->value.boolean = false; {
case MENU_VALUE_TRUE:
*setting->value.boolean = true;
break;
case MENU_VALUE_FALSE:
*setting->value.boolean = false;
break;
}
break; break;
/* TODO */ /* TODO */
@ -3573,8 +3581,9 @@ static bool setting_append_list_main_menu_options(
{ {
struct retro_system_info *info = (struct retro_system_info*) struct retro_system_info *info = (struct retro_system_info*)
global ? &global->system.info : NULL; global ? &global->system.info : NULL;
uint32_t info_library_name_hash = info ? djb2_calculate(info->library_name) : 0;
if (info && strcmp(info->library_name, "No Core") != 0) if (info && (info_library_name_hash == MENU_VALUE_NO_CORE))
CONFIG_ACTION( CONFIG_ACTION(
"unload_core", "unload_core",
"Unload Core", "Unload Core",