From 5b5ad03ec3eed265b28c3580ad7a003e81135a47 Mon Sep 17 00:00:00 2001 From: twinaphex Date: Sat, 24 Sep 2016 17:04:01 +0200 Subject: [PATCH] Attempt to fix Coverity warnings --- gfx/drivers_shader/shader_glsl.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/gfx/drivers_shader/shader_glsl.c b/gfx/drivers_shader/shader_glsl.c index 2849ae1896..98ad50026c 100644 --- a/gfx/drivers_shader/shader_glsl.c +++ b/gfx/drivers_shader/shader_glsl.c @@ -402,9 +402,15 @@ static bool gl_glsl_load_source_path(struct video_shader_pass *pass, const char *path) { ssize_t len; - bool ret = filestream_read_file(path, + int nitems = false; + + if (!pass) + return false; + + nitems = filestream_read_file(path, (void**)&pass->source.string.vertex, &len); - if (!ret || len <= 0) + + if (nitems <= 0 || len <= 0) return false; gl_glsl_strip_parameter_pragmas(pass->source.string.vertex);