diff --git a/tasks/task_content.c b/tasks/task_content.c index 50ca38b500..0140b0b062 100644 --- a/tasks/task_content.c +++ b/tasks/task_content.c @@ -210,10 +210,10 @@ static int content_7zip_file_read( for (i = 0; i < db.db.NumFiles; i++) { size_t len; - char infile[PATH_MAX_LENGTH]; - size_t offset = 0; - size_t outSizeProcessed = 0; - const CSzFileItem *f = db.db.Files + i; + char infile[PATH_MAX_LENGTH] = {0}; + size_t offset = 0; + size_t outSizeProcessed = 0; + const CSzFileItem *f = db.db.Files + i; /* We skip over everything which is not a directory. * FIXME: Why continue then if f->IsDir is true?*/ @@ -359,7 +359,7 @@ static struct string_list *compressed_7zip_file_list_new( for (i = 0; i < db.db.NumFiles; i++) { union string_list_elem_attr attr; - char infile[PATH_MAX_LENGTH]; + char infile[PATH_MAX_LENGTH] = {0}; const char *file_ext = NULL; size_t len = 0; bool supported_by_core = false; @@ -719,7 +719,7 @@ struct string_list *compressed_file_list_new(const char *path, static void check_defaults_dir_create_dir(const char *path) { - char new_path[PATH_MAX_LENGTH]; + char new_path[PATH_MAX_LENGTH] = {0}; fill_pathname_expand_special(new_path, path, sizeof(new_path)); @@ -1019,9 +1019,9 @@ bool dump_to_file_desperate(const void *data, size_t size, unsigned type) { time_t time_; - char timebuf[256]; - char application_data[PATH_MAX_LENGTH]; - char path[PATH_MAX_LENGTH]; + char timebuf[256] = {0}; + char application_data[PATH_MAX_LENGTH] = {0}; + char path[PATH_MAX_LENGTH] = {0}; if (!fill_pathname_application_data(application_data, sizeof(application_data))) @@ -1307,8 +1307,8 @@ static bool init_content_file_extract( if (string_is_equal_noncase(ext, "zip")) { - char new_path[PATH_MAX_LENGTH]; - char temp_content[PATH_MAX_LENGTH]; + char new_path[PATH_MAX_LENGTH] = {0}; + char temp_content[PATH_MAX_LENGTH] = {0}; strlcpy(temp_content, content->elems[i].data, sizeof(temp_content)); @@ -1530,8 +1530,8 @@ error: static void menu_content_environment_get(int *argc, char *argv[], void *args, void *params_data) { - struct rarch_main_wrap *wrap_args = (struct rarch_main_wrap*)params_data; char *fullpath = NULL; + struct rarch_main_wrap *wrap_args = (struct rarch_main_wrap*)params_data; global_t *global = global_get_ptr(); settings_t *settings = config_get_ptr(); @@ -1578,9 +1578,9 @@ static void menu_content_environment_get(int *argc, char *argv[], static bool task_load_content(content_ctx_info_t *content_info, bool launched_from_menu) { - char name[PATH_MAX_LENGTH]; - char msg[PATH_MAX_LENGTH]; - char *fullpath = NULL; + char name[PATH_MAX_LENGTH] = {0}; + char msg[PATH_MAX_LENGTH] = {0}; + char *fullpath = NULL; runloop_ctl(RUNLOOP_CTL_GET_CONTENT_PATH, &fullpath); @@ -1611,7 +1611,7 @@ static bool task_load_content(content_ctx_info_t *content_info, /* Push entry to top of history playlist */ if (content_is_inited() || content_does_not_need_content()) { - char tmp[PATH_MAX_LENGTH]; + char tmp[PATH_MAX_LENGTH] = {0}; struct retro_system_info *info = NULL; rarch_system_info_t *system = NULL; @@ -1658,10 +1658,12 @@ error: static bool command_event_cmd_exec(void *data) { - char *fullpath; #if defined(HAVE_DYNAMIC) content_ctx_info_t content_info; +#endif + char *fullpath = NULL; +#if defined(HAVE_DYNAMIC) content_info.argc = 0; content_info.argv = NULL; content_info.args = NULL; diff --git a/tasks/task_database.c b/tasks/task_database.c index cde6bc8f09..67524c80b0 100644 --- a/tasks/task_database.c +++ b/tasks/task_database.c @@ -158,9 +158,9 @@ static int iso_get_serial(database_state_handle_t *db_state, static int cue_get_serial(database_state_handle_t *db_state, database_info_handle_t *db, const char *name, char* serial) { - char track_path[PATH_MAX_LENGTH]; - int32_t offset = 0; - int rv = find_first_data_track(name, &offset, track_path, PATH_MAX_LENGTH); + int32_t offset = 0; + char track_path[PATH_MAX_LENGTH] = {0}; + int rv = find_first_data_track(name, &offset, track_path, PATH_MAX_LENGTH); if (rv < 0) { @@ -451,7 +451,7 @@ static int task_database_iterate_serial_lookup( if (db_state->entry_index == 0) { - char query[50]; + char query[50] = {0}; char *serial_buf = bin_to_hex_alloc((uint8_t*)db_state->serial, 10 * sizeof(uint8_t)); diff --git a/tasks/task_decompress.c b/tasks/task_decompress.c index 0b8f412741..407c5c7eb1 100644 --- a/tasks/task_decompress.c +++ b/tasks/task_decompress.c @@ -57,7 +57,7 @@ static int file_decompressed_subdir(const char *name, unsigned cmode, uint32_t csize,uint32_t size, uint32_t crc32, void *userdata) { - char path_dir[PATH_MAX_LENGTH]; + char path_dir[PATH_MAX_LENGTH] = {0}; char path[PATH_MAX_LENGTH] = {0}; decompress_state_t *dec = (decompress_state_t*)userdata; @@ -247,7 +247,7 @@ bool task_push_decompress( retro_task_callback_t cb, void *user_data) { - char tmp[PATH_MAX_LENGTH]; + char tmp[PATH_MAX_LENGTH] = {0}; decompress_state_t *s = NULL; retro_task_t *t = NULL; bool is_compressed = false; diff --git a/tasks/task_http.c b/tasks/task_http.c index a02ea3b060..79df608449 100644 --- a/tasks/task_http.c +++ b/tasks/task_http.c @@ -235,8 +235,8 @@ static bool task_http_retriever(retro_task_t *task, void *data) void *task_push_http_transfer(const char *url, bool mute, const char *type, retro_task_callback_t cb, void *user_data) { - char tmp[PATH_MAX_LENGTH]; task_finder_data_t find_data; + char tmp[PATH_MAX_LENGTH] = {0}; struct http_connection_t *conn = NULL; retro_task_t *t = NULL; http_handle_t *http = NULL; diff --git a/tasks/task_save_ram.c b/tasks/task_save_ram.c index bd2b7bc51c..fc7f8a5e27 100644 --- a/tasks/task_save_ram.c +++ b/tasks/task_save_ram.c @@ -346,8 +346,8 @@ bool content_load_ram_file(unsigned slot) */ bool content_save_ram_file(unsigned slot) { - retro_ctx_memory_info_t mem_info; ram_type_t ram; + retro_ctx_memory_info_t mem_info; global_t *global = global_get_ptr(); if (!global) diff --git a/tasks/task_screenshot.c b/tasks/task_screenshot.c index 43ba49db06..07ff1bade1 100644 --- a/tasks/task_screenshot.c +++ b/tasks/task_screenshot.c @@ -223,8 +223,8 @@ static bool take_screenshot_choice(const char *global_name_base) { unsigned old_width, old_height; size_t old_pitch; - void *frame_data; bool ret = false; + void *frame_data = NULL; const void* old_data = NULL; video_driver_cached_frame_get(&old_data, &old_width, &old_height,