From d7c9ca08cc4131b3d17f386bf6c1a5dad8227685 Mon Sep 17 00:00:00 2001 From: orbea Date: Sun, 31 Dec 2017 13:43:25 -0800 Subject: [PATCH 1/2] C89_BUILD=1 build fix libretro-common/audio/resampler/drivers/sinc_resampler.c:59:23: error: comma at end of enumerator list [-Werror=pedantic] SINC_WINDOW_LANCZOS, ^ cc1: some warnings being treated as errors make: *** [Makefile:164: obj-unix/./libretro-common/audio/resampler/drivers/sinc_resampler.o] Error 1 --- libretro-common/audio/resampler/drivers/sinc_resampler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libretro-common/audio/resampler/drivers/sinc_resampler.c b/libretro-common/audio/resampler/drivers/sinc_resampler.c index 6dd95afc2d..486f96a905 100644 --- a/libretro-common/audio/resampler/drivers/sinc_resampler.c +++ b/libretro-common/audio/resampler/drivers/sinc_resampler.c @@ -56,7 +56,7 @@ enum sinc_window { SINC_WINDOW_NONE = 0, SINC_WINDOW_KAISER, - SINC_WINDOW_LANCZOS, + SINC_WINDOW_LANCZOS }; /* For the little amount of taps we're using, From f993355f71a60b7acb0ec0d4a7f76fa82a5edbd1 Mon Sep 17 00:00:00 2001 From: orbea Date: Sun, 31 Dec 2017 14:13:20 -0800 Subject: [PATCH 2/2] qb: Fix undefined miniupnpc references with C89_BUILD=1 LD retroarch obj-unix/./libretro-common/net/net_natt.o: In function `natt_open_port': /RetroArch/libretro-common/net/net_natt.c:120: undefined reference to `UPNP_AddAnyPortMapping' /RetroArch/libretro-common/net/net_natt.c:133: undefined reference to `UPNP_GetExternalIPAddress' /RetroArch/libretro-common/net/net_natt.c:126: undefined reference to `UPNP_AddPortMapping' obj-unix/./libretro-common/net/net_natt.o: In function `natt_init': /RetroArch/libretro-common/net/net_natt.c:61: undefined reference to `upnpDiscover' /RetroArch/libretro-common/net/net_natt.c:74: undefined reference to `miniwget' /RetroArch/libretro-common/net/net_natt.c:77: undefined reference to `parserootdesc' /RetroArch/libretro-common/net/net_natt.c:79: undefined reference to `GetUPNPUrls' /RetroArch/libretro-common/net/net_natt.c:81: undefined reference to `freeUPNPDevlist' collect2: error: ld returned 1 exit status make: *** [Makefile:159: retroarch] Error 1 --- qb/config.libs.sh | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/qb/config.libs.sh b/qb/config.libs.sh index 551c4d19ff..cee53ec864 100644 --- a/qb/config.libs.sh +++ b/qb/config.libs.sh @@ -199,11 +199,9 @@ if [ "$HAVE_NETWORKING" = 'yes' ]; then if [ "$HAVE_MINIUPNPC" = 'no' ]; then HAVE_BUILTINMINIUPNPC=no - elif [ "$HAVE_BUILTINMINIUPNPC" = 'yes' ]; then - HAVE_MINIUPNPC=yes - else - check_lib '' MINIUPNPC '-lminiupnpc' fi + + check_lib '' MINIUPNPC '-lminiupnpc' else die : 'Warning: All networking features have been disabled.' HAVE_KEYMAPPER='no'