ShuriZma
/
RetroArch
mirror of https://github.com/libretro/RetroArch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

net_http: expire dns lookup failures more quickly (#17481)

This commit is contained in:
Eric Warmenhoven 2025-01-28 17:27:51 -05:00 committed by GitHub
parent d00ee5a70b
commit 12f66bebb7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
libretro-common/net/net_http.c
View File

@ -138,6 +138,8 @@ struct dns_cache_entry
static struct dns_cache_entry *dns_cache = NULL; static struct dns_cache_entry *dns_cache = NULL;
/* 5 min timeout, in usec */ /* 5 min timeout, in usec */
static const retro_time_t dns_cache_timeout = 1000 /* usec/ms */ * 1000 /* ms/s */ * 60 /* s/min */ * 5 /* min */; static const retro_time_t dns_cache_timeout = 1000 /* usec/ms */ * 1000 /* ms/s */ * 60 /* s/min */ * 5 /* min */;
/* only cache failures for 30 seconds */
static const retro_time_t dns_cache_fail_timeout = 1000 /* usec/ms */ * 1000 /* ms/s */ * 30 /* s */;
#ifdef HAVE_THREADS #ifdef HAVE_THREADS
static slock_t *dns_cache_lock = NULL; static slock_t *dns_cache_lock = NULL;
#endif #endif
@ -690,13 +692,15 @@ static void net_http_dns_cache_remove_expired(void)
struct dns_cache_entry *prev = NULL; struct dns_cache_entry *prev = NULL;
while (entry) while (entry)
{ {
if (entry->timestamp + dns_cache_timeout < cpu_features_get_time_usec()) if ( (entry->addr && (entry->timestamp + dns_cache_timeout < cpu_features_get_time_usec()))
|| (!entry->addr && (entry->timestamp + dns_cache_fail_timeout < cpu_features_get_time_usec())))
{ {
if (prev) if (prev)
prev->next = entry->next; prev->next = entry->next;
else else
dns_cache = entry->next; dns_cache = entry->next;
freeaddrinfo_retro(entry->addr); if (entry->addr)
freeaddrinfo_retro(entry->addr);
free(entry->domain); free(entry->domain);
free(entry); free(entry);
entry = prev ? prev->next : dns_cache; entry = prev ? prev->next : dns_cache;
@ -720,7 +724,9 @@ static struct dns_cache_entry *net_http_dns_cache_find(const char *domain, int p
{ {
if (port == entry->port && string_is_equal(entry->domain, domain)) if (port == entry->port && string_is_equal(entry->domain, domain))
{ {
entry->timestamp = cpu_features_get_time_usec(); /* don't bump timeestamp for failures */
if (entry->addr)
entry->timestamp = cpu_features_get_time_usec();
return entry; return entry;
} }
entry = entry->next; entry = entry->next;