ShuriZma
/
RetroArch
mirror of https://github.com/libretro/RetroArch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

video_shader_resolve_current_parameters - don't use malloc

This commit is contained in:
twinaphex 2020-08-26 19:10:43 +02:00
parent 3ff29abbc8
commit 1118ba09ec
1 changed files with 3 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
gfx/video_shader_parse.c
View File

@ -414,30 +414,21 @@ static struct video_shader_parameter *video_shader_parse_find_parameter(
bool video_shader_resolve_current_parameters(config_file_t *conf, bool video_shader_resolve_current_parameters(config_file_t *conf,
struct video_shader *shader) struct video_shader *shader)
{ {
size_t param_size = 4096 * sizeof(char); char parameters[4096];
const char *id = NULL; const char *id = NULL;
char *parameters = NULL;
char *save = NULL; char *save = NULL;
if (!conf) if (!conf)
return false; return false;
parameters = (char*)malloc(param_size);
if (!parameters)
return false;
parameters[0] = '\0'; parameters[0] = '\0';
/* Read in parameters which override the defaults. */ /* Read in parameters which override the defaults. */
if (!config_get_array(conf, "parameters", if (!config_get_array(conf, "parameters",
parameters, param_size)) parameters, sizeof(parameters)))
{
free(parameters);
return true; return true;
}
for (id = strtok_r(parameters, ";", &save); id; for ( id = strtok_r(parameters, ";", &save); id;
id = strtok_r(NULL, ";", &save)) id = strtok_r(NULL, ";", &save))
{ {
struct video_shader_parameter *parameter = struct video_shader_parameter *parameter =
@ -456,7 +447,6 @@ bool video_shader_resolve_current_parameters(config_file_t *conf,
RARCH_WARN("[CGP/GLSLP]: Parameter %s is not set in preset.\n", id); RARCH_WARN("[CGP/GLSLP]: Parameter %s is not set in preset.\n", id);
} }
free(parameters);
return true; return true;
} }