ShuriZma
/
RetroArch
mirror of https://github.com/libretro/RetroArch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

(XMB) Fix stack-buffer-overflow due to incorrect data type being passed by reference

This commit is contained in:
jdgleaver 2021-02-01 16:43:44 +00:00
parent 95226b77a1
commit 01265c1b08
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
menu/drivers/xmb.c
View File

@ -3826,7 +3826,9 @@ static int xmb_menu_entry_action(
static void xmb_render(void *data, static void xmb_render(void *data,
unsigned width, unsigned height, bool is_idle) unsigned width, unsigned height, bool is_idle)
{ {
unsigned i; /* 'i' must be of 'size_t', since it is passed
* by reference to menu_entries_ctl() */
size_t i;
float scale_factor; float scale_factor;
xmb_handle_t *xmb = (xmb_handle_t*)data; xmb_handle_t *xmb = (xmb_handle_t*)data;
settings_t *settings = config_get_ptr(); settings_t *settings = config_get_ptr();
@ -3881,7 +3883,7 @@ static void xmb_render(void *data,
xmb_calculate_visible_range(xmb, height, xmb_calculate_visible_range(xmb, height,
end, (unsigned)selection, &first, &last); end, (unsigned)selection, &first, &last);
for (i = first; i <= last; i++) for (i = (size_t)first; i <= (size_t)last; i++)
{ {
float entry_size = (i == (unsigned)selection) ? float entry_size = (i == (unsigned)selection) ?
xmb->icon_spacing_vertical * xmb->active_item_factor : xmb->icon_spacing_vertical; xmb->icon_spacing_vertical * xmb->active_item_factor : xmb->icon_spacing_vertical;