ShuriZma
/
Cxbx-Reloaded
mirror of https://github.com/Cxbx-Reloaded/Cxbx-Reloaded.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix `gigimport` in RSA

This commit is contained in:
Jannik Vogel 2019-03-04 02:28:30 +01:00
parent e0df0d6d9e
commit e1850c4277
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/common/crypto/EmuRsa.cpp
View File

@ -18,6 +18,7 @@
// * 59 Temple Place - Suite 330, Bostom, MA 02111-1307, USA. // * 59 Temple Place - Suite 330, Bostom, MA 02111-1307, USA.
// * // *
// * (c) 2018 ergo720 // * (c) 2018 ergo720
// * (c) 2019 Jannik Vogel
// * // *
// * All rights reserved // * All rights reserved
// * // *
@ -236,11 +237,6 @@ giant newgiant(int numshorts)
return(thegiant); return(thegiant);
} }
// ergo720: there's a bug in the original implementation of gigimport that prevents the rsa algorithm from working correctly on Windows (but
// for some reason it works on Ubuntu). This replacement implementation is taken from
// http://xbox-linux-devel.narkive.com/Qw6o31DP/xbedump-fix-for-array-out-of-bounds-access#post1
// and it has been improved based on JayFoxRox suggestions. See the link below for the details
// https://github.com/xqemu/xbedump/pull/5
void gigimport(giant g, const unsigned char *buff, int len) { void gigimport(giant g, const unsigned char *buff, int len) {
// copy buffered 'number' into giant's number buffer // copy buffered 'number' into giant's number buffer
@ -248,8 +244,14 @@ void gigimport(giant g, const unsigned char *buff, int len) {
assert((len % 2) == 0); assert((len % 2) == 0);
// Get number of shorts
g->sign = len / 2; g->sign = len / 2;
// Only count used shorts
while((g->sign >= 1) && (g->n[g->sign - 1] == 0)) {
g->sign -= 1;
}
assert(g->sign != 0); assert(g->sign != 0);
} }