Use C++ libc headers.

Fixed Xapi interception regression.

src/Common/Error.cpp

@@ -34,7 +34,7 @@
 
 #include "Common/Error.h"
 
-#include <string.h>
+#include <cstring>
 
 // clear the current error (returns false if error was fatal)
 bool Error::ClearError()

src/Common/Exe.cpp

@@ -33,7 +33,7 @@
 // ******************************************************************
 #include "Exe.h"
 
-#include <stdio.h>
+#include <cstdio>
 #include <memory.h>
 
 // construct via Exe file

src/Common/Win32/EmuShared.cpp

@@ -40,7 +40,7 @@
 
 #undef FIELD_OFFSET     // prevent macro redefinition warnings
 #include <windows.h>
-#include <stdio.h>
+#include <cstdio>
 
 // ******************************************************************
 // * exported globals

src/Common/Win32/XBController.h

@@ -38,8 +38,8 @@
 #include "Common/Error.h"
 #include "Mutex.h"
 
-#include <stdio.h>
-#include <string.h>
+#include <cstdio>
+#include <cstring>
 #include <windows.h>
 
 #include "CxbxKrnl/EmuXTL.h"

src/Common/Win32/XBVideo.cpp

@@ -33,7 +33,7 @@
 // ******************************************************************
 #include "XBVideo.h"
 
-#include <stdio.h>
+#include <cstdio>
 
 // ******************************************************************
 // * func: XBVideo::XBVideo

src/Common/Xbe.cpp

@@ -36,10 +36,10 @@
 #include "CxbxUtil.h"
 
 #include <memory.h>
-#include <locale.h>
-#include <stdlib.h>
-#include <string.h>
-#include <time.h>
+#include <clocale>
+#include <cstdlib>
+#include <cstring>
+#include <ctime>
 
 // construct via Xbe file
 Xbe::Xbe(const char *x_szFilename)

src/Common/Xbe.h

@@ -36,7 +36,7 @@
 
 #include "Common/Error.h"
 
-#include <stdio.h>
+#include <cstdio>
 
 // Xbe (Xbox Executable) file object
 class Xbe : public Error

src/Cxbe/Main.cpp

@@ -35,7 +35,7 @@
 #include "../Common/Exe.h"
 #include "../Common/Xbe.h"
 
-#include <string.h>
+#include <cstring>
 
 // static global(s)
 static void ShowUsage();

src/Cxbx/DlgControllerConfig.cpp

@@ -38,7 +38,7 @@
 #include "ResCxbx.h"
 
 #include <dinput.h>
-#include <stdio.h>
+#include <cstdio>
 
 /*! windows dialog procedure */
 static INT_PTR CALLBACK DlgControllerConfigProc(HWND hWndDlg, UINT uMsg, WPARAM wParam, LPARAM lParam);

src/Cxbx/EmuExe.cpp

@@ -37,7 +37,7 @@
 #include "CxbxUtil.h"
 #include "CxbxKrnl/CxbxKrnl.h"
 
-#include <stdio.h>
+#include <cstdio>
 
 // ******************************************************************
 // * constructor

src/Cxbx/WndAbout.cpp

@@ -35,7 +35,7 @@
 #include "ResCxbx.h"
 #include "jpegdec/jpegdec.h"
 
-#include <stdio.h>
+#include <cstdio>
 
 WndAbout::WndAbout(HINSTANCE x_hInstance, HWND x_parent) : Wnd(x_hInstance)
 {

src/Cxbx/jpegdec/jpegdec.cpp

@@ -33,7 +33,7 @@
 // ******************************************************************
 #include "jpegdec.h"
 
-#include <stdio.h>
+#include <cstdio>
 #include <malloc.h>
 
 extern "C"

src/CxbxKrnl/CxbxKrnl.cpp

@@ -48,7 +48,7 @@ namespace xboxkrnl
 #include "HLEIntercept.h"
 
 #include <shlobj.h>
-#include <locale.h>
+#include <clocale>
 
 /* prevent name collisions */
 namespace NtDll

src/CxbxKrnl/EmuD3D8.cpp

@@ -52,7 +52,7 @@ namespace xboxkrnl
 #include "ResCxbxDll.h"
 
 #include <process.h>
-#include <locale.h>
+#include <clocale>
 
 // Global(s)
 HWND                                g_hEmuWindow   = NULL; // rendering window

src/CxbxKrnl/EmuD3D8/VertexBuffer.cpp

@@ -40,7 +40,7 @@
 #include "CxbxKrnl/EmuXTL.h"
 #include "CxbxKrnl/ResourceTracker.h"
 
-#include <time.h>
+#include <ctime>
 
 #define VERTEX_BUFFER_CACHE_SIZE 64
 #define MAX_STREAM_NOT_USED_TIME (2 * CLOCKS_PER_SEC) // TODO: Trim the not used time

src/CxbxKrnl/EmuD3D8/VertexBuffer.h

@@ -35,7 +35,7 @@
 #define VERTEXBUFFER_H
 
 #include "Cxbx.h"
-//#include <time.h> // Conflict with io.h
+//#include <ctime> // Conflict with io.h
 
 #define MAX_NBR_STREAMS 16
 

src/CxbxKrnl/EmuDSound.cpp

@@ -50,7 +50,7 @@ namespace xboxkrnl
 #include <mmreg.h>
 #include <msacm.h>
 #include <process.h>
-#include <locale.h>
+#include <clocale>
 
 XTL::X_CMcpxStream::_vtbl XTL::X_CMcpxStream::vtbl =
 {

src/CxbxKrnl/EmuFS.cpp

@@ -46,7 +46,7 @@ namespace xboxkrnl
 
 #undef FIELD_OFFSET     // prevent macro redefinition warnings
 #include <windows.h>
-#include <stdio.h>
+#include <cstdio>
 
 // automatically insert after this many EmuFS() swaps
 uint32 EmuAutoSleepRate = -1;

src/CxbxKrnl/EmuFile.h

@@ -42,7 +42,7 @@ namespace xboxkrnl
     #include <xboxkrnl/xboxkrnl.h>
 };
 
-#include <stdio.h>
+#include <cstdio>
 
 // ******************************************************************
 // * prevent name collisions

src/CxbxKrnl/EmuKrnl.cpp

@@ -40,9 +40,9 @@ namespace xboxkrnl
     #include <xboxkrnl/xboxkrnl.h>
 };
 
-#include <stdio.h>
-#include <ctype.h>
-#include <locale.h>
+#include <cstdio>
+#include <cctype>
+#include <clocale>
 #include <process.h>
 
 // prevent name collisions

src/CxbxKrnl/HLEDataBase/D3D8.1.0.5849.inl

@@ -1170,7 +1170,7 @@ OOVPATable D3D8_1_0_5849[] =
         "EmuIDirect3DTexture8_GetSurfaceLevel2"
         #endif
     },
-    // IDirect3DDevice8::SetLight//(OOVPA*)&IDirect3DDevice8_SetLight_1_0_5558,
+    // IDirect3DDevice8::SetLight
     {
 
         (OOVPA*)&IDirect3DDevice8_SetLight_1_0_5558,

src/CxbxKrnl/HLEIntercept.cpp

@@ -198,7 +198,7 @@ void EmuHLEIntercept(Xbe::LibraryVersion *pLibraryVersion, Xbe::Header *pXbeHead
                 if(BuildVersion == 5659) { BuildVersion = 5558; }
                 if(BuildVersion == 5788) { BuildVersion = 5558; }
                 if(BuildVersion == 5028) { BuildVersion = 4627; }
-                if(BuildVersion == 5933) { BuildVersion = 5849; }   // These XDK versions are pretty mutch the same
+                if(BuildVersion == 5933) { BuildVersion = 5849; }   // These XDK versions are pretty much the same
                 /*
                 if(BuildVersion == 3944) { BuildVersion = 3925; }
                 if(BuildVersion == 4039) { BuildVersion = 4034; }
@@ -273,7 +273,7 @@ void EmuHLEIntercept(Xbe::LibraryVersion *pLibraryVersion, Xbe::Header *pXbeHead
                                 ProcessHeapOffs = 0x51;
                                 RtlCreateHeapOffs = 0x4A;
                             }
-                            if(BuildVersion >= 5233)
+                            else if(BuildVersion >= 5233)
                             {
                                 pFunc = EmuLocateFunction((OOVPA*)&XapiInitProcess_1_0_5233, lower, upper);
                                 ProcessHeapOffs = 0x51;