From 7762e883a8f4dbb61f453c50fff4a23e9743f91e Mon Sep 17 00:00:00 2001 From: RadWolfie Date: Thu, 10 Apr 2025 10:59:03 -0500 Subject: [PATCH] gui: add selection for auto and manual console type --- src/common/Settings.cpp | 5 +++ src/common/Settings.hpp | 9 ++++ src/common/util/cliConfig.cpp | 17 ++++++++ src/common/util/cliConfig.hpp | 1 + src/gui/WndMain.cpp | 77 +++++++++++++++++++++++++++++++++++ src/gui/resource/Cxbx.rc | 7 ++++ src/gui/resource/ResCxbx.h | 6 ++- 7 files changed, 121 insertions(+), 1 deletion(-) diff --git a/src/common/Settings.cpp b/src/common/Settings.cpp index 086fbe305..d3c5d1b03 100644 --- a/src/common/Settings.cpp +++ b/src/common/Settings.cpp @@ -90,6 +90,7 @@ static struct { const char* DataCustomLocation = "DataCustomLocation"; const char* IgnoreInvalidXbeSig = "IgnoreInvalidXbeSig"; const char *IgnoreInvalidXbeSec = "IgnoreInvalidXbeSec"; + const char* ConsoleTypeToggle = "ConsoleTypeToggle"; } sect_gui_keys; static const char* section_core = "core"; @@ -342,6 +343,8 @@ bool Settings::LoadConfig() m_gui.bIgnoreInvalidXbeSig = m_si.GetBoolValue(section_gui, sect_gui_keys.IgnoreInvalidXbeSig, /*Default=*/false); m_gui.bIgnoreInvalidXbeSec = m_si.GetBoolValue(section_gui, sect_gui_keys.IgnoreInvalidXbeSec, /*Default=*/false); + m_gui.ConsoleTypeToggle = (EMU_CONSOLE_TYPE)m_si.GetLongValue(section_gui, sect_gui_keys.ConsoleTypeToggle, /*Default=*/EMU_CONSOLE_TYPE_AUTO); + // ==== GUI End ============= // ==== Core Begin ========== @@ -588,6 +591,8 @@ bool Settings::Save(std::string file_path) m_si.SetBoolValue(section_gui, sect_gui_keys.IgnoreInvalidXbeSig, m_gui.bIgnoreInvalidXbeSig, nullptr, true); m_si.SetBoolValue(section_gui, sect_gui_keys.IgnoreInvalidXbeSec, m_gui.bIgnoreInvalidXbeSec, nullptr, true); + m_si.SetLongValue(section_gui, sect_gui_keys.ConsoleTypeToggle, m_gui.ConsoleTypeToggle, nullptr, true, true); + // ==== GUI End ============= // ==== Core Begin ========== diff --git a/src/common/Settings.hpp b/src/common/Settings.hpp index ff8e65994..deebb19f9 100644 --- a/src/common/Settings.hpp +++ b/src/common/Settings.hpp @@ -46,6 +46,14 @@ extern uint16_t g_LibVersion_DSOUND; "Invalid "#type" size, please verify structure is align, not adding new member, or is using placeholder reserves." \ " Otherwise, please perform versioning upgrade and update "#type" sizeof check." +// Toggle emulation console mode. +typedef enum _EMU_CONSOLE_TYPE { + EMU_CONSOLE_TYPE_AUTO = 0, + EMU_CONSOLE_TYPE_RETAIL = 1, + EMU_CONSOLE_TYPE_DEVKIT = 2, + EMU_CONSOLE_TYPE_CHIHIRO = 3, +} EMU_CONSOLE_TYPE; + // Cxbx-Reloaded's data storage location. typedef enum _CXBX_DATA { CXBX_DATA_INVALID = -1, @@ -91,6 +99,7 @@ public: std::string szCustomLocation = ""; bool bIgnoreInvalidXbeSig; bool bIgnoreInvalidXbeSec; + unsigned int ConsoleTypeToggle; } m_gui; // Core settings diff --git a/src/common/util/cliConfig.cpp b/src/common/util/cliConfig.cpp index 96ac94860..261c4dfdf 100644 --- a/src/common/util/cliConfig.cpp +++ b/src/common/util/cliConfig.cpp @@ -60,6 +60,15 @@ bool hasKey(std::string key) return false; } +// Delete the key if it exist +void DeleteKey(std::string key) +{ + auto found = g_cli_configs.find(key); + if (found != g_cli_configs.end()) { + g_cli_configs.erase(found); + } +} + // Generic getter bool GetValue(const std::string key, std::string* value) { @@ -179,4 +188,12 @@ void SetSystemType(const std::string value) } } +void ClearSystemType() +{ + // Clear any system types key existence. + DeleteKey(cli_config::system_retail); + DeleteKey(cli_config::system_devkit); + DeleteKey(cli_config::system_chihiro); +} + } diff --git a/src/common/util/cliConfig.hpp b/src/common/util/cliConfig.hpp index a3409a9ab..23d798c48 100644 --- a/src/common/util/cliConfig.hpp +++ b/src/common/util/cliConfig.hpp @@ -57,5 +57,6 @@ long long GetSessionID(); void SetLoad(const std::string value); void SetSystemType(const std::string value); +void ClearSystemType(); } diff --git a/src/gui/WndMain.cpp b/src/gui/WndMain.cpp index 4502c57ec..0b62000f1 100644 --- a/src/gui/WndMain.cpp +++ b/src/gui/WndMain.cpp @@ -70,6 +70,8 @@ #define XBOX_LED_FLASH_PERIOD 176 // if you know a more accurate value, put it here +static const char* popup_force_blank_console_type = "By force using the %s console type may cause side effects and may not be used to report to the game compatibility website."; + static int gameLogoWidth, gameLogoHeight; static int splashLogoWidth, splashLogoHeight; @@ -978,6 +980,37 @@ LRESULT CALLBACK WndMain::WndProc(HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lP } break; + case ID_SETTINGS_CONFIG_CONT_AUTO: + { + g_Settings->m_gui.ConsoleTypeToggle = EMU_CONSOLE_TYPE_AUTO; + RefreshMenus(); + } + break; + + case ID_SETTINGS_CONFIG_CONT_RETAIL: + { + g_Settings->m_gui.ConsoleTypeToggle = EMU_CONSOLE_TYPE_RETAIL; + PopupWarning(m_hwnd, popup_force_blank_console_type, "retail"); + RefreshMenus(); + } + break; + + case ID_SETTINGS_CONFIG_CONT_DEVKIT: + { + g_Settings->m_gui.ConsoleTypeToggle = EMU_CONSOLE_TYPE_DEVKIT; + PopupWarning(m_hwnd, popup_force_blank_console_type, "devkit"); + RefreshMenus(); + } + break; + + case ID_SETTINGS_CONFIG_CONT_CHIHIRO: + { + g_Settings->m_gui.ConsoleTypeToggle = EMU_CONSOLE_TYPE_CHIHIRO; + PopupWarning(m_hwnd, popup_force_blank_console_type, "chihiro"); + RefreshMenus(); + } + break; + case ID_SETTINGS_CONFIG_DLOCCUSTOM: { char szDir[MAX_PATH]; @@ -1712,6 +1745,36 @@ void WndMain::RefreshMenus() chk_flag = (g_Settings->m_hacks.SkipRdtscPatching) ? MF_CHECKED : MF_UNCHECKED; CheckMenuItem(settings_menu, ID_HACKS_SKIPRDTSCPATCHING, chk_flag); + switch (g_Settings->m_gui.ConsoleTypeToggle) { + case EMU_CONSOLE_TYPE_AUTO: + CheckMenuItem(settings_menu, ID_SETTINGS_CONFIG_CONT_AUTO, MF_CHECKED); + CheckMenuItem(settings_menu, ID_SETTINGS_CONFIG_CONT_RETAIL, MF_UNCHECKED); + CheckMenuItem(settings_menu, ID_SETTINGS_CONFIG_CONT_DEVKIT, MF_UNCHECKED); + CheckMenuItem(settings_menu, ID_SETTINGS_CONFIG_CONT_CHIHIRO, MF_UNCHECKED); + break; + + case EMU_CONSOLE_TYPE_RETAIL: + CheckMenuItem(settings_menu, ID_SETTINGS_CONFIG_CONT_AUTO, MF_UNCHECKED); + CheckMenuItem(settings_menu, ID_SETTINGS_CONFIG_CONT_RETAIL, MF_CHECKED); + CheckMenuItem(settings_menu, ID_SETTINGS_CONFIG_CONT_DEVKIT, MF_UNCHECKED); + CheckMenuItem(settings_menu, ID_SETTINGS_CONFIG_CONT_CHIHIRO, MF_UNCHECKED); + break; + + case EMU_CONSOLE_TYPE_DEVKIT: + CheckMenuItem(settings_menu, ID_SETTINGS_CONFIG_CONT_AUTO, MF_UNCHECKED); + CheckMenuItem(settings_menu, ID_SETTINGS_CONFIG_CONT_RETAIL, MF_UNCHECKED); + CheckMenuItem(settings_menu, ID_SETTINGS_CONFIG_CONT_DEVKIT, MF_CHECKED); + CheckMenuItem(settings_menu, ID_SETTINGS_CONFIG_CONT_CHIHIRO, MF_UNCHECKED); + break; + + case EMU_CONSOLE_TYPE_CHIHIRO: + CheckMenuItem(settings_menu, ID_SETTINGS_CONFIG_CONT_AUTO, MF_UNCHECKED); + CheckMenuItem(settings_menu, ID_SETTINGS_CONFIG_CONT_RETAIL, MF_UNCHECKED); + CheckMenuItem(settings_menu, ID_SETTINGS_CONFIG_CONT_DEVKIT, MF_UNCHECKED); + CheckMenuItem(settings_menu, ID_SETTINGS_CONFIG_CONT_CHIHIRO, MF_CHECKED); + break; + } + switch (g_Settings->m_gui.DataStorageToggle) { case CXBX_DATA_APPDATA: CheckMenuItem(settings_menu, ID_SETTINGS_CONFIG_DLOCAPPDATA, MF_CHECKED); @@ -2250,6 +2313,20 @@ void WndMain::StartEmulation(HWND hwndParent, DebuggerState LocalDebuggerState / cli_config::SetLoad(m_XbeFilename); cli_config::SetValue(cli_config::hwnd, hwndParent); cli_config::SetValue(cli_config::debug_mode, g_Settings->m_core.KrnlDebugMode); + cli_config::ClearSystemType(); // Require to reset system type in GUI in order to choose the new system option. + if (g_Settings->m_gui.ConsoleTypeToggle > 0) { + switch (g_Settings->m_gui.ConsoleTypeToggle) { + case EMU_CONSOLE_TYPE_RETAIL: + cli_config::SetSystemType(cli_config::system_retail); + break; + case EMU_CONSOLE_TYPE_DEVKIT: + cli_config::SetSystemType(cli_config::system_devkit); + break; + case EMU_CONSOLE_TYPE_CHIHIRO: + cli_config::SetSystemType(cli_config::system_chihiro); + break; + } + } if (g_Settings->m_core.KrnlDebugMode == DM_FILE) { cli_config::SetValue(cli_config::debug_file, g_Settings->m_core.szKrnlDebug); } diff --git a/src/gui/resource/Cxbx.rc b/src/gui/resource/Cxbx.rc index 56b95e61e..d99adfc1a 100644 --- a/src/gui/resource/Cxbx.rc +++ b/src/gui/resource/Cxbx.rc @@ -763,6 +763,13 @@ BEGIN MENUITEM "Config &Network...", ID_SETTINGS_CONFIG_NETWORK,MFT_STRING,MFS_ENABLED MENUITEM "Config &Eeprom...", ID_SETTINGS_CONFIG_EEPROM,MFT_STRING,MFS_ENABLED MENUITEM "Config &Logging...", ID_SETTINGS_CONFIG_LOGGING,MFT_STRING,MFS_ENABLED + POPUP "Config &Console Type..." + BEGIN + MENUITEM "&Auto", ID_SETTINGS_CONFIG_CONT_AUTO + MENUITEM "&Retail", ID_SETTINGS_CONFIG_CONT_RETAIL + MENUITEM "&Devkit", ID_SETTINGS_CONFIG_CONT_DEVKIT + MENUITEM "&Chihiro", ID_SETTINGS_CONFIG_CONT_CHIHIRO + END POPUP "Config &Data Location...", 65535,MFT_STRING,MFS_ENABLED BEGIN MENUITEM "Store in AppData", ID_SETTINGS_CONFIG_DLOCAPPDATA,MFT_STRING,MFS_ENABLED diff --git a/src/gui/resource/ResCxbx.h b/src/gui/resource/ResCxbx.h index eff2e721a..7d062e1e7 100644 --- a/src/gui/resource/ResCxbx.h +++ b/src/gui/resource/ResCxbx.h @@ -354,6 +354,10 @@ #define ID_SETTINGS_IGNOREINVALIDXBESIG 40114 #define ID_SETTINGS_IGNOREINVALIDXBESEC 40115 #define ID_SYNC_TIME_CHANGE 40116 +#define ID_SETTINGS_CONFIG_CONT_AUTO 40117 +#define ID_SETTINGS_CONFIG_CONT_RETAIL 40118 +#define ID_SETTINGS_CONFIG_CONT_DEVKIT 40119 +#define ID_SETTINGS_CONFIG_CONT_CHIHIRO 40120 #define IDC_STATIC -1 // Next default values for new objects @@ -361,7 +365,7 @@ #ifdef APSTUDIO_INVOKED #ifndef APSTUDIO_READONLY_SYMBOLS #define _APS_NEXT_RESOURCE_VALUE 139 -#define _APS_NEXT_COMMAND_VALUE 40117 +#define _APS_NEXT_COMMAND_VALUE 40121 #define _APS_NEXT_CONTROL_VALUE 1308 #define _APS_NEXT_SYMED_VALUE 109 #endif