ShuriZma
/
Cxbx-Reloaded
mirror of https://github.com/Cxbx-Reloaded/Cxbx-Reloaded.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use const string references for profile methods

This commit is contained in:
darkf 2020-04-06 00:17:57 -07:00
parent d20537fe5b
commit 132142d5ae
2 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/common/input/InputWindow.cpp
View File

@ -271,7 +271,7 @@ int InputWindow::EnableDefaultButton()
}
}
InputWindow::ProfileIt InputWindow::FindProfile(std::string& name)
InputWindow::ProfileIt InputWindow::FindProfile(const std::string& name)
{
auto it = std::find_if(g_Settings->m_input_profiles[m_dev_type].begin(),
g_Settings->m_input_profiles[m_dev_type].end(), [&name](const auto& profile) {
@ -280,7 +280,7 @@ InputWindow::ProfileIt InputWindow::FindProfile(std::string& name)
return it;
}
void InputWindow::UpdateProfile(std::string& name, int command)
void InputWindow::UpdateProfile(const std::string& name, int command)
{
switch (command)
{
@ -314,7 +314,7 @@ void InputWindow::UpdateProfile(std::string& name, int command)
}
}
void InputWindow::LoadProfile(std::string& name)
void InputWindow::LoadProfile(const std::string& name)
{
ProfileIt profile = FindProfile(name);
if (profile == g_Settings->m_input_profiles[m_dev_type].end()) {
@ -339,7 +339,7 @@ void InputWindow::LoadProfile(std::string& name)
m_bHasChanges = false;
}
bool InputWindow::SaveProfile(std::string& name)
bool InputWindow::SaveProfile(const std::string& name)
{
if (name == std::string()) {
MessageBox(m_hwnd_window, "Cannot save. Profile name must not be empty", "Cxbx-Reloaded", MB_OK | MB_ICONSTOP | MB_APPLMODAL);
@ -368,7 +368,7 @@ bool InputWindow::SaveProfile(std::string& name)
return true;
}
void InputWindow::DeleteProfile(std::string& name)
void InputWindow::DeleteProfile(const std::string& name)
{
ProfileIt profile = FindProfile(name);
if (profile == g_Settings->m_input_profiles[m_dev_type].end()) {
@ -390,7 +390,7 @@ void InputWindow::DeleteProfile(std::string& name)
g_Settings->m_input_profiles[m_dev_type].erase(profile);
}
void InputWindow::OverwriteProfile(std::string& name)
void InputWindow::OverwriteProfile(const std::string& name)
{
ProfileIt profile = FindProfile(name);
if (profile == g_Settings->m_input_profiles[m_dev_type].end()) {

12
src/common/input/InputWindow.h
View File

@ -56,7 +56,7 @@ public:
void BindButton(int ControlID);
void BindDefault();
void ClearBindings();
void UpdateProfile(std::string& name, int command);
void UpdateProfile(const std::string& name, int command);
void UpdateRumble(int command);
void UpdateCurrentDevice();
bool IsProfileSaved();
@ -66,11 +66,11 @@ private:
typedef std::vector<Settings::s_input_profiles>::iterator ProfileIt;
InputDevice::Input* DetectInput(InputDevice* const Device, int ms);
void DetectOutput(int ms);
ProfileIt FindProfile(std::string& name);
void LoadProfile(std::string& name);
bool SaveProfile(std::string& name);
void DeleteProfile(std::string& name);
void OverwriteProfile(std::string& name);
ProfileIt FindProfile(const std::string& name);
void LoadProfile(const std::string& name);
bool SaveProfile(const std::string& name);
void DeleteProfile(const std::string& name);
void OverwriteProfile(const std::string& name);
void LoadDefaultProfile();
int EnableDefaultButton();