Commit Graph

51 Commits

Author SHA1 Message Date
adelikat 80c36d8155 FirmwareManager - don't use Global, pass in actual dependencies 2020-03-15 16:31:37 -05:00
adelikat 81d6ca335e CoreFileProvider - pass dependencies in, instead of using Globals 2020-03-15 16:10:02 -05:00
adelikat e16dc33722 move some PathManager methods to a PathUtils class in BizHawk.Common 2020-03-15 15:59:10 -05:00
adelikat 348cbd18df
Remove PathManager code that had dependencies on Globals (#1881)
* move one usage of Firwmare method into Firmware config where it is better suited

* PathManager - remove unused code

* move some PathEntry specific logic out of PathManger and into PathEntryCollection extension methods

* PathManager - detangle some exe pathing logic from Global.Config usage, clarify what a completely broken method should actuall do

* move more logic from PathManager to PathEntryCollection extension method

* move absolute path creation to PathEntryCollection, lots of refactoring and simplifying of PathEntries usage

* simplify PathEntryColleciton usage more

* simplify PathEntryCollection more

* break PathEntry classes into separate files, a bit of cleanup

* move Rom path logic out of PathManager into PathEntryCollectionExtensions

* move config UseRecentForRoms and LastRomPath into PathEntries, note that this is a breaking change for previous configs, those values will revert back to default values

* move SaveRamPath logic from PathManager to PathEntryCollections

* move cheats path logic from PathManager to PathEntryCollection

* move another method out of PathManager

* move some Retro hacks to PathEntryCollections, exposes more implicit dependencies

* move savestate logic out of PathManager to PathEntryCollection

* move more logic out of PathManager

* move some savestate logic out of PathManager, move most to MainForm where it is used, detangle some implicit dependencies from SaveSlotManager

* rename method

* move more logic from PathManager to PathCollectionEntry

* movie final Global.Config.PathEntries logic out of PathManager and into PathEnties
2020-03-15 15:12:36 -05:00
adelikat 3c519b0249 refactor CoreFileProvider instantiation, require ICoreFileProvider in CoreComm constructor and remove setter for CFP 2020-03-15 10:09:32 -05:00
adelikat a50467846c simplify CoreFileProvider 2020-03-14 14:50:50 -05:00
adelikat 235ff78e9f Simplify CoreFileProvider - make Firmware private and an explicit dependency 2020-03-14 14:27:13 -05:00
adelikat 6c5dc8532f remove some useless regions 2020-03-14 14:23:13 -05:00
adelikat d72d8e79ff remove Global.Game from retro methods of CoreFileProvider, fix exposed bug that the retroarch core was getting path stuff based on Global.Game before it was being set to the new game 2020-03-14 14:22:23 -05:00
adelikat cd7d907c0d get rid of CoreFileProvider SubFileDirectory 2020-03-14 14:02:19 -05:00
adelikat e655ad3abd remove obsolete ICoreFileProvider.PathSubfile(), and instead pass in the neccessary base path the the bsnes core that needs it 2020-03-14 13:56:20 -05:00
adelikat b2066d9a73 remove obsolete ICoreFileProvider string GetFirmware method and replace the one usage for ti83 shenangians with an inline FirmwareManager usage 2020-03-14 12:39:45 -05:00
adelikat 104689655f remove unused ICoreFileProvider method and implementation 2020-03-14 12:29:30 -05:00
adelikat 16781fa212 FirmwareManager - don't depend on Global.Config 2020-03-14 12:20:28 -05:00
adelikat d1623c32b7 Firmwares manager - depend on Global.Config less 2020-03-14 12:10:53 -05:00
YoshiRulz a8408ed3be
Improve exception docs in BizHawk.Client.Common 2020-01-02 21:51:27 +10:00
adelikat 5a1341dd47 misc cleanups 2019-11-15 17:00:43 -06:00
YoshiRulz 9d0ee22885
Use string interpolation 2019-03-20 15:01:12 +10:00
adelikat 70baf9d306 Client.Common cleanups 2017-05-18 11:36:38 -05:00
adelikat dfea029fe4 Misc cleanups in Client.Common, documentation fixes 2017-05-17 11:16:55 -05:00
nattthebear ebe789eed2 heh 2017-05-10 07:45:23 -04:00
adelikat e0985465b6 misc Client.Common code cleanups 2017-05-09 13:19:55 -05:00
adelikat cdb0802230 Misc Client.Common cleanups 2017-05-09 07:22:56 -05:00
zeromus 53fcc09c08 various bugfixes to system/save pathing and support CAN_DUPE, to stabilize the gambatte and neopop cores 2015-11-08 19:18:08 -06:00
zeromus 5c16f8b107 fix some assorted bugs, and experiments with handling more environment calls 2015-11-07 02:29:04 -06:00
zeromus 7651f418fe usably functional libretro player 2015-11-07 00:14:59 -06:00
zeromus f94460dc46 fix bsnes xml loading 2015-04-21 23:50:15 +00:00
adelikat 817c798eab Remove Global.CoreComm since it was pointless 2015-02-22 20:06:30 +00:00
goyuken 995f670d36 frontend tracks loaded firmware: proof of concept 2015-02-05 23:25:28 +00:00
goyuken 14c8dac1bf expand on r7462 2014-07-31 21:40:25 +00:00
adelikat a5fadb8e0b Some useless cleanup 2014-07-03 18:17:09 +00:00
goyuken 17d6e866a0 pce: refactor CD loading to move bios determination out of RomLoader 2014-02-10 15:26:18 +00:00
goyuken 1f1bb93360 quicknes: some settings stuff, not all finished 2014-01-09 23:50:10 +00:00
adelikat 2f28317f92 A round of code cleanup 2014-01-08 03:53:53 +00:00
adelikat 7482cfdc5e a round of code cleanup in Client.Common 2013-12-30 01:58:44 +00:00
goyuken 75d39ac60f SNES: connect to new settings system.. everything should work? 2013-12-27 17:59:19 +00:00
goyuken 82c82b681a connect a26 to the new settings setup. unlike all those before it, the menus have changed a bit, but all of the functionality is still there. in movie 2.0, a26 will store the two difficulty switches and the bw\color switch as syncsettings 2013-12-24 20:50:53 +00:00
goyuken bdfbafdfca SMS: support new settings infrastructure. this adds enableFM and allowOverclock as sync relevant settings for movie files (but of course, they won't end up in Movie 1.0 files) 2013-12-24 01:06:17 +00:00
goyuken a5cdee3780 pce: connect to new settings system 2013-12-22 05:58:24 +00:00
goyuken bd205f47dc update our newtonsoft json.net to version 5.0 release 8. this fixes up abstract class handling so that the CoreSettings can work correctly.
tweak Binding, RecentFiles, and PathEntry to work with the new serializer.  on updating to this revision, you should be able to keep all config.ini settings except for hotkey bindings, path layouts, and recent files list.
start implementation of new CoreSettings and CoreSyncSettings.  at the moment, it's only partially done for NES.
2013-12-22 00:44:39 +00:00
goyuken 43d5bd7b7e fix compile problem, sorry 2013-12-21 18:34:13 +00:00
zeromus 483cf96853 rename PathEntries.WatchPath etc. to PathEntries.WatchPathFragment to better convey the idea that it isnt a fully-qualified path, so its less likely to get used on accident 2013-12-13 05:20:50 +00:00
goyuken 013de207d8 remove a few no longer used corecomm path hookups 2013-12-11 01:51:41 +00:00
goyuken e95d7b8cd7 fix the mess i made yesterday with IEmuLoadHelper (I did not know at the time, but it's 99% the same as the existing ICoreFileProvider) 2013-12-10 17:58:12 +00:00
adelikat 9751fd5a1a Move interfaces and base implemenations from emulation to emulation.common 2013-11-04 01:39:19 +00:00
adelikat 187e169de9 a round of cleanup on MianForm.cs, and an attempt to start organizing methods and variables to make it easier to pull out logic in future refactoring 2013-11-03 02:51:21 +00:00
adelikat d902981f54 move some FirmwareManager things to client.common 2013-11-01 23:17:30 +00:00
adelikat 9473f6840b Client.Common code refactoring and some misc things to do 2013-10-27 17:47:54 +00:00
zeromus 6616a75cfb etc 2013-10-25 00:59:34 +00:00
zeromus 249ddea268 revert to pre-refactor state. its a WIP, dont judge 2013-10-25 00:34:01 +00:00