NROM usually doesn't have WRAM, but iNES 1.0 doesn't specify WRAM size, so its detection just assumes 8KiB WRAM. iNES 2.0 can precisely identify WRAM size.
somewhat fixes 21fbee01de I guess, in particular AskSaveChanges would not save if no file name had been chosen.
This doesn't behave correctly when trying to save a backup or bk2 but when no filename has been chosen that makes no sense anyway, so...
impossible for a human to send to the game via keyboard and mouse, but works fine in movies, so it's been used in tases for decades (?). but we control what happens between frontend and core so why not block this particular input if needed
since they're split and we can't set hi byte to -0, there was no way to turn below -1. [-256, 256] is not an accurate range per se, but due to how things are added on the managed side before sending inputs to the core, it feels like the most useful one. for shorttics one would only have access to hi byte, and with longtics one can still simulate that behavior - by only controlling said hi byte! and only introduce "sub-angle" when it's actually needed for something specific
editing a short in tastudio would be a nightmare, so we split it:
- high byte represents shorttics mode and whole angle values
- low byte is fractional part only available with longtics
...except in Designer files. Done with
`find src -type f -name '*.cs' -exec sed 's/[ \t][ \t]*$//' -i {} \;`
(and again w/ `\r`) followed by
`git restore src/*.Designer.cs`
there's a major slowdown when doing several res changes in the same session, and its need is questionable anyway, because of potential inconsistency of screensize across states and stuff.
Somehow this broke the windows workflow and as lua is shipped by bizhawk on windows and liblua5.3 is installed on ubuntu we don't need any explicit install action.
* Adding dosbox
* Adding placeholder
* Adding initial placeholder for DOSBox
* update
* Update
* Update
* progress
* Progress
* Increasing mem capacity
* Progress
* Now running timer correctly
* Progress
* Stable
* Parsin inputs
* Keyboard working
* stable before using memfiles
* Now accepting rw hdds
* Hard disk rw working
* Fixing conflict
* Getting samples
* Reading samples but sounds too low
* Reading samples but sounds too low
* Now accepting multiple cdrom/floppy images
* Allowing swapping
* Enabling cdrom and disk swapping
* Simplifying
* Simplifying
* Simplifications
* Simplfiications
* Capturing sdl delay
* Adding configuration presets
* Enabling joystick
* Enabling joysticks
* Added mouse support
* Adding mouse support
* Progress with hard disk
* Adding default hard disk images and making them selectable
* Adding mnemonics, more configs, and some refactoring on the standard confs
* Processing file extensions
* Adding sram
* Adding saveram
* Adding drive lights
* Adding drive lights
* Adding memory domains
* Removing warnings
* Fixing warning
* Revert unrelated changes to Multi-Disk Bundler
* Re-alphabetise lists and clean up diff
* Missed a bit
* Make `DOSBox`' `ISaveRam` implementations `override`
* Fix `DOSBox`' `[PortedCore]`
* Clean up string comparisons in `DOSBox` ctor
* Set values for `WriteableHardDiskOptions` instead of translating
* Clean up reading of DOSBox config presets from embedded resources
* Fix code style warning
* Removing duped line
* Fixing extension parsing
* Small adjustments
* Aligning fps to that of normal DOS
* Aligning fps to that of normal DOS
* Simplified extension getting and adding base config file resource
* Remove unused import
* Properly measuring extended mem size
* Adding more settings and simplifying machine presets
* Adding check for SRAM size to prevent wrong-sized HD being loaded
* Removing unnecessary directive
* Update correct DOS framerate
* Adding sensible configuration presets
* Adding to the config preset description text
* Update src/BizHawk.Emulation.Common/Base Implementations/Bk2MnemonicLookup.cs
Co-authored-by: feos <vadosnaprimer@users.noreply.github.com>
* Removing stale config files
* Fixed mouse emulation
* Fixed mouse emulation
* Removing unused keyboard flag
* Addressing feos' comment about virtual height/width
* Fixed bug with saveram
* fix VirtualWidth
scanlines remain constant so they aren't stretched, and width is adjusted to be 4/3 of height, because video modes in DOS were designed for a 4:3 monitor. exact pixel shapes may slightly differ depending on exact pixel clock but setting 4:3 for DOS is standard.
* DependentUpon
* Making FPS configurable
* Making FPS configurable
* Adding fps num/denom
* Implementing proper fps numerator / denominator defaults for DOS
* Passing mouse deltas from bk
* Passing mouse deltas from bk to the core
* expose and use deltas directly
to make it work in hawk, one needs to bind RMouse X/Y for Mouse X/Y Delta in config.ini, by manually editing the file (for now)
* Implementing support for .cue+.bin and other cdrom types
* Fixing sensitivity
* Adjusting mouse sensitivity
* Fixing integration for windows
* [WIP] loading cds from bk
* [WIP] loading cds from bk
* Using .cdrom extension for cdroms, and passing disk name to the read callback
* Using .cdrom extension for cdroms, and passing disk name to the read callback
* Cleanup and fixing .iso loading and swapping
* Fixing .iso loading and cdrom swapping
* Adding default controllers
* Added callback for video updates to prevent tearing
* Removing unnecessary message
* Fix line endings in `Bk2MnemonicLookup.cs`
* Fix indentation
* Fix misc. whitespace crimes
* Drop redundant `<None Remove/>`
* More whitespace fixes
* More code style fixes
* Small fixes
* Fixing misc comments
* Adjusting naming
* Fixing values
* Removing dead code
* Clarifying the source of DOS framerate chosen
* Removing unused variable
* Removing duped assignments
* Fixing typo
* Removing no-longer required SRAM management
* Removing no longer required sram management functions
* Removing no-longer needed SRAM logic
* Fixing framerates as per feos's comment
* Passing init struct for a more tidy initialization. Also fixing identation for good
* Fixing hard landing on failure to load SRAM. This is needed to prevent crashes in dosbox when preserving hard disk contents
* Added missing submodule and artifact
* Reverting unnecessary change
* Removing no longer needd dosbox-iso extensions
* Removing no-longer necessary virtuals
* fix
* Adding lines into readme
* fixing indentation
* Reducing job concurrency for dosbox -- otherwise the server gets overloaded
* adding recursive submodule for dosbox-x
* Simplifying
* Simplifying
* Simplifying
* Simplifying
* Only offer drive switching if more than one drive is present
* Adding proper Disc identification for ISO9660 / Joliet (default target DOS)
* Adding CDROM case
* Moving comments to proper place
* Moving comments to proper place
* Code style fixes
* Clean up handling of Next Disc buttons
* Clean up `DOSBoxKeyboard` definition
* Remove redundant button mnemonic overrides
* remove leftover hack from my initial 2-byte range
it's hard to tell from upstream code what the range should be...
* Fixing mouse buttons getting stuck and aligning mouse speed minmaxes to what dosbox expects
* Removing default framerate for DOS
* set mouse speed range to match raw deltas range
(see 93bc50288f)
since this makes minimal mouse delta 1 now instead of 2 or 3 (they were different for x and y because ranges were different), I readjusted default sensitivity to match default turning in doom in upsteam
* fix casing on public fields
we use PublicField, _privateField, and localVariable casing
this commit also includes WIP to expose attoseconds like mame does, so that 1 value could be used to determine framerate, and movie parsers won't need too many changes to support DOS framerates
* fix num/denom values to match dosbox-x for when it launches into dos
video dump info was not super clear so I relied on values that are actually assigned to `fps` in `VGA_SetupDrawing()`
TODO: check other machines, update sync settings descriptions when we expose render fps info to user
* use an existing thing instead of GetFullName
it was copied from uae where I made it because I didn't know about `Path.GetFileName(rom.RomPath)`, it's now fixed in master too
increased message duration so user could read potentially long filenames (copied from uae too)
* Move init of new `MouseState` to top and eliminate locals
* fix naming for mouse states
* update submodules
* Adding function to get video refresh rate
* Adding report on video refresh rate update
* Revert "Merge branch 'dosbox' of github.com:SergioMartin86/BizHawk into dosbox"
This reverts commit e5b16a6307, reversing
changes made to ced12c51b4.
* Merge branch 'dosbox' of github.com:SergioMartin86/BizHawk into dosbox
* Removing unnecessary directive
* Fixing reboot
* fps notice formatting
* Zero init fps vals
* Using variable framerates
* Now accepting variable framerates as given by the core
* Moving ISO9660 detection lower
* Storing refresh rate in savestate -- update it on load if different
* fix GetFullName()
* Adding function to get number of ran cycles
* Adding ICycleTiming
* attoseconds are obsolete now
* fix loading CDs with spaces in their name
* Message duration needs to be left to the user to configure. Just passing a null
* Setting notify times back to 4 seconds cause these require a bit more time to read/understand
* Updating CycleCount from within wbx
* Simplifying cycle timing
* Removing FPS change notification, using default waiting times
* Updating submodule
* Fixing bug in disc swapping
* Adding drive selection functionality
* fixing period input
* Adding logic to present disc swapping operations from repeating when holding the button
* added defines for drive id
* point submodule to specific branch
---------
Co-authored-by: YoshiRulz <OSSYoshiRulz+git@gmail.com>
Co-authored-by: feos <vadosnaprimer@users.noreply.github.com>
Co-authored-by: feos <feykomylce@gmail.com>
this was causing a warning to appear, see microsoft/vstest#3475
don't entirely remember why it was necessary to pass
this, originally `-a`, at all; it's in the first commit d91c477e5
CasualPokePlayer