Enable CA1065 and fix noncompliance

"Do not raise exceptions in unexpected locations" (e.g. static ctors and
`IDisposable.Dispose`, but also prop getters which is a bit annoying)

.global.editorconfig.ini

@@ -59,6 +59,8 @@ dotnet_diagnostic.BHI3300.severity = error
 
 # Do not declare static members on generic types
 dotnet_diagnostic.CA1000.severity = error
+# Do not raise exceptions in unexpected locations
+dotnet_diagnostic.CA1065.severity = warning
 
 ## Globalization rules
 

src/BizHawk.Bizware.Graphics/OpenGL/SDL2OpenGLContext.cs

@@ -20,6 +20,7 @@ namespace BizHawk.Bizware.Graphics
 	/// </summary>
 	public class SDL2OpenGLContext : IDisposable
 	{
+#pragma warning disable CA1065 // not sure how else to handle failure other than throwing with a good message
 		static SDL2OpenGLContext()
 		{
 			if (OSTailoredCode.IsUnixHost)
@@ -101,6 +102,7 @@ namespace BizHawk.Bizware.Graphics
 			// it's not needed and can be dangerous in some rare cases
 			SDL_SetHintWithPriority(SDL_HINT_WINDOWS_ENABLE_MESSAGELOOP, "0", SDL_HintPriority.SDL_HINT_OVERRIDE);
 		}
+#pragma warning restore CA1065
 
 #if DEBUG_OPENGL
 		private static readonly DebugProc _debugProc = DebugCallback;

src/BizHawk.Client.Common/Api/Classes/MemoryApi.cs

@@ -48,7 +48,9 @@ namespace BizHawk.Client.Common
 				{
 					var error = $"Error: {Emulator.Attributes().CoreName} does not implement memory domains";
 					LogCallback(error);
+#pragma warning disable CA1065 // yes, really throw
 					throw new NotImplementedException(error);
+#pragma warning restore CA1065
 				}
 				return MemoryDomainCore;
 			}
@@ -62,7 +64,9 @@ namespace BizHawk.Client.Common
 				{
 					var error = $"Error: {Emulator.Attributes().CoreName} does not implement memory domains";
 					LogCallback(error);
+#pragma warning disable CA1065 // yes, really throw
 					throw new NotImplementedException(error);
+#pragma warning restore CA1065
 				}
 				return MemoryDomainCore.MainMemory.Name;
 			}

src/BizHawk.Client.EmuHawk/FormBase.cs

@@ -67,7 +67,9 @@ namespace BizHawk.Client.EmuHawk
 			get
 			{
 				if (DesignMode) return PLACEHOLDER_TITLE;
+#pragma warning disable CA1065 // yes, really throw
 				throw new NotImplementedException("you have to implement this; the Designer prevents this from being an abstract method");
+#pragma warning restore CA1065
 			}
 		}
 

src/BizHawk.Common/Extensions/PathExtensions.cs

@@ -222,7 +222,9 @@ namespace BizHawk.Common.PathExtensions
 			{
 				var dirPath = AppContext.BaseDirectory;
 				DataDirectoryPath = ExeDirectoryPath = string.IsNullOrEmpty(dirPath)
+#pragma warning disable CA1065 // yes, really throw
 					? throw new Exception("failed to get location of executable, very bad things must have happened")
+#pragma warning restore CA1065
 					: dirPath.RemoveSuffix('\\');
 				DllDirectoryPath = Path.Combine(ExeDirectoryPath, "dll");
 			}

src/BizHawk.Common/MemoryBlock/MemoryBlockUtils.cs

@@ -52,7 +52,9 @@ namespace BizHawk.Common
 			if (PageSize != Environment.SystemPageSize)
 			{
 				// We can do it, but we'll have to change up some waterbox stuff
+#pragma warning disable CA1065 // yes, really throw
 				throw new InvalidOperationException("Wrong page size");
+#pragma warning restore CA1065
 			}
 		}
 

src/BizHawk.Emulation.Common/Base Implementations/LinkedDebuggable.cs

@@ -53,6 +53,8 @@ namespace BizHawk.Emulation.Common
 		public void Step(StepType type) => throw new NotImplementedException();
 
 		[FeatureNotImplemented]
+#pragma warning disable CA1065 // convention for [FeatureNotImplemented] is to throw NIE
 		public long TotalExecutedCycles => throw new NotImplementedException();
+#pragma warning restore CA1065
 	}
 }

src/BizHawk.Emulation.Cores/Computers/Commodore64/Serial/Drive1541.IDebuggable.cs

@@ -146,6 +146,9 @@ namespace BizHawk.Emulation.Cores.Computers.Commodore64.Serial
 		private const byte Rts = 0x60;
 		private const byte JsrSize = 3;
 
+		[FeatureNotImplemented]
+#pragma warning disable CA1065 // convention for [FeatureNotImplemented] is to throw NIE
 		public IMemoryCallbackSystem MemoryCallbacks => throw new NotImplementedException();
+#pragma warning restore CA1065
 	}
 }

src/BizHawk.Emulation.Cores/Consoles/Atari/jaguar/VirtualJaguar.IDebuggable.cs

@@ -88,7 +88,9 @@ namespace BizHawk.Emulation.Cores.Atari.Jaguar
 
 		[FeatureNotImplemented]
 		public long TotalExecutedCycles
+#pragma warning disable CA1065 // convention for [FeatureNotImplemented] is to throw NIE
 			=> throw new NotImplementedException();
+#pragma warning restore CA1065
 
 		public IMemoryCallbackSystem MemoryCallbacks => _memoryCallbacks;
 

src/BizHawk.Emulation.Cores/Consoles/Atari/lynx/Lynx.IInputPollable.cs

@@ -12,7 +12,9 @@ namespace BizHawk.Emulation.Cores.Atari.Lynx
 		public IInputCallbackSystem InputCallbacks
 		{
 			[FeatureNotImplemented]
+#pragma warning disable CA1065 // convention for [FeatureNotImplemented] is to throw NIE
 			get => throw new NotImplementedException();
+#pragma warning restore CA1065
 		}
 	}
 }

src/BizHawk.Emulation.Cores/Consoles/Coleco/ColecoVision.IInputPollable.cs

@@ -19,7 +19,9 @@ namespace BizHawk.Emulation.Cores.ColecoVision
 		public IInputCallbackSystem InputCallbacks
 		{
 			[FeatureNotImplemented]
+#pragma warning disable CA1065 // convention for [FeatureNotImplemented] is to throw NIE
 			get => throw new NotImplementedException();
+#pragma warning restore CA1065
 		}
 
 		private int _lagCount = 0;

src/BizHawk.Emulation.Cores/Consoles/Nintendo/Ares64/Ares64.IDebuggable.cs

@@ -46,12 +46,16 @@ namespace BizHawk.Emulation.Cores.Consoles.Nintendo.Ares64
 		public void SetCpuRegister(string register, int value) => throw new NotImplementedException();
 
 		[FeatureNotImplemented]
+#pragma warning disable CA1065 // convention for [FeatureNotImplemented] is to throw NIE
 		public IMemoryCallbackSystem MemoryCallbacks => throw new NotImplementedException();
+#pragma warning restore CA1065
 
 		public bool CanStep(StepType type) => false;
 
 		[FeatureNotImplemented]
+#pragma warning disable CA1065 // convention for [FeatureNotImplemented] is to throw NIE
 		public long TotalExecutedCycles => throw new NotImplementedException();
+#pragma warning restore CA1065
 
 		[FeatureNotImplemented]
 		public void Step(StepType type) => throw new NotImplementedException();

src/BizHawk.Emulation.Cores/Consoles/Nintendo/N64/N64.IDebuggable.cs

@@ -96,7 +96,9 @@ namespace BizHawk.Emulation.Cores.Nintendo.N64
 		}
 
 		[FeatureNotImplemented]
+#pragma warning disable CA1065 // convention for [FeatureNotImplemented] is to throw NIE
 		public long TotalExecutedCycles => throw new NotImplementedException();
+#pragma warning restore CA1065
 
 		public void Step(StepType type)
 		{

src/BizHawk.Emulation.Cores/Consoles/Nintendo/QuickNES/QuickNES.IDebuggable.cs

@@ -34,10 +34,14 @@ namespace BizHawk.Emulation.Cores.Consoles.Nintendo.QuickNES
 		public IMemoryCallbackSystem MemoryCallbacks
 		{
 			[FeatureNotImplemented]
+#pragma warning disable CA1065 // convention for [FeatureNotImplemented] is to throw NIE
 			get => throw new NotImplementedException();
+#pragma warning restore CA1065
 		}
 
 		[FeatureNotImplemented]
+#pragma warning disable CA1065 // convention for [FeatureNotImplemented] is to throw NIE
 		public long TotalExecutedCycles => throw new NotImplementedException();
+#pragma warning restore CA1065
 	}
 }

src/BizHawk.Emulation.Cores/Consoles/Nintendo/QuickNES/QuickNES.IInputPollable.cs

@@ -10,7 +10,9 @@ namespace BizHawk.Emulation.Cores.Consoles.Nintendo.QuickNES
 		public IInputCallbackSystem InputCallbacks
 		{
 			[FeatureNotImplemented]
+#pragma warning disable CA1065 // convention for [FeatureNotImplemented] is to throw NIE
 			get => throw new NotImplementedException();
+#pragma warning restore CA1065
 		}
 	}
 }

src/BizHawk.Emulation.Cores/Consoles/Nintendo/SNES/LibsnesApi.cs

@@ -29,7 +29,9 @@ namespace BizHawk.Emulation.Cores.Nintendo.SNES
 		{
 			if (sizeof(CommStruct) != 368)
 			{
+#pragma warning disable CA1065 // yes, really throw
 				throw new InvalidOperationException("sizeof(comm)");
+#pragma warning restore CA1065
 			}
 		}
 

src/BizHawk.Emulation.Cores/Consoles/Nintendo/SNES/LibsnesCore.IDebuggable.cs

@@ -62,6 +62,8 @@ namespace BizHawk.Emulation.Cores.Nintendo.SNES
 		}
 
 		[FeatureNotImplemented]
+#pragma warning disable CA1065 // convention for [FeatureNotImplemented] is to throw NIE
 		public long TotalExecutedCycles => throw new NotImplementedException();
+#pragma warning restore CA1065
 	}
 }

src/BizHawk.Emulation.Cores/Consoles/Sega/gpgx64/GPGX.IDebuggable.cs

@@ -51,7 +51,9 @@ namespace BizHawk.Emulation.Cores.Consoles.Sega.gpgx
 					return _memoryCallbacks;
 				}
 
+#pragma warning disable CA1065 // I guess this is like a conditional [FeatureNotImplemented], for which the convention is to throw NIE
 				throw new NotImplementedException();
+#pragma warning restore CA1065
 			}
 		}
 
@@ -61,7 +63,9 @@ namespace BizHawk.Emulation.Cores.Consoles.Sega.gpgx
 		public void Step(StepType type) => throw new NotImplementedException();
 
 		[FeatureNotImplemented]
+#pragma warning disable CA1065 // convention for [FeatureNotImplemented] is to throw NIE
 		public long TotalExecutedCycles => throw new NotImplementedException();
+#pragma warning restore CA1065
 
 		private readonly MemoryCallbackSystem _memoryCallbacks = new([ "M68K BUS" ]);
 

src/BizHawk.Emulation.Cores/Consoles/Sony/PSX/Octoshock.IDebuggable.cs

@@ -85,7 +85,9 @@ namespace BizHawk.Emulation.Cores.Sony.PSX
 		public void Step(StepType type) => throw new NotImplementedException();
 
 		[FeatureNotImplemented]
+#pragma warning disable CA1065 // convention for [FeatureNotImplemented] is to throw NIE
 		public long TotalExecutedCycles => throw new NotImplementedException();
+#pragma warning restore CA1065
 
 		private OctoshockDll.ShockCallback_Mem mem_cb;
 

src/BizHawk.Emulation.Cores/Consoles/Sony/PSX/Octoshock.cs

@@ -874,7 +874,9 @@ namespace BizHawk.Emulation.Cores.Sony.PSX
 		public IInputCallbackSystem InputCallbacks
 		{
 			[FeatureNotImplemented]
+#pragma warning disable CA1065 // convention for [FeatureNotImplemented] is to throw NIE
 			get => throw new NotImplementedException();
+#pragma warning restore CA1065
 		}
 
 		public bool DeterministicEmulation => true;

src/BizHawk.Emulation.Cores/Consoles/WonderSwan/WonderSwan.cs

@@ -129,7 +129,9 @@ namespace BizHawk.Emulation.Cores.WonderSwan
 		public void Step(StepType type) => throw new NotImplementedException();
 
 		[FeatureNotImplemented]
+#pragma warning disable CA1065 // convention for [FeatureNotImplemented] is to throw NIE
 		public long TotalExecutedCycles => throw new NotImplementedException();
+#pragma warning restore CA1065
 
 		private BizSwan.MemoryCallback ReadCallbackD;
 		private BizSwan.MemoryCallback WriteCallbackD;

src/BizHawk.Emulation.Cores/Libretro/Libretro.IInputPollable.cs

@@ -14,7 +14,9 @@ namespace BizHawk.Emulation.Cores.Libretro
 		public bool IsLagFrame { get; set; }
 
 		[FeatureNotImplemented]
+#pragma warning disable CA1065 // convention for [FeatureNotImplemented] is to throw NIE
 		public IInputCallbackSystem InputCallbacks => throw new NotImplementedException();
+#pragma warning restore CA1065
 
 		private readonly short[] _joypad0States = new short[(int)RETRO_DEVICE_ID_JOYPAD.LAST];
 		private readonly short[] _joypad1States = new short[(int)RETRO_DEVICE_ID_JOYPAD.LAST];