From f99b8fa51808f99c26d9f59d09e3a4a0e81159ae Mon Sep 17 00:00:00 2001
From: YoshiRulz <OSSYoshiRulz+git@gmail.com>
Date: Fri, 4 Oct 2024 23:39:32 +1000
Subject: [PATCH] Use `PathEntryCollection.FirmwareAbsolutePath` extension

---
 src/BizHawk.Client.Common/fwmanager/FirmwareManager.cs | 2 +-
 src/BizHawk.Common/Extensions/CollectionExtensions.cs  | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/BizHawk.Client.Common/fwmanager/FirmwareManager.cs b/src/BizHawk.Client.Common/fwmanager/FirmwareManager.cs
index ebbb69bf6b..aa290b09a5 100644
--- a/src/BizHawk.Client.Common/fwmanager/FirmwareManager.cs
+++ b/src/BizHawk.Client.Common/fwmanager/FirmwareManager.cs
@@ -145,7 +145,7 @@ namespace BizHawk.Client.Common
 			var reader = new RealFirmwareReader();
 
 			// build a list of files under the global firmwares path, and build a hash for each of them (as ResolutionInfo) while we're at it
-			var todo = new Queue<DirectoryInfo>(new[] { new DirectoryInfo(pathEntries.AbsolutePathFor(pathEntries.FirmwaresPathFragment, null)) });
+			Queue<DirectoryInfo> todo = [ new(pathEntries.FirmwareAbsolutePath()) ];
 			while (todo.Count != 0)
 			{
 				var di = todo.Dequeue();
diff --git a/src/BizHawk.Common/Extensions/CollectionExtensions.cs b/src/BizHawk.Common/Extensions/CollectionExtensions.cs
index 9802438b2b..a016528466 100644
--- a/src/BizHawk.Common/Extensions/CollectionExtensions.cs
+++ b/src/BizHawk.Common/Extensions/CollectionExtensions.cs
@@ -65,6 +65,11 @@ namespace BizHawk.Common.CollectionExtensions
 			return min;
 		}
 
+		/// <remarks>for collection initializer syntax</remarks>
+		[MethodImpl(MethodImplOptions.AggressiveInlining)]
+		public static void Add<T>(this Queue<T> q, T item)
+			=> q.Enqueue(item);
+
 		/// <exception cref="InvalidOperationException"><paramref name="key"/> not found after mapping <paramref name="keySelector"/> over <paramref name="list"/></exception>
 		/// <remarks>implementation from https://stackoverflow.com/a/1766369/7467292</remarks>
 		public static T BinarySearch<T, TKey>(this IList<T> list, Func<T, TKey> keySelector, TKey key)