ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

"fix" client.bufferwidth and client.bufferheight .... I dont understand why they were doing what they were doing. It seems like such a simple thing, just return the dimensions of the core's videoprovider. Someone should rethink all these (and the surface names, and the padding names) and craft a complete, new design.

This commit is contained in:
zeromus 2017-01-26 00:54:44 -06:00
parent 48e3cdfcdc
commit f7638e8352
2 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
BizHawk.Client.EmuHawk/DisplayManager/DisplayManager.cs
View File

@ -333,7 +333,7 @@ namespace BizHawk.Client.EmuHawk
}
/// <summary>
/// Using the current filter program, turn a emulator screen space coordinat to a window coordinate (suitable for lua layer drawing)
/// Using the current filter program, turn a emulator screen space coordinate to a window coordinate (suitable for lua layer drawing)
/// </summary>
public Point TransformPoint(Point p)
{

17
BizHawk.Client.EmuHawk/tools/Lua/Libraries/EmuLuaLibrary.Client.cs
View File

@ -77,26 +77,23 @@ namespace BizHawk.Client.EmuHawk
[LuaMethodAttributes(
"bufferheight",
"Gets the visible height of the emu display surface, excluding the gameExtraPadding you've set. This function (the whole lot of them) should be renamed or refactored since the padding areas have got more complex."
"Gets the visible height of the emu display surface (the core video output). This excludes the gameExtraPadding you've set."
)]
public int BufferHeight()
{
var height = VideoProvider.BufferHeight;
var point = new System.Drawing.Point(0, height);
return GlobalWin.DisplayManager.TransformPoint(point).Y - BorderHeight();
return VideoProvider.BufferHeight;
//memento of original behaviour from scepheo's commit -- why?
//var point = new System.Drawing.Point(0, height);
//return GlobalWin.DisplayManager.TransformPoint(point).Y - BorderHeight();
}
[LuaMethodAttributes(
"bufferwidth",
"Gets the visible width of the emu display surface, excluding the gameExtraPadding you've set. This function (the whole lot of them) should be renamed or refactored since the padding areas have got more complex."
"Gets the visible width of the emu display surface (the core video output). This excludes the gameExtraPadding you've set."
)]
public int BufferWidth()
{
var width = VideoProvider.BufferWidth;
var point = new System.Drawing.Point(width, 0);
return GlobalWin.DisplayManager.TransformPoint(point).X - BorderWidth();
return VideoProvider.BufferWidth;
}
[LuaMethodAttributes(