From f436e2542630c1f0aea16cca4953b1aafeceb3b0 Mon Sep 17 00:00:00 2001 From: Asnivor Date: Wed, 22 Aug 2018 18:51:20 +0100 Subject: [PATCH] Fix movie header SystemID (#1277) From ticket #1246 Small change to MovieConversionExtensions.PopulateWithDefaultHeaderValues() Just changes SystemID to "GG" or "SG" if Global.Emulator .IsGameGear or IsSG1000 is true. Without this, the play movie dialog shows 'Platform' as SMS for game gear and SG1000 movies (and highlights this in RED as it is incorrect). --- BizHawk.Client.Common/Global.cs | 2 ++ .../movie/conversions/MovieConversionExtensions.cs | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/BizHawk.Client.Common/Global.cs b/BizHawk.Client.Common/Global.cs index edd287ef49..db1ccedf94 100644 --- a/BizHawk.Client.Common/Global.cs +++ b/BizHawk.Client.Common/Global.cs @@ -87,6 +87,8 @@ namespace BizHawk.Client.Common return SystemInfo.Intellivision; case "SG": return SystemInfo.SG; + case "GG": + return SystemInfo.GG; case "SMS": if ((Emulator as SMS).IsGameGear) { diff --git a/BizHawk.Client.Common/movie/conversions/MovieConversionExtensions.cs b/BizHawk.Client.Common/movie/conversions/MovieConversionExtensions.cs index ca8492c3e7..9b0aa4aedf 100644 --- a/BizHawk.Client.Common/movie/conversions/MovieConversionExtensions.cs +++ b/BizHawk.Client.Common/movie/conversions/MovieConversionExtensions.cs @@ -319,11 +319,13 @@ namespace BizHawk.Client.Common.MovieConversionExtensions if (Global.Emulator is SMS && (Global.Emulator as SMS).IsSG1000) { movie.HeaderEntries.Add("IsSGMode", "1"); - } + movie.SystemID = "SG"; + } if (Global.Emulator is SMS && (Global.Emulator as SMS).IsGameGear) { movie.HeaderEntries.Add("IsGGMode", "1"); + movie.SystemID = "GG"; } if (Global.Emulator is GPGX && (Global.Emulator as GPGX).IsMegaCD)