From f056059e4873f69fe5ff2137958cfad892918c4f Mon Sep 17 00:00:00 2001
From: YoshiRulz <OSSYoshiRulz+git@gmail.com>
Date: Thu, 26 Sep 2024 13:23:34 +1000
Subject: [PATCH] Fix collection type in `ServiceNotApplicableAttribute`

---
 src/BizHawk.Emulation.Common/ServiceAttributes.cs | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/src/BizHawk.Emulation.Common/ServiceAttributes.cs b/src/BizHawk.Emulation.Common/ServiceAttributes.cs
index 87e0fd4e4e..7c0f1d09c2 100644
--- a/src/BizHawk.Emulation.Common/ServiceAttributes.cs
+++ b/src/BizHawk.Emulation.Common/ServiceAttributes.cs
@@ -1,5 +1,4 @@
 using System.Collections.Generic;
-using System.Linq;
 
 namespace BizHawk.Emulation.Common
 {
@@ -22,12 +21,9 @@ namespace BizHawk.Emulation.Common
 	[AttributeUsage(AttributeTargets.Class)]
 	public sealed class ServiceNotApplicableAttribute : Attribute
 	{
-		/// <remarks>TODO neither array nor <see cref="IEnumerable{T}"/> is the correct collection to be using here, try <see cref="IReadOnlyList{T}"/>/<see cref="IReadOnlyCollection{T}"/> instead</remarks>
-		public ServiceNotApplicableAttribute(Type[]? types)
-		{
-			NotApplicableTypes = types?.AsEnumerable() ?? Enumerable.Empty<Type>();
-		}
+		public IReadOnlyCollection<Type> NotApplicableTypes { get; }
 
-		public IEnumerable<Type> NotApplicableTypes { get; }
+		public ServiceNotApplicableAttribute(Type[] types)
+			=> NotApplicableTypes = types;
 	}
 }