ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

add in Chinese / Korean language options, remove unneeded firmware checks

This commit is contained in:
CasualPokePlayer 2023-11-04 05:32:17 -07:00
parent e672e9afec
commit eeb824d035
2 changed files with 5 additions and 74 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/BizHawk.Emulation.Cores/Consoles/Nintendo/NDS/MelonDS.ISettable.cs
View File

@ -329,11 +329,14 @@ namespace BizHawk.Emulation.Cores.Consoles.Nintendo.NDS
German,
Italian,
Spanish,
Chinese,
Korean,
}
[DisplayName("Firmware Language")]
[Description("Language in firmware. Only applicable if firmware override is in effect.")]
[DefaultValue(Language.English)]
[TypeConverter(typeof(DescribableEnumConverter))]
public Language FirmwareLanguage { get; set; }
public enum Month : int

76
src/BizHawk.Emulation.Cores/Consoles/Nintendo/NDS/NDSFirmware.cs
View File

@ -6,6 +6,7 @@ using BizHawk.Common;
namespace BizHawk.Emulation.Cores.Consoles.Nintendo.NDS
{
// mostly a c++ -> c# port of melon's firmware verification code
// TODO: a lot of this has been removed as it's not really needed anymore (our c++ code forces correctness everywhere)
internal static class NDSFirmware
{
public static void MaybeWarnIfBadFw(byte[] fw, Action<string> warningCallback)
@ -16,86 +17,13 @@ namespace BizHawk.Emulation.Cores.Consoles.Nintendo.NDS
return;
}
var fwMask = fw.Length - 1;
var badCrc16s = string.Empty;
if (!VerifyCrc16(fw, 0x2C, (fw[0x2C + 1] << 8) | fw[0x2C], 0x0000, 0x2A))
{
badCrc16s += " Wifi ";
}
if (!VerifyCrc16(fw, 0x7FA00 & fwMask, 0xFE, 0x0000, 0x7FAFE & fwMask))
{
badCrc16s += " AP1 ";
}
if (!VerifyCrc16(fw, 0x7FB00 & fwMask, 0xFE, 0x0000, 0x7FBFE & fwMask))
{
badCrc16s += " AP2 ";
}
if (!VerifyCrc16(fw, 0x7FC00 & fwMask, 0xFE, 0x0000, 0x7FCFE & fwMask))
{
badCrc16s += " AP3 ";
}
if (!VerifyCrc16(fw, 0x7FE00 & fwMask, 0x70, 0xFFFF, 0x7FE72 & fwMask))
{
badCrc16s += " USER0 ";
}
if (!VerifyCrc16(fw, 0x7FF00 & fwMask, 0x70, 0xFFFF, 0x7FF72 & fwMask))
{
badCrc16s += " USER1 ";
}
if (badCrc16s != string.Empty)
{
warningCallback("Bad Firmware CRC16(s) detected! Firmware might not work! Bad CRC16(s): " + badCrc16s);
return;
}
if (fw.Length != 0x20000) // no code in DSi firmware
{
// TODO: is this hashing strat actually a good idea?
CheckDecryptedCodeChecksum(fw, warningCallback);
}
}
private static unsafe ushort Crc16(byte* data, int len, int seed)
{
Span<ushort> poly = stackalloc ushort[8] { 0xC0C1, 0xC181, 0xC301, 0xC601, 0xCC01, 0xD801, 0xF001, 0xA001 };
for (var i = 0; i < len; i++)
{
seed ^= data[i];
for (var j = 0; j < 8; j++)
{
if ((seed & 0x1) != 0)
{
seed >>= 1;
seed ^= (poly[j] << (7 - j));
}
else
{
seed >>= 1;
}
}
}
return (ushort)(seed & 0xFFFF);
}
private static unsafe bool VerifyCrc16(byte[] fw, int startaddr, int len, int seed, int crcaddr)
{
var storedCrc16 = (ushort)((fw[crcaddr + 1] << 8) | fw[crcaddr]);
fixed (byte* start = &fw[startaddr])
{
var actualCrc16 = Crc16(start, len, seed);
return storedCrc16 == actualCrc16;
}
}
[DllImport("libfwunpack", CallingConvention = CallingConvention.Cdecl)]
private static extern bool GetDecryptedFirmware(byte[] fw, int fwlen, out IntPtr decryptedFw, out int decryptedlen);