From e68243fca52101be7c4df3f01978b93f7ab134f5 Mon Sep 17 00:00:00 2001
From: YoshiRulz <OSSYoshiRulz+git@gmail.com>
Date: Sun, 8 Sep 2024 21:45:11 +1000
Subject: [PATCH] Attempt to restore InputRoll invariant during Select All (see
#3971)
I believe this method was already non-atomic so this clear operation
shouldn't change anything
---
src/BizHawk.Client.EmuHawk/CustomControls/InputRoll/InputRoll.cs | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/BizHawk.Client.EmuHawk/CustomControls/InputRoll/InputRoll.cs b/src/BizHawk.Client.EmuHawk/CustomControls/InputRoll/InputRoll.cs
index 2d7d06e205..c1da181561 100644
--- a/src/BizHawk.Client.EmuHawk/CustomControls/InputRoll/InputRoll.cs
+++ b/src/BizHawk.Client.EmuHawk/CustomControls/InputRoll/InputRoll.cs
@@ -587,6 +587,7 @@ namespace BizHawk.Client.EmuHawk
public void SelectAll()
{
+ _selectedItems.Clear();
var oldFullRowVal = FullRowSelect;
FullRowSelect = true;
for (int i = 0; i < RowCount; i++)