ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Replaced LINQ query with for loop. 

Upon reflection, the query looked nice, but was inferior to a plain for loop because it would have to create n anonymous objects to process the list, even with LINQ's filtering optimization, due to select preceding where.
This commit is contained in:
Zach 2019-12-02 16:37:55 -08:00
parent ac2c42ef74
commit e621876453
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
BizHawk.Client.Common/tools/Watch/WatchList/WatchList.cs
View File

@ -231,11 +231,14 @@ namespace BizHawk.Client.Common
/// <param name="reverse">Defines the order of the sort. Ascending (true) or descending (false)</param>
public void OrderWatches(string column, bool reverse)
{
var separatorIndices = _watchList.Select((w, i) => new { watch = w, index = i })
.Where(w => w.watch.IsSeparator)
.Select(w => w.index)
.ToList();
var separatorIndices = new List<int>();
for (var i = 0; i < _watchList.Count; i++)
{
if (_watchList[i].IsSeparator)
{
separatorIndices.Add(i);
}
}
separatorIndices.Add(_watchList.Count);
// Sort "blocks" of addresses between separators.