ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Support `ref structType` in BizInvoker 

Could be useful if you need a struct type on the C# side for perf reasons, maybe to avoid allocations.  Like with passing classes, this is just a pointer conversion:  BizInvoker's design philisophy explicitly leaves out any sort of recursive field conversion that would necessitate making new objects.
This commit is contained in:
nattthebear 2021-05-16 11:38:08 -04:00
parent a18ea12bc0
commit e0a357f68d
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/BizHawk.BizInvoke/BizInvoker.cs
View File

@ -486,10 +486,11 @@ namespace BizHawk.BizInvoke
if (type.IsByRef)
{
// Just pass a raw pointer. In the `ref structType` case, caller needs to ensure fields are compatible.
var et = type.GetElementType()!;
if (!et.IsPrimitive && !et.IsEnum)
if (!et.IsValueType)
{
throw new NotImplementedException("Only refs of primitive or enum types are supported!");
throw new NotImplementedException("Only refs of value types are supported!");
}
return new(
typeof(IntPtr),
@ -642,6 +643,7 @@ namespace BizHawk.BizInvoke
if (type.IsClass)
{
// non ref of class can just be passed as pointer
// Just like in the `ref struct` case, if the fields aren't compatible, that's the caller's problem.
return new(
typeof(IntPtr),
() =>

6
src/BizHawk.Emulation.Cores/Consoles/Nintendo/BSNES/BsnesApi.cs
View File

@ -18,7 +18,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.BSNES
[BizImport(CallingConvention.Cdecl)]
public abstract void snes_set_video_enabled(bool enabled);
[BizImport(CallingConvention.Cdecl)]
public abstract void snes_set_layer_enables(BsnesApi.LayerEnables layerEnables);
public abstract void snes_set_layer_enables(ref BsnesApi.LayerEnables layerEnables);
[BizImport(CallingConvention.Cdecl)]
public abstract void snes_set_trace_enabled(bool enabled);
@ -144,10 +144,8 @@ namespace BizHawk.Emulation.Cores.Nintendo.BSNES
public delegate string snes_path_request_t(int slot, string hint, bool required);
public delegate void snes_trace_t(string disassembly, string register_info);
// I cannot use a struct here because marshalling is retarded for bool (4 bytes). I honestly cannot
[StructLayout(LayoutKind.Sequential)]
public class LayerEnables
public struct LayerEnables
{
public bool BG1_Prio0, BG1_Prio1;
public bool BG2_Prio0, BG2_Prio1;

2
src/BizHawk.Emulation.Cores/Consoles/Nintendo/BSNES/BsnesCore.IEmulator.cs
View File

@ -47,7 +47,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.BSNES
Obj_Prio3 = _settings.ShowOBJ_3
};
// TODO: I really don't think stuff like this should be set every single frame (only on change)
Api.core.snes_set_layer_enables(enables);
Api.core.snes_set_layer_enables(ref enables);
Api.core.snes_set_trace_enabled(_tracer.Enabled);
Api.core.snes_set_video_enabled(render);
Api.core.snes_set_audio_enabled(renderSound);