ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Enable some more Analyzer rules

This commit is contained in:
YoshiRulz 2022-03-08 10:41:38 +10:00
parent 02e4a4b97e
commit dd455580d6
No known key found for this signature in database
GPG Key ID: C4DE31C245353FB7
2 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
Common.ruleset
View File

@ -83,7 +83,7 @@
<Rule Id="CA1001" Action="Hidden" /> <Rule Id="CA1001" Action="Hidden" />
<!-- Mark assemblies with assembly version --> <!-- Mark assemblies with assembly version -->
<Rule Id="CA1016" Action="Hidden" /> <Rule Id="CA1016" Action="Warning" />
<!-- Enum Storage should be Int32 --> <!-- Enum Storage should be Int32 -->
<Rule Id="CA1028" Action="Hidden" /> <Rule Id="CA1028" Action="Hidden" />
@ -242,7 +242,7 @@
<Rule Id="CA1825" Action="Hidden" /> <Rule Id="CA1825" Action="Hidden" />
<!-- Do not use Count() or LongCount() when Any() can be used --> <!-- Do not use Count() or LongCount() when Any() can be used -->
<Rule Id="CA1827" Action="Hidden" /> <Rule Id="CA1827" Action="Error" />
<!-- Dispose objects before losing scope --> <!-- Dispose objects before losing scope -->
<Rule Id="CA2000" Action="Hidden" /> <Rule Id="CA2000" Action="Hidden" />
@ -251,7 +251,7 @@
<Rule Id="CA2002" Action="Hidden" /> <Rule Id="CA2002" Action="Hidden" />
<!-- Do not use stackalloc in loops --> <!-- Do not use stackalloc in loops -->
<Rule Id="CA2014" Action="Hidden" /> <Rule Id="CA2014" Action="Error" />
<!-- Review SQL queries for security vulnerabilities --> <!-- Review SQL queries for security vulnerabilities -->
<Rule Id="CA2100" Action="Hidden" /> <Rule Id="CA2100" Action="Hidden" />
@ -269,7 +269,7 @@
<Rule Id="CA2213" Action="Hidden" /> <Rule Id="CA2213" Action="Hidden" />
<!-- Do not call overridable methods in constructors --> <!-- Do not call overridable methods in constructors -->
<Rule Id="CA2214" Action="Hidden" /> <Rule Id="CA2214" Action="Error" />
<!-- Disposable types should declare finalizer --> <!-- Disposable types should declare finalizer -->
<Rule Id="CA2216" Action="Hidden" /> <Rule Id="CA2216" Action="Hidden" />
@ -325,7 +325,7 @@
<Rule Id="SA1005" Action="Hidden" /> <Rule Id="SA1005" Action="Hidden" />
<!-- Preprocessor keywords should not be preceded by space --> <!-- Preprocessor keywords should not be preceded by space -->
<Rule Id="SA1006" Action="Hidden" /> <Rule Id="SA1006" Action="Error" />
<!-- Opening parenthesis should be spaced correctly --> <!-- Opening parenthesis should be spaced correctly -->
<Rule Id="SA1008" Action="Hidden" /> <Rule Id="SA1008" Action="Hidden" />
@ -346,7 +346,7 @@
<Rule Id="SA1013" Action="Hidden" /> <Rule Id="SA1013" Action="Hidden" />
<!-- Member access symbols should be spaced correctly --> <!-- Member access symbols should be spaced correctly -->
<Rule Id="SA1019" Action="Hidden" /> <Rule Id="SA1019" Action="Error" />
<!-- Negative signs should be spaced correctly --> <!-- Negative signs should be spaced correctly -->
<Rule Id="SA1021" Action="Hidden" /> <Rule Id="SA1021" Action="Hidden" />
@ -369,7 +369,7 @@
<Rules AnalyzerId="StyleCop.Analyzers" RuleNamespace="StyleCop.Analyzers.ReadabilityRules"> <Rules AnalyzerId="StyleCop.Analyzers" RuleNamespace="StyleCop.Analyzers.ReadabilityRules">
<!-- Do not prefix calls with base unless local implementation exists --> <!-- Do not prefix calls with base unless local implementation exists -->
<Rule Id="SA1100" Action="Hidden" /> <Rule Id="SA1100" Action="Error" />
<!-- Prefix local calls with this --> <!-- Prefix local calls with this -->
<Rule Id="SA1101" Action="Hidden" /> <Rule Id="SA1101" Action="Hidden" />
@ -399,7 +399,7 @@
<Rule Id="SA1118" Action="Hidden" /> <Rule Id="SA1118" Action="Hidden" />
<!-- Comments should contain text --> <!-- Comments should contain text -->
<Rule Id="SA1120" Action="Hidden" /> <Rule Id="SA1120" Action="Warning" />
<!-- Use built-in type alias --> <!-- Use built-in type alias -->
<Rule Id="SA1121" Action="Error" /> <Rule Id="SA1121" Action="Error" />

2
src/BizHawk.Emulation.Cores/BizHawk.Emulation.Cores.csproj
View File

@ -5,7 +5,7 @@
<Import Project="../MainSlnCommon.props" /> <Import Project="../MainSlnCommon.props" />
<PropertyGroup> <PropertyGroup>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks> <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<NoWarn>$(NoWarn);SA1137;SA1205;SA1208;SA1400</NoWarn> <NoWarn>$(NoWarn);CA2214;SA1100;SA1120;SA1137;SA1205;SA1208;SA1400</NoWarn>
<Nullable>disable</Nullable> <Nullable>disable</Nullable>
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>