ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cleanup BizHawk.Emulation.Common/Extensions

This commit is contained in:
adelikat 2020-02-15 12:22:16 -06:00
parent 4711546e4a
commit dd3b35a9fe
1 changed files with 4 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
BizHawk.Emulation.Common/Extensions.cs
View File

@ -20,12 +20,7 @@ namespace BizHawk.Emulation.Common.IEmulatorExtensions
public static bool HasVideoProvider(this IEmulator core) public static bool HasVideoProvider(this IEmulator core)
{ {
if (core == null) return core != null && core.ServiceProvider.HasService<IVideoProvider>();
{
return false;
}
return core.ServiceProvider.HasService<IVideoProvider>();
} }
public static IVideoProvider AsVideoProvider(this IEmulator core) public static IVideoProvider AsVideoProvider(this IEmulator core)
@ -208,23 +203,12 @@ namespace BizHawk.Emulation.Common.IEmulatorExtensions
public static bool CanPoke(this MemoryDomain d) public static bool CanPoke(this MemoryDomain d)
{ {
if (!d.Writable) return d.Writable;
{
return false;
}
// once upon a time, we did a try { poke(peek) } here, but that was before Writable was added. the poke(peek) is not acceptable. If there are further problems, make sure Writable is correct.
return true;
} }
public static bool HasRegions(this IEmulator core) public static bool HasRegions(this IEmulator core)
{ {
if (core == null) return core != null && core.ServiceProvider.HasService<IRegionable>();
{
return false;
}
return core.ServiceProvider.HasService<IRegionable>();
} }
public static IRegionable AsRegionable(this IEmulator core) public static IRegionable AsRegionable(this IEmulator core)
@ -297,26 +281,8 @@ namespace BizHawk.Emulation.Common.IEmulatorExtensions
return core.VsyncNumerator() / (double)core.VsyncDenominator(); return core.VsyncNumerator() / (double)core.VsyncDenominator();
} }
// TODO: a better place for these // TODO: a better place for this
public static bool IsImplemented(this MethodInfo info) public static bool IsImplemented(this MethodInfo info)
{
// If a method is marked as Not implemented, it is not implemented no matter what the body is
if (info.GetCustomAttributes(false).Any(a => a is FeatureNotImplementedAttribute))
{
return false;
}
// adelikat: we can't rely on this anymore
// Some methods throw an exception by design, such as ISoundProvider.GetSamplesAsync()
// If async is not provided by the implementation this method will throw an exception
// We need to figure out a reliable way to check specifically for a NotImplementedException, then maybe this method will be more useful
// If a method is not marked but all it does is throw an exception, consider it not implemented
////return !info.ThrowsError();
return true;
}
public static bool IsImplemented(this PropertyInfo info)
{ {
return !info.GetCustomAttributes(false).Any(a => a is FeatureNotImplementedAttribute); return !info.GetCustomAttributes(false).Any(a => a is FeatureNotImplementedAttribute);
} }