ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

put a virtual AskSaveChanges method in ToolFormBase, and only override it when needed, reduces a lot of boilerplate

This commit is contained in:
adelikat 2020-05-03 09:52:36 -05:00
parent 664fb5cb31
commit da5ddf3217
30 changed files with 7 additions and 45 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/BizHawk.Client.EmuHawk/LogWindow.cs
View File

@ -42,7 +42,6 @@ namespace BizHawk.Client.EmuHawk
public void Restart() { }
public bool AskSaveChanges() => true;
public bool UpdateBefore => true;
private void Attach()

2
src/BizHawk.Client.EmuHawk/tools/BasicBot/BasicBot.cs
View File

@ -296,8 +296,6 @@ namespace BizHawk.Client.EmuHawk
}
}
public bool AskSaveChanges() => true;
#endregion
#region Control Events

2
src/BizHawk.Client.EmuHawk/tools/CDL.cs
View File

@ -194,7 +194,7 @@ namespace BizHawk.Client.EmuHawk
lvCDL.RowCount = _cdl.Count;
}
public bool AskSaveChanges()
public override bool AskSaveChanges()
{
// nothing to fear:
if (_cdl == null)

5
src/BizHawk.Client.EmuHawk/tools/Cheats/Cheats.cs
View File

@ -110,11 +110,6 @@ namespace BizHawk.Client.EmuHawk
: Path.GetFileName(Global.CheatList.CurrentFileName);
}
public bool AskSaveChanges()
{
return true;
}
private void LoadFile(FileSystemInfo file, bool append)
{
if (file != null)

2
src/BizHawk.Client.EmuHawk/tools/Debugger/GenericDebugger.IToolForm.cs
View File

@ -156,8 +156,6 @@ namespace BizHawk.Client.EmuHawk
EngageDebugger();
}
public bool AskSaveChanges() => true;
public bool UpdateBefore => false;
}
}

1
src/BizHawk.Client.EmuHawk/tools/GB/GBGPUView.cs
View File

@ -54,7 +54,6 @@ namespace BizHawk.Client.EmuHawk
}
}
public bool AskSaveChanges() => true;
public bool UpdateBefore => true;
public GbGpuView()

2
src/BizHawk.Client.EmuHawk/tools/GB/GBPrinterView.cs
View File

@ -54,8 +54,6 @@ namespace BizHawk.Client.EmuHawk
public bool UpdateBefore => false;
public bool AskSaveChanges() => true;
public void FastUpdate()
{
}

1
src/BizHawk.Client.EmuHawk/tools/GBA/GBAGPUView.cs
View File

@ -29,7 +29,6 @@ namespace BizHawk.Client.EmuHawk
// MobileDetailView memory;
public bool AskSaveChanges() => true;
public bool UpdateBefore => true;
public GbaGpuView()

1
src/BizHawk.Client.EmuHawk/tools/GameShark.cs
View File

@ -30,7 +30,6 @@ namespace BizHawk.Client.EmuHawk
#region IToolForm
public bool UpdateBefore => true;
public bool AskSaveChanges() => true;
public void FastUpdate()
{

2
src/BizHawk.Client.EmuHawk/tools/Genesis/VDPViewer.cs
View File

@ -150,8 +150,6 @@ namespace BizHawk.Client.EmuHawk
UpdateValues();
}
public bool AskSaveChanges() => true;
public bool UpdateBefore => true;
private void bmpViewPal_MouseClick(object sender, MouseEventArgs e)

2
src/BizHawk.Client.EmuHawk/tools/HexEditor/HexEditor.cs
View File

@ -156,8 +156,6 @@ namespace BizHawk.Client.EmuHawk
public bool UpdateBefore => false;
public bool AskSaveChanges() => true;
public void NewUpdate(ToolFormUpdateType type) { }
public void UpdateValues()

2
src/BizHawk.Client.EmuHawk/tools/Lua/LuaConsole.cs
View File

@ -644,7 +644,7 @@ namespace BizHawk.Client.EmuHawk
AddFileWatches();
}
public bool AskSaveChanges()
public override bool AskSaveChanges()
{
if (LuaImp.ScriptList.Changes && !string.IsNullOrEmpty(LuaImp.ScriptList.Filename))
{

2
src/BizHawk.Client.EmuHawk/tools/Macros/MacroInput.cs
View File

@ -102,7 +102,7 @@ namespace BizHawk.Client.EmuHawk
public bool UpdateBefore => true;
public bool AskSaveChanges()
public override bool AskSaveChanges()
{
if (_unsavedZones.Count == 0 || IsDisposed)
{

2
src/BizHawk.Client.EmuHawk/tools/MultiDiskBundler/MultiDiskBundler.cs
View File

@ -77,8 +77,6 @@ namespace BizHawk.Client.EmuHawk
{
}
public bool AskSaveChanges() => true;
public bool UpdateBefore => true;
#endregion

1
src/BizHawk.Client.EmuHawk/tools/NES/NESMusicRipper.cs
View File

@ -26,7 +26,6 @@ namespace BizHawk.Client.EmuHawk
SyncContents();
}
public bool AskSaveChanges() => true;
public bool UpdateBefore => true;
public void Restart()

1
src/BizHawk.Client.EmuHawk/tools/NES/NESNameTableViewer.cs
View File

@ -39,7 +39,6 @@ namespace BizHawk.Client.EmuHawk
#region Public API
public bool AskSaveChanges() => true;
public bool UpdateBefore => true;
public void Restart()

1
src/BizHawk.Client.EmuHawk/tools/NES/NESPPU.cs
View File

@ -59,7 +59,6 @@ namespace BizHawk.Client.EmuHawk
#region Public API
public bool AskSaveChanges() => true;
public bool UpdateBefore => true;
public void NewUpdate(ToolFormUpdateType type) { }

1
src/BizHawk.Client.EmuHawk/tools/PCE/PCEBGViewer.cs
View File

@ -32,7 +32,6 @@ namespace BizHawk.Client.EmuHawk
#region Public API
public bool AskSaveChanges() => true;
public bool UpdateBefore => true;
public unsafe void Generate()

3
src/BizHawk.Client.EmuHawk/tools/PCE/PCESoundDebugger.cs
View File

@ -170,11 +170,8 @@ namespace BizHawk.Client.EmuHawk
{
}
public bool AskSaveChanges() => true;
public bool UpdateBefore => false;
// 32*16 samples, 16bit, mono, 8khz (but we'll change the sample rate)
private static readonly byte[] EmptyWav = {
0x52, 0x49, 0x46, 0x46, 0x24, 0x04, 0x00, 0x00, 0x57, 0x41, 0x56, 0x45, 0x66, 0x6D, 0x74, 0x20,

2
src/BizHawk.Client.EmuHawk/tools/PCE/PCETileViewer.cs
View File

@ -164,8 +164,6 @@ namespace BizHawk.Client.EmuHawk
CheckBoxVDC2_CheckedChanged(null, null);
}
public bool AskSaveChanges() => true;
public bool UpdateBefore => true;
#endregion

2
src/BizHawk.Client.EmuHawk/tools/SMS/VDPViewer.cs
View File

@ -160,8 +160,6 @@ namespace BizHawk.Client.EmuHawk
UpdateValues();
}
public bool AskSaveChanges() => true;
public bool UpdateBefore => true;
private void bmpViewPalette_MouseClick(object sender, MouseEventArgs e)

1
src/BizHawk.Client.EmuHawk/tools/SNES/SNESGraphicsDebugger.cs
View File

@ -41,7 +41,6 @@ namespace BizHawk.Client.EmuHawk
readonly List<DisplayTypeItem> displayTypeItems = new List<DisplayTypeItem>();
public bool UpdateBefore => false;
public bool AskSaveChanges() => true;
[RequiredService]
private LibsnesCore Emulator { get; set; }

2
src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.IToolForm.cs
View File

@ -96,7 +96,7 @@ namespace BizHawk.Client.EmuHawk
}
}
public bool AskSaveChanges()
public override bool AskSaveChanges()
{
if (_suppressAskSave)
{

1
src/BizHawk.Client.EmuHawk/tools/TI83/TI83KeyPad.cs
View File

@ -35,7 +35,6 @@ namespace BizHawk.Client.EmuHawk
#region Public API
public bool AskSaveChanges() => true;
public bool UpdateBefore => false;
public void NewUpdate(ToolFormUpdateType type) { }

1
src/BizHawk.Client.EmuHawk/tools/ToolBox.cs
View File

@ -30,7 +30,6 @@ namespace BizHawk.Client.EmuHawk
public void NewUpdate(ToolFormUpdateType type) { }
public bool AskSaveChanges() => true;
public bool UpdateBefore => false;
public void UpdateValues() { }

2
src/BizHawk.Client.EmuHawk/tools/ToolFormBase.cs
View File

@ -16,6 +16,8 @@ namespace BizHawk.Client.EmuHawk
public IMovieSession MovieSession { get; set; }
public virtual bool AskSaveChanges() => true;
public static FileInfo OpenFileDialog(string currentFile, string path, string fileType, string fileExt)
{
if (!Directory.Exists(path))

2
src/BizHawk.Client.EmuHawk/tools/TraceLogger.cs
View File

@ -95,8 +95,6 @@ namespace BizHawk.Client.EmuHawk
public bool UpdateBefore => false;
public bool AskSaveChanges() => true;
private void SaveConfigSettings()
{
//Tracer.Enabled = LoggingEnabled.Checked;

1
src/BizHawk.Client.EmuHawk/tools/VirtualPads/VirtualpadsTool.cs
View File

@ -129,7 +129,6 @@ namespace BizHawk.Client.EmuHawk
#region IToolForm Implementation
public bool AskSaveChanges() => true;
public bool UpdateBefore => false;
public void Restart()

2
src/BizHawk.Client.EmuHawk/tools/Watch/RamSearch.cs
View File

@ -71,8 +71,6 @@ namespace BizHawk.Client.EmuHawk
[ConfigPersist]
public RamSearchSettings Settings { get; set; }
public bool AskSaveChanges() => true;
public bool UpdateBefore => false;
private void HardSetDisplayTypeDropDown(Common.DisplayType type)

2
src/BizHawk.Client.EmuHawk/tools/Watch/RamWatch.cs
View File

@ -112,7 +112,7 @@ namespace BizHawk.Client.EmuHawk
Changes();
}
public bool AskSaveChanges()
public override bool AskSaveChanges()
{
if (_watches.Changes)
{