From d71eca3b2d50205ea63fc8c5399eff37845d0b7a Mon Sep 17 00:00:00 2001
From: YoshiRulz <OSSYoshiRulz@gmail.com>
Date: Sat, 22 May 2021 08:15:31 +1000
Subject: [PATCH] Implement
 SerializationStabilityTests.TestRoundTripSerialization

---
 .../config/SerializationStabilityTests.cs     | 42 ++++++++++++-------
 1 file changed, 27 insertions(+), 15 deletions(-)

diff --git a/src/BizHawk.Tests/Client.Common/config/SerializationStabilityTests.cs b/src/BizHawk.Tests/Client.Common/config/SerializationStabilityTests.cs
index 4c809a94b6..1fe80d6c29 100644
--- a/src/BizHawk.Tests/Client.Common/config/SerializationStabilityTests.cs
+++ b/src/BizHawk.Tests/Client.Common/config/SerializationStabilityTests.cs
@@ -6,6 +6,7 @@ using BizHawk.Client.Common;
 
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 
+using Newtonsoft.Json;
 using Newtonsoft.Json.Linq;
 
 namespace BizHawk.Tests.Client.Common.config
@@ -13,6 +14,14 @@ namespace BizHawk.Tests.Client.Common.config
 	[TestClass]
 	public sealed class SerializationStabilityTests
 	{
+		private const string BINDING_SER = @"{""DisplayName"":""Frame Advance"",""Bindings"":""F"",""DefaultBinding"":""F"",""TabGroup"":""General"",""ToolTip"":"""",""Ordinal"":0}";
+
+		private const string PATHENTRY_SER = @"{""Type"":""Movies"",""Path"":""./Movies"",""System"":""Global_NULL"",""Ordinal"":4}";
+
+		private const string RECENT_SER = @"{""recentlist"":[],""MAX_RECENT_FILES"":8,""AutoLoad"":false,""Frozen"":false}";
+
+		private const string ZWINDER_SER = @"{""CurrentUseCompression"":false,""CurrentBufferSize"":256,""CurrentTargetFrameLength"":500,""CurrentStoreType"":0,""RecentUseCompression"":false,""RecentBufferSize"":128,""RecentTargetFrameLength"":2000,""RecentStoreType"":0,""GapsUseCompression"":false,""GapsBufferSize"":64,""GapsTargetFrameLength"":125,""GapsStoreType"":0,""AncientStateInterval"":5000,""AncientStoreType"":0}";
+
 #if NET5_0
 		private static readonly IReadOnlySet<Type> KnownGoodFromStdlib = new HashSet<Type>
 #else
@@ -32,18 +41,21 @@ namespace BizHawk.Tests.Client.Common.config
 
 		private static readonly IReadOnlyDictionary<Type, string> KnownGoodFromBizHawk = new Dictionary<Type, string>
 		{
-			[typeof(AnalogBind)] = "TODO",
-			[typeof(BindingCollection)] = "TODO",
-			[typeof(CheatConfig)] = "TODO",
+			[typeof(AnalogBind)] = @"{""Value"":""X1 LeftThumbX Axis"",""Mult"":0.8,""Deadzone"":0.1}",
+			[typeof(Binding)] = BINDING_SER,
+			[typeof(BindingCollection)] = $@"{{""Bindings"":[{BINDING_SER}]}}",
+			[typeof(CheatConfig)] = $@"{{""DisableOnLoad"":false,""LoadFileByGame"":true,""AutoSaveOnClose"":true,""Recent"":{RECENT_SER}}}",
 			[typeof(FeedbackBind)] = "TODO",
-			[typeof(MessagePosition)] = "TODO",
-			[typeof(MovieConfig)] = "TODO",
-			[typeof(PathEntryCollection)] = "TODO",
-			[typeof(RecentFiles)] = "TODO",
-			[typeof(RewindConfig)] = "TODO",
-			[typeof(SaveStateConfig)] = "TODO",
-			[typeof(ToolDialogSettings)] = "TODO",
-			[typeof(ZoomFactors)] = "TODO",
+			[typeof(MessagePosition)] = @"{""X"":0,""Y"":0,""Anchor"":0}",
+			[typeof(MovieConfig)] = $@"{{""MovieEndAction"":3,""EnableBackupMovies"":true,""MoviesOnDisk"":false,""MovieCompressionLevel"":2,""VBAStyleMovieLoadState"":false,""DefaultTasStateManagerSettings"":{ZWINDER_SER}}}",
+			[typeof(PathEntry)] = PATHENTRY_SER,
+			[typeof(PathEntryCollection)] = $@"{{""Paths"":[{PATHENTRY_SER}],""UseRecentForRoms"":false,""LastRomPath"":"".""}}",
+			[typeof(RecentFiles)] = RECENT_SER,
+			[typeof(RewindConfig)] = @"{""UseCompression"":false,""UseDelta"":false,""Enabled"":true,""BufferSize"":512,""TargetFrameLength"":600,""BackingStore"":0}",
+			[typeof(SaveStateConfig)] = @"{""Type"":0,""CompressionLevelNormal"":1,""CompressionLevelRewind"":0,""MakeBackups"":true,""SaveScreenshot"":true,""BigScreenshotSize"":131072,""NoLowResLargeScreenshots"":false}",
+			[typeof(ToolDialogSettings)] = @"{""_wndx"":52,""_wndy"":44,""Width"":796,""Height"":455,""SaveWindowPosition"":true,""TopMost"":false,""FloatingWindow"":true,""AutoLoad"":false}",
+			[typeof(ZoomFactors)] = @"{""NULL"":2,""GB"":3}",
+			[typeof(ZwinderStateManagerSettings)] = ZWINDER_SER,
 		};
 
 		[TestMethod]
@@ -73,16 +85,16 @@ namespace BizHawk.Tests.Client.Common.config
 			CheckAll<Config>();
 		}
 
-#if false
 		[TestMethod]
 		public void TestRoundTripSerialization()
 		{
+			static object Deser(string s, Type type) => JToken.Parse(s).ToObject(type, ConfigService.Serializer)!;
+			static string Ser(object o) => JToken.FromObject(o, ConfigService.Serializer).ToString(Formatting.None);
 			foreach (var kvp in KnownGoodFromBizHawk)
 			{
-				//TODO deserialize kvp.Value as an instance of the type kvp.Key, then reserialize it and compare that to kvp.Value
-				// should probably clean up the types in question first
+				if (kvp.Value == "TODO") continue;
+				Assert.AreEqual(kvp.Value, Ser(Deser(kvp.Value, kvp.Key)), $"{kvp.Key} failed serialization round-trip");
 			}
 		}
-#endif
 	}
 }