ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

IMovie - more usage of MnemonicsGenerator to communicate input

This commit is contained in:
adelikat 2013-12-03 15:22:13 +00:00
parent e7413903db
commit d71ec20df7
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
BizHawk.Client.Common/movie/IMovie.cs
View File

@ -92,7 +92,7 @@ namespace BizHawk.Client.Common
#region Dubious, should reconsider #region Dubious, should reconsider
void CommitFrame(int frameNum, MnemonicsGenerator mg); // Why pass in frameNum? Calling api void CommitFrame(int frameNum, MnemonicsGenerator mg); // Why pass in frameNum? Calling api
void PokeFrame(int frameNum, string input); // Why does this exist as something different than Commit Frame? void PokeFrame(int frameNum, MnemonicsGenerator mg); // Why does this exist as something different than Commit Frame?
LoadStateResult CheckTimeLines(TextReader reader, bool onlyGuid, bool ignoreGuidMismatch, out string errorMessage); // No need to return a status, no reason to have hacky flags, no need to pass a textreader LoadStateResult CheckTimeLines(TextReader reader, bool onlyGuid, bool ignoreGuidMismatch, out string errorMessage); // No need to return a status, no reason to have hacky flags, no need to pass a textreader
void ExtractInputLog(TextReader reader, bool isMultitracking); // how about the movie know if it is multi-tracking rather than having to pass it in void ExtractInputLog(TextReader reader, bool isMultitracking); // how about the movie know if it is multi-tracking rather than having to pass it in

4
BizHawk.Client.Common/movie/Movie.cs
View File

@ -366,10 +366,10 @@ namespace BizHawk.Client.Common
#region Public Misc Methods #region Public Misc Methods
public void PokeFrame(int frameNum, string input) public void PokeFrame(int frameNum, MnemonicsGenerator mg)
{ {
_changes = true; _changes = true;
_log.SetFrameAt(frameNum, input); _log.SetFrameAt(frameNum, mg.GetControllersAsMnemonic());
} }
public void CommitFrame(int frameNum, MnemonicsGenerator mg) public void CommitFrame(int frameNum, MnemonicsGenerator mg)

2
BizHawk.Client.Common/movie/MovieSession.cs
View File

@ -160,7 +160,7 @@ namespace BizHawk.Client.Common
if (!mg.IsEmpty) if (!mg.IsEmpty)
{ {
LatchInputFromPlayer(Global.MovieInputSourceAdapter); LatchInputFromPlayer(Global.MovieInputSourceAdapter);
Movie.PokeFrame(Global.Emulator.Frame, mg.GetControllersAsMnemonic()); Movie.PokeFrame(Global.Emulator.Frame, mg);
} }
else else
{ {

2
BizHawk.Client.Common/movie/TasMovie.cs
View File

@ -185,7 +185,7 @@ namespace BizHawk.Client.Common
throw new NotImplementedException(); throw new NotImplementedException();
} }
public void PokeFrame(int frameNum, string input) public void PokeFrame(int frameNum, MnemonicsGenerator mg)
{ {
throw new NotImplementedException(); throw new NotImplementedException();
} }